Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 May 2023 18:26:39 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Xiaoyao Li <xiaoyao.li@intel.com>
CC:     <kvm@vger.kernel.org>, Jiaan Lu <jiaan.lu@intel.com>,
        Zhang Chen <chen.zhang@intel.com>,
        Sean Christopherson <seanjc@google.com>,
        "Paolo Bonzini" <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Ingo Molnar" <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v2 08/11] KVM: VMX: Advertise
 MITI_ENUM_RETPOLINE_S_SUPPORT
Message-ID: <ZGdO37dJueeGasId@chao-email>
References: <20230414062545.270178-1-chao.gao@intel.com>
 <20230414062545.270178-9-chao.gao@intel.com>
 <7b90b6c6-9574-eb23-0884-d4ba5fbfb039@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <7b90b6c6-9574-eb23-0884-d4ba5fbfb039@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FRXiYTA7P+qa4gQwf6rQ3KiAuYeTCzzaZ/CS9HhDTUv1TREh5sWr0tHn7SuB?=
 =?us-ascii?Q?vrppQMTjJ/DuBxS9hWmXU7wjf2H/48/J12uDC+f2cT7ArAeOi6X+MIBOYDmT?=
 =?us-ascii?Q?KVzbkyTWTxBPP/IrDIsE8Xwl7n+Qfhtu09c7bF65dgO5ZR5VfY3AGV4a961s?=
 =?us-ascii?Q?PHg8/JktmspKwIqX6jZcRXUJg/CrJx7WmdiHwjRIv/cEubqYiDLDRW4T08+C?=
 =?us-ascii?Q?omnB4UNkoKn5VYe395XNdIojHTDMUcJPSMjX6SahyE3qhju8qwaVXsNlqU8z?=
 =?us-ascii?Q?TRDX1pc4Of0kHZQwH0rCM4nzylidYmtFEoE07LsQZPZPX4tLjXcNzY8PDCkk?=
 =?us-ascii?Q?kPHniTuvh1URPCwGHKade93cPimAi00ntiMluF+yadfdmmdlLplnA/vgYXyi?=
 =?us-ascii?Q?KqozaHxUMXsnIG+f5OUBiFRw7gzT7jlqVoBOKK9ZgcNdE4bf7c/zYZN2mnBG?=
 =?us-ascii?Q?0FSCb5y4AN5/Xym0L/3MXqTSOtKu9TzCn9+/IMTh0V9IjBB+XuyDQXyZ9qws?=
 =?us-ascii?Q?zOhHB8/hoXXSxVWjIFCadqWCEXl0rcUyv3nK097t981WqfmJBfk5cOaa/p7/?=
 =?us-ascii?Q?uIiJAYyFeZa/63faOXSQsN3N3JDxauVn4h5XcKwqZhJv/t56DFupXBoyY9Ni?=
 =?us-ascii?Q?FAHe27LbyAhcBgxPtXJ/wIUb2pmmh1DbIGMH+3qCJQvrHT3G9yN57Zwjmg0P?=
 =?us-ascii?Q?L4dGNcTTgKHiuSLoSJ3jrGO9RT/285zBOZ6DPsh8kojzMo7Sh0xq/adSUF3e?=
 =?us-ascii?Q?lOiO6QPHJjkC+FmmN+DdztFvpeHkrP6rx/Eu96p2+LGkcYi3zm7ZWTLuzgde?=
 =?us-ascii?Q?k6CygMvfb3jugrslGIej/48dAyrp/IlBsaIeV98h0sR/nMI53LK+OJFlsY5b?=
 =?us-ascii?Q?f9YEJCf4xSynDJroYIK/5qhTc47e/O+9lIe530MYGZHJFo+ffsByENn7DXiY?=
 =?us-ascii?Q?noQl4NyrcA69kp6k7ZI+G4k6B/ahMR3olG7Qs/7iVHBWV6RUPZGgEB1rwWhk?=
 =?us-ascii?Q?en8SvQmrgvdfvpDrprBm91JD6+hszIDr9AFKf0nAiPLfvSx540qXLZ0b1hne?=
 =?us-ascii?Q?xntWSIY8ihoaZ591tEfwtdHXOBmdoNspsK0haqQ5c169yv+IUVqFAgGgqCK5?=
 =?us-ascii?Q?I/nUUgsH5bMhHZSi5p3NepcjTSpsFBMRzjDZP5e2NBhiLoF2P1g6gLEqZs1L?=
 =?us-ascii?Q?x/4zUPVaOw2X/tgf6Sq2S5hUgUKqNil2zyeJzMhVeF3wdjHmPLtxza6wzUe4?=
 =?us-ascii?Q?PEYgMnYQZ3FolvvwYe1eiHJ9hikVXxmTAVyktpaJW57cBoiSvZR7ibN0AVKR?=
 =?us-ascii?Q?Dggjq1lI81mB5I8iWHtaN0fvPvHlinYJbmctjGs1OcAAmA7XdVd2ciFIVCaA?=
 =?us-ascii?Q?VhgnfpP4XZS5aHWPj9NbMGh3Rq448UbQQapdKMcxYsDaqdMUTpb1pzUsC5qz?=
 =?us-ascii?Q?ZdWa8uG0r+o29lCRDc0/VDVVkzmfpphWd4ROet0/LH8T+jbfY5zm9a5GxWfY?=
 =?us-ascii?Q?lwSR68+31XFQFC7g3C8wiwCa1ptsn7aBlcH8aJuI9U0SGkK8r4ygpPSsA0IC?=
 =?us-ascii?Q?6jecRL6B7YqS1y84U7kSdoo0KrgZDxaPh3IW8F80?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0399630b-b62a-4280-4a81-08db58538ffa
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2023 10:26:52.7774
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qRk5ylaUUYOmbnwQAjp5JkZV95k/Z8yZ6yfZcEHv8T3hECr//5P0WbGPamJMAcrDjmkhk6PM7hpMrYruRTjCeA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8244
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 18, 2023 at 06:25:30PM +0800, Xiaoyao Li wrote:
>> @@ -2173,7 +2173,7 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
>>   	struct vmx_uret_msr *msr;
>>   	int ret = 0;
>>   	u32 msr_index = msr_info->index;
>> -	u64 data = msr_info->data, spec_ctrl_mask;
>> +	u64 data = msr_info->data, arch_msr = 0, spec_ctrl_mask = 0;
>
>Sugget to make arch_msr and spec_ctrl_mask as local variables of each case {}
>block

Sure. Will do

>
>>   	u32 index;
>>   	switch (msr_index) {
>> @@ -2488,6 +2488,24 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
>>   		if (data & ~MITI_CTRL_VALID_BITS)
>>   			return 1;
>> +		if (boot_cpu_has(X86_FEATURE_ARCH_CAPABILITIES))
>> +			rdmsrl(MSR_IA32_ARCH_CAPABILITIES, arch_msr);
>> +
>> +		if (data & MITI_CTRL_RETPOLINE_S_USED &&
>> +		    kvm_cpu_cap_has(X86_FEATURE_RRSBA_CTRL) &&
>
>why kvm_cpu_cap_has() is used here? it means whether KVM supports expose this
>feature to guest. But what we need here is whether host supports this
>feature. Though they might get the same result, we'd better use
>boot_cpu_has() or even read CPUID directly (since cpuid info can be changed
>by clearcpuid magic) to avoid confusion.

OK. This makes sense. I will use boot_cpu_has(). clearcpuid sometimes is
helpful for debugging. I prefer to honor it.

Thanks.