Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-431-g1d6a3ebb56-fm-20230511.001-g1d6a3ebb
Mime-Version: 1.0
Message-Id: <f7edea0c-dbfe-4c16-8134-0656411a837d@app.fastmail.com>
In-Reply-To: <0ee8a26205a041cab9a787ec29201a9f@realtek.com>
References: <20230519045825.28369-1-stanley_chang@realtek.com>
 <20230519045825.28369-2-stanley_chang@realtek.com>
 <0d165c7efbb71a65803abddc364e1c5252b8b939.camel@crapouillou.net>
 <0ee8a26205a041cab9a787ec29201a9f@realtek.com>
Date:   Fri, 19 May 2023 13:01:34 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Stanley Chang" <stanley_chang@realtek.com>,
        "Paul Cercueil" <paul@crapouillou.net>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc:     "Vinod Koul" <vkoul@kernel.org>,
        "Kishon Vijay Abraham I" <kishon@kernel.org>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        "Conor Dooley" <conor+dt@kernel.org>,
        "Alan Stern" <stern@rowland.harvard.edu>,
        "Ray Chi" <raychi@google.com>,
        "Bagas Sanjaya" <bagasdotme@gmail.com>,
        "Eugeniu Rosca" <erosca@de.adit-jv.com>,
        "Michael Grzeschik" <m.grzeschik@pengutronix.de>,
        "Matthias Kaehlcke" <mka@chromium.org>,
        "Flavio Suligoi" <f.suligoi@asem.it>,
        "Mathias Nyman" <mathias.nyman@linux.intel.com>,
        "Bhuvanesh Surachari" <Bhuvanesh_Surachari@mentor.com>,
        "Linus Walleij" <linus.walleij@linaro.org>,
        "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v1 2/3] usb: phy: Add driver for the Realtek SoC USB 2.0/3.0 PHY
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, May 19, 2023, at 12:58, Stanley Chang[=E6=98=8C=E8=82=B2=E5=BE=B7=
] wrote:
>>=20
>> I'm pretty sure that drivers/usb/phy/ is deprecated now...
>>=20
>> New drivers should be written for the generic PHY subsystem in
>> drivers/phy/.

Indeed, I missed that in my review.

> Thanks for your reminder.
> Will drivers/usb/phy be removed?
> Is it not allowed to add new drivers?
>
> In our application, driver/phy is not suitable.
> We need to notify the phy driver when the USB hub port status changes.
> However, generic PHY drivers are designed for various device's PHY.
> And it seems inappropriate to add this function. So we choose to use=20
> driver/usb/phy.=20

If you run into something that works in the old usbphy layer
but can't be done in drivers/phy, I think the better solution
would be to change the drivers/phy/ code to add this.

      Arnd