Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 May 2023 14:15:38 +0300
From:   Alexey Dobriyan <adobriyan@gmail.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] auto, kbuild: flatten KBUILD_CFLAGS
Message-ID: <0c693356-b26e-4e3e-a043-33580dd1294b@p183>
References: <20230518154648.581643-1-adobriyan@gmail.com>
 <20230518133732.ee586408921d6f77c3a96bdf@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230518133732.ee586408921d6f77c3a96bdf@linux-foundation.org>
Precedence: bulk

On Thu, May 18, 2023 at 01:37:32PM -0700, Andrew Morton wrote:
> On Thu, 18 May 2023 18:46:42 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> 
> > Make it slightly easier to see what compiler options are added and
> > removed (and not worry about column limit too!)
> 
> I wish you'd cc'ed Linus.
> 
> Turning those four upper-cased macros into upper-cased inline functions
> is just sad.  If we're going to do this we surely should go around and
> make them lower-case.

I always wanted to rewrite division functions and get rid of our
countless variants:

	q = kdiv(n, d);
	q = kdiv3(n, d, &r);

if it gets in they will be renamed again :-)