Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 May 2023 13:39:47 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Min-Hua Chen <minhuadotchen@gmail.com>
Cc:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: stmmac: compare p->des0 and p->des1 with __le32
 type values
Message-ID: <ZGdgA9jMLJOi1W1+@corigine.com>
References: <20230519112509.40973-1-minhuadotchen@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230519112509.40973-1-minhuadotchen@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?I8FKtEC3V3LJUn7wGE1//yN+w41vx9rzHhWatoMlyjMGCkSl9W7pSLS5Seu7?=
 =?us-ascii?Q?AXqPJbwIcRnwhuWGpqZ/fWavW99BXC/udVZ3sLbZUH94D1NNR9qKeUcXkKZa?=
 =?us-ascii?Q?nTsWDPuTSgJ1/jp9GuyP/jsz1fjFS7D1B1RRUvCxFXn32By5BSJToaqnf41I?=
 =?us-ascii?Q?OI/MLpyt5dAAa2l5b+YCTVsaT1cuVXZmz3pZz4IeKW69GI0EDj8zLIlie8un?=
 =?us-ascii?Q?L/GY93BBii0uq7a68SQ8LmPGSnMno2gSDoDH7/P3TEMf1S9CcEg0Ow5417Ir?=
 =?us-ascii?Q?sank/8OZKgkh7gXnRaZ18GalmOv0+7CJZMcVyrqVRyMA9EBvbtH1jpSBE2Hi?=
 =?us-ascii?Q?B/Yjc9qXEPHa6ThY/BjyZBaB0tB43KeJ3JYqCK7IpsoahDV98QH/TCMqr/tY?=
 =?us-ascii?Q?HdEX3QRB5uLwMmiXTJ7lpFEqwHrfHtTDy1obHgBfW+fQVo9tsiqR4jx0Q1Tc?=
 =?us-ascii?Q?yxVJ1Zy3OyIePG/vZBwtdQk0quXz9wHhjCTHX5jPBUo6Va5z58/9uiIMpHoG?=
 =?us-ascii?Q?ADMA6mTaVLdssFcXRCv3VTEeair8ltd271VOBx0gCCXL4FiIh6WEqLVsI0YL?=
 =?us-ascii?Q?qjbW7b2aWo3fspUhDzMh8Z/qJFq3UVrh79NZEn4h5bVRVSeU4RF8nRPVqoVe?=
 =?us-ascii?Q?wykaw/iG7unO+IqCr9zQRMa4LwLVTgQG0l3VRZGUu//kGMXNRVX+gYCfkICI?=
 =?us-ascii?Q?45oyBbnMmptvYHFHq7sSnaixO96nNqo8AyV8onHQbqGfhJMWWTBgOjAwChyR?=
 =?us-ascii?Q?8jeFi72UL5t2HcSlnIh+itaP72V/UPbpNcaI35cxRToDo60uRK2CDEZO3SpJ?=
 =?us-ascii?Q?RSoNobO1iV/G7sYi+/qjxbCbUQRH70rEJ/YKF5p5RCLokmyxu9mg2/zJf4Kc?=
 =?us-ascii?Q?zi75NxfIqqS1RgvUQCeZIGYmFqyF9hPfXv4ZQdg7kQ6p50ANdcKVTJo+JMhN?=
 =?us-ascii?Q?52gwcsIxwjVThW+PQ0HFIAoYdZQDJxfHq8A3vG9OxGD3rKqxhxQjafdNk+6J?=
 =?us-ascii?Q?LJQYzsT6hwUVKzvHpueAHrUOWlzl04gnpteNSajUB41uif55D8O0MFC35zeI?=
 =?us-ascii?Q?xcfF3BhbDrSXlIglE1HFNYpiBhVxH6DfJT92DjkTq5QGcRRisPhz9KrcABtD?=
 =?us-ascii?Q?6N8JtSdGzfAxFJEf4pd8ehdrZ9KJy7LBPA6l6YeDLVCDb0nip0hEEf95usq7?=
 =?us-ascii?Q?J5s4+ZyJGLproM5Sys/jFMkO0oX/ODIEGQ4ofQC/uoEqyvYDCaPg6Ce29RWn?=
 =?us-ascii?Q?fH2w9jzQDsLlRKtvsTTCI7g1Jco0H4VI9XJqFKVvxGtic7OQPR1IE4PyQzLw?=
 =?us-ascii?Q?YeEWDGtd5bW+BSEAwctH7Xa6/j9qEURrExaqX70CVgN8K8Ak41fu8M2cRCcD?=
 =?us-ascii?Q?3MfxW3Lt1h0nFL1VMwaYqWW7mbsR5kxxNKUyHiV54xi+s+rhaVgjkUCoEjGz?=
 =?us-ascii?Q?KzuRT8/MIxjTJjzoncQ2eVZrrOu55vUk8BtLzxWEBIUDoHyY6HJpbyqhfx9n?=
 =?us-ascii?Q?czrat24S7Qz+wm2/wEPF7fFLKhk0Z7FtAvCuc7NF5dEC9/glgy9S4vanUH5b?=
 =?us-ascii?Q?3bIvqGtFHhB6JOgM5Z2QxblP7a7SauAMMgEyFh0gNpG8VSd+p+WJEk++1UcP?=
 =?us-ascii?Q?jrM1/83I6hFtucfzuX1e7dd9WvLj65DXsn4a+JfHTEtwDXoA0wAdCshAbKc4?=
 =?us-ascii?Q?keeSeg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa93d8d1-3527-4641-9283-08db585dc3d7
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2023 11:39:54.4842
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O7VakYQDjbnn4irfpEyGRMxVqaeCpzwYMQGTgjkKqQeNQjzmbO8wIHSqVN5RyLkGKV2YZfiF2sf9C+7/BSmiOKIphTQl89vJJ2bnh6oRtPI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5975
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 19, 2023 at 07:25:08PM +0800, Min-Hua Chen wrote:
> Use cpu_to_le32 to convert the constants to __le32 type
> before comparing them with p->des0 and p->des1 (they are __le32 type)
> and to fix following sparse warnings:
> 
> drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c:110:23: sparse: warning: restricted __le32 degrades to integer
> drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c:110:50: sparse: warning: restricted __le32 degrades to integer
> 
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

> ---
>  drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c
> index 13c347ee8be9..eefbeea04964 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c
> @@ -107,7 +107,8 @@ static int dwxgmac2_rx_check_timestamp(void *desc)
>  	ts_valid = !(rdes3 & XGMAC_RDES3_TSD) && (rdes3 & XGMAC_RDES3_TSA);
>  
>  	if (likely(desc_valid && ts_valid)) {
> -		if ((p->des0 == 0xffffffff) && (p->des1 == 0xffffffff))
> +		if ((p->des0 == cpu_to_le32(0xffffffff)) &&
> +		    (p->des1 == cpu_to_le32(0xffffffff)))

nit: Sorry for not noticing this in v1.
     There are unnecessary parentheses (both before and after this change).