Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <da68d3eb-300c-a1e8-6085-1bce1641b664@quicinc.com>
Date:   Fri, 19 May 2023 17:28:21 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH 2/4] dt-bindings: clock: qcom: Add SM8550 video clock
 controller
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Conor Dooley <conor+dt@kernel.org>
CC:     Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Taniya Das <quic_tdas@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230509161218.11979-1-quic_jkona@quicinc.com>
 <20230509161218.11979-3-quic_jkona@quicinc.com>
 <d48ded3e-7a14-e859-f330-dfffe103eb56@linaro.org>
From:   Jagadeesh Kona <quic_jkona@quicinc.com>
In-Reply-To: <d48ded3e-7a14-e859-f330-dfffe103eb56@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

Thanks Krzysztof for your review!

On 5/10/2023 12:43 PM, Krzysztof Kozlowski wrote:
> On 09/05/2023 18:12, Jagadeesh Kona wrote:
>> Add device tree bindings for the video clock controller on Qualcomm
>> SM8550 platform.
>>
>> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>> ---
>>   .../bindings/clock/qcom,sm8550-videocc.yaml   | 77 +++++++++++++++++++
>>   .../dt-bindings/clock/qcom,sm8550-videocc.h   | 38 +++++++++
>>   2 files changed, 115 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm8550-videocc.yaml
>>   create mode 100644 include/dt-bindings/clock/qcom,sm8550-videocc.h
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8550-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8550-videocc.yaml
>> new file mode 100644
>> index 000000000000..107af5e9af89
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8550-videocc.yaml
>> @@ -0,0 +1,77 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/qcom,sm8550-videocc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Video Clock & Reset Controller on SM8550
>> +
>> +maintainers:
>> +  - Jagadeesh Kona <quic_jkona@quicinc.com>
>> +  - Taniya Das <quic_tdas@quicinc.com>
>> +
>> +description: |
>> +  Qualcomm video clock control module provides the clocks, resets and power
>> +  domains on SM8550.
>> +
>> +  See also:: include/dt-bindings/clock/qcom,videocc-sm8550.h
>> +
>> +properties:
>> +  compatible:
>> +    const: qcom,sm8550-videocc
> 
> Nope, looks 100% the same as sm8450, put it there.
> 
> https://lore.kernel.org/all/20230509172148.7627-2-quic_tdas@quicinc.com/
> 
Yes, will take care of this in next series.

> Best regards,
> Krzysztof
> 

Thanks & Regards,
Jagadeesh