Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 May 2023 15:06:40 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        David Ahern <dsahern@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Martin Wetterwald <martin@wetterwald.eu>,
        Arnd Bergmann <arnd@arndb.de>,
        XueBing Chen <chenxuebing@jari.cn>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Saravana Kannan <saravanak@google.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [net-next] net: ipconfig: move ic_nameservers_fallback
 into #ifdef block
Message-ID: <ZGd0YMg1y5wx4bRX@corigine.com>
References: <20230519093250.4011881-1-arnd@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230519093250.4011881-1-arnd@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xHeuXPF+noTJVUh6liuv70e+s+AeGDhEoKiLcMs+Joq2iFrLl+Q7Ef7Q/aPf?=
 =?us-ascii?Q?2HudV5Yl/2sl6nrkW9cRZ/Bwj3a0hVVFN5LkLio+JKKz5QV/jpK+4W5PF9w1?=
 =?us-ascii?Q?I8o8SxYdSpkXlaS4kSMFpwBeDLEsxj6a4Mwn+eqmJHeoufF1ueVMde1QsTIH?=
 =?us-ascii?Q?dCMaawbr/JLKvBPVdZ07mRv4SARUKOGUHBkDaG2aHYpgUQ28sSUUslmVEbI+?=
 =?us-ascii?Q?ZdeD3mj6VQZ+vjd9Di7cdFtySQPAtMoxhQ9U9D+DEwMOA92l2yyvoCEN2Uiu?=
 =?us-ascii?Q?I/jamoOPfI1pITlo3/fs8cRChuXmFIQ/VwLR1wwLLy+rJdSAhrd8nw5G9Rab?=
 =?us-ascii?Q?VsEUQVx9kFD5FMdn8pQUiS21LhXXBngVMhYr4vYzRELpGExcFHH3kDfB4u5w?=
 =?us-ascii?Q?QHJ3CMTFe7dEoC0hP20HTncPXcUyZiFM6R1W91WEVhUH3y0qYbZNBF4GE5Oa?=
 =?us-ascii?Q?quBEsFue1+ThI8+Bc9fhdHc74gAPm59st+xwMHs5Hv4pF5ZQth9r+O75ZG6R?=
 =?us-ascii?Q?yXnLoN3P/gGwU8QtNd6t2f6alUgmoBoP5XNNlhVK43H+tUvEe+k69I9WOnhn?=
 =?us-ascii?Q?u6LReB0ym57v55qilyDhR3l4xKitapE7bBmK4TmQVGyjIJSAQ0djJgrxGIh5?=
 =?us-ascii?Q?6728KeV7LkspkJHAGjzSfX/KSqS/iKPGob/rDb14YqU19CJWpnFMPzT6nYSP?=
 =?us-ascii?Q?cVAa1QCsQ5kvZrnYb6DM/COyQiQYI0lG5mZndglGHzso9RU4tzOppEmu7Yg/?=
 =?us-ascii?Q?DbzQlKAY9EIr4SdzkJLaSyovkEjASbzxZaQTs6hYrNpYoux8268bvzyaXjn1?=
 =?us-ascii?Q?9Bnyurk9iLCYP/5SHxPYkd4D0Zm/fcpIcbV9Os/TLRZzmbZVwXnji1Dt71BL?=
 =?us-ascii?Q?jfzp65cXTihpGRci1vCtC6p1riM+6cwxE9xI1OYO3Bp4gFUihb50Ts16hxJW?=
 =?us-ascii?Q?LQc0a9ZgZAdWfnOHIQArSxERx/4XRpJ+3591y2bj873lHrKeAueiiWVaFs81?=
 =?us-ascii?Q?SnRcFdoMxsxJQy8kTBB37YJNK1EOEDGM7JEE89ekhQktc1FyfLeAaNXulois?=
 =?us-ascii?Q?izUHgMt6zzs7u+Il1K1y6+9kSaXTNA2i5++JvnR+6TZ5zcEDhTu9EiXmtT6T?=
 =?us-ascii?Q?vf/737hnFBIhmGfiKMxx1QimgVIH9JXeOr1Gkas7RjJWAlulEKIs1y2fQUtl?=
 =?us-ascii?Q?lud4aO50s1LVlMsIdyL1uyvNay1DyIhXKOEjCi6GoOntExRTOTTaFNwUQ8v6?=
 =?us-ascii?Q?DEZ/saF0zlDxwBIA0l+f5zik9sQsY6jGb4ks5b/i5lTQSF/PMxD4cdlkC5qW?=
 =?us-ascii?Q?sXVo2qp83l3guYEeW1/0JFpCtxRmjE3b/G/zx0i7REGyoCerjD0MgV+KzwN3?=
 =?us-ascii?Q?eVwcj2aEcHlWHJZlFoCLBEvBqiV5VCzf0R80Y9aKySBBY1v+9mVISTBtAknB?=
 =?us-ascii?Q?Bm6r7MidUVp8+duz/JMfTDEEdanWWyYec2MoO8yvCOzXJ+apgOUScFEP1DGg?=
 =?us-ascii?Q?Hoe/wJwFzQcndR9SC79dglRs+OLzcw8ikG2lJ3U2rUo4XYOyGfFJdCz+NRBD?=
 =?us-ascii?Q?A5X4LZseED+wnW7+HRrA+gYwBLoKXRcAxQSkYk93Fb96MWiUyHvl6z9ec1NA?=
 =?us-ascii?Q?Sv5f77XSrsoeh13fq0g3cyiLmkF1Qn5czvQ6salKPU6LJz/Bl7vyBdvMG/8O?=
 =?us-ascii?Q?zoeSHQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da9c0bfe-6f60-4a64-225d-08db5869f48f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2023 13:07:10.2807
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1uIe5urcHxFLV+G9meQcK/C9WYm5EqU/xB734/iHLHb4mTqy7O5CGSVdvznLyumcBdneMOSTobEb57zPwjrteNBDxmTYLd9rbyrFaJ8vdbE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB5675
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 19, 2023 at 11:32:38AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The new variable is only used when IPCONFIG_BOOTP is defined and otherwise
> causes a warning:
> 
> net/ipv4/ipconfig.c:177:12: error: 'ic_nameservers_fallback' defined but not used [-Werror=unused-variable]
> 
> Move it next to the user.
> 
> Fixes: 81ac2722fa19 ("net: ipconfig: Allow DNS to be overwritten by DHCPACK")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks Arnd,

I was able to observe this too.

Reviewed-by: Simon Horman <simon.horman@corigine.com>