Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 May 2023 15:17:14 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Min-Hua Chen <minhuadotchen@gmail.com>
Cc:     alexandre.torgue@foss.st.com, davem@davemloft.net,
        edumazet@google.com, joabreu@synopsys.com, kuba@kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
        pabeni@redhat.com, peppe.cavallaro@st.com
Subject: Re: [PATCH v2] net: stmmac: compare p->des0 and p->des1 with __le32
Message-ID: <ZGd22jBn1nkzzQsN@corigine.com>
References: <ZGdgA9jMLJOi1W1+@corigine.com>
 <20230519114652.70372-1-minhuadotchen@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230519114652.70372-1-minhuadotchen@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?K5+vn7WaPyY50IyyjW5XliA9LxI9oG9/JaAdrRMvxDmTYcrmm8g1Kb2HZD1E?=
 =?us-ascii?Q?l3zqNyJwTyEYroE9h7siJOlsHXFRRinL0BKFz/lNsTmr9FLmIBvWtixhuOZB?=
 =?us-ascii?Q?jRYHke3afCy5z5NDKoxJ7UoH9lAXkgHpRDgAe5Mxz2yq4hMphUiWtXfuxvbd?=
 =?us-ascii?Q?kwgLf/YbEZbYoA1j79nQy9qbhdY7/xErxPG/YqRptX4BeAuwIAE024qqwGcU?=
 =?us-ascii?Q?AIPuLk+VzEBc9SwAXJIWkUEKuRir4dE8Gvy3t97tHK/j8VYCedl7+GYPYsUK?=
 =?us-ascii?Q?xTa6JJdrhveOvBCIa8tMKzGG9VC3jf1bTgBowAVkVBBWZFwLopRvGxnzK7gz?=
 =?us-ascii?Q?Nf+i3Ug12774o6f7n1y6z9pOM9Ny3clZirXcYDOm9tOSpX8aR/bo4lspCh0z?=
 =?us-ascii?Q?PXd/LII3waaSDrFPZZVRCBPBRguUk22DYU48uIgL6dTLLBHs/2t/Hcnxt2XX?=
 =?us-ascii?Q?Opx9sfe7HkAigLr91B0YXLEEgJB8TqaC2urRn0yGo5sygyGmaFTsaWtjygf7?=
 =?us-ascii?Q?ColkAZtAVcwS9ry3crjQCcPbCbK63sPH/mKrgWuEI6v1JkNr9bvO0OJSK+hs?=
 =?us-ascii?Q?ZdB4tDrUAOZXOHBr3aK0I1FFjRLIwRvQZVN1FToJ1LuTsyTHs6aGMMws9Ins?=
 =?us-ascii?Q?pe59ISJlCUOzPrF8Fbly9Uvd+j3rFTJqiyaOzXswn7U3M7uVcvQGvQM1zFuS?=
 =?us-ascii?Q?KYZ/Ck6M+CMzXcR59HtA/9itRrWn1xYIw6QigsWfXamJsfMoKWmYPMvTtK0i?=
 =?us-ascii?Q?zuIjk29+/hseSm+HgOUK7c4B0x5tMRvOISLV7jms4Z1xqZeM1jVGeTdoIIAf?=
 =?us-ascii?Q?O5WlgP774vDKHHDC9BKwxA8NFZB+h9J8EJlabIfFOEpSm9aovPv91VSuzhyz?=
 =?us-ascii?Q?E3iX+bwrMCyCUKv+oOg8zA+QiV0JdjbbEsyYuucNSpOyS89rGdpxdotmGq3Z?=
 =?us-ascii?Q?H0GJXbdRCQUeGElPMOHM3ZAcEyqLSO6QUDerahreEqSjf3XmRUYWZKyXrBNR?=
 =?us-ascii?Q?r13zU0kTm3tSF8rphHx3OCplVGiJKhqxRIYEAUV95s9s9QPLEXI+/Q4dpAPT?=
 =?us-ascii?Q?ajfIbLT0b93j1qGllB9g7XRdcxynNbFUZw2Q2R/VvhjTcoaHMiMEzC+DiI3u?=
 =?us-ascii?Q?HXea1tc38BC6ds5CZLop8VOsILtLh2nBA78bGWsquURscTXAdWZ0b6grBf05?=
 =?us-ascii?Q?dvOtBxcCh+rhuh5ki3WpM9dsi7Z8aeUsCB8D7dGqLj8iN3+w6U5R0rmbWdvh?=
 =?us-ascii?Q?2Ca0y6Shl1RM/4jZLUwzb3Eenh3J0iDCgcnpfEb4B7uWiAerse5WlrTeYpYz?=
 =?us-ascii?Q?p3WzLnyt/COtgv/viTAoIj5VQLIXOGP5dY0XdCSiKe0k1FDY1GZKe4X7Veas?=
 =?us-ascii?Q?V4U5akalvEWkTfhbyXdEtbtuSrsRWebynE3NxcM24rxatTRVKfXVNtTeN1Zz?=
 =?us-ascii?Q?pCm3m7JQdPTjok1k2CtGahJ89kshzx9W/L3GhjVo2bWlsmOjiygkgXWdWT2K?=
 =?us-ascii?Q?rxlSWanoINrhR4J72MvYcTyxboewmJuICSE9tO/b/PdgvAq4aatemPy071GU?=
 =?us-ascii?Q?InQoQ62DgewWCPibGbM2aatoKpoqJhf/lZ0JlO74oaegswLyoUh4Fo00z0pA?=
 =?us-ascii?Q?3G4metdTaPLsSHBj6AFJH+uCpCbq4iuY3PgUaTYSD0oNagsNldfFNL8zyiRY?=
 =?us-ascii?Q?sIKYCQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54e17fa3-6594-49ef-87c4-08db586b60bc
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2023 13:17:21.1811
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ddrsx+gkP00tsAtclOgyf2FGcEbTD7KSTWeSOgohkTzjKI+waSS5JPs46RNxGJverF2S6Qc++TnIZyyXiDWnMhOaa2keCSRFI6IoMwlcQM8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB5537
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 19, 2023 at 07:46:52PM +0800, Min-Hua Chen wrote:
> [You don't often get email from minhuadotchen@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> >On Fri, May 19, 2023 at 07:25:08PM +0800, Min-Hua Chen wrote:
> >> Use cpu_to_le32 to convert the constants to __le32 type
> >> before comparing them with p->des0 and p->des1 (they are __le32 type)
> >> and to fix following sparse warnings:
> >>
> >> drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c:110:23: sparse: warning: restricted __le32 degrades to integer
> >> drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c:110:50: sparse: warning: restricted __le32 degrades to integer
> >>
> >> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
> >
> >Reviewed-by: Simon Horman <simon.horman@corigine.com>
> >
> >> ---
> >>  drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c
> >> index 13c347ee8be9..eefbeea04964 100644
> >> --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c
> >> +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c
> >> @@ -107,7 +107,8 @@ static int dwxgmac2_rx_check_timestamp(void *desc)
> >>      ts_valid = !(rdes3 & XGMAC_RDES3_TSD) && (rdes3 & XGMAC_RDES3_TSA);
> >>
> >>      if (likely(desc_valid && ts_valid)) {
> >> -            if ((p->des0 == 0xffffffff) && (p->des1 == 0xffffffff))
> >> +            if ((p->des0 == cpu_to_le32(0xffffffff)) &&
> >> +                (p->des1 == cpu_to_le32(0xffffffff)))
> >
> >nit: Sorry for not noticing this in v1.
> >     There are unnecessary parentheses (both before and after this change).
> >
> Thanks, I noticed this before submitting v2 (by checkpath.pl) but I keep
> the original parentheses.
> 
> I will do v3 with your Reviewed-by tag. :-)

Thanks.