Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 May 2023 15:20:52 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Ratheesh Kannoth <rkannoth@marvell.com>
Cc:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "linyunsheng@huawei.com" <linyunsheng@huawei.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Srujana Challa <schalla@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>
Subject: Re: Re: [PATCH net-next v3] octeontx2-pf: Add support for page pool
Message-ID: <ZGd3tNs4F2OSehFa@corigine.com>
References: <20230519071352.3967986-1-rkannoth@marvell.com>
 <ZGdJRMfuXHnvVQy9@corigine.com>
 <MWHPR1801MB1918D77C6C6A87F09BC5EDA1D37C9@MWHPR1801MB1918.namprd18.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <MWHPR1801MB1918D77C6C6A87F09BC5EDA1D37C9@MWHPR1801MB1918.namprd18.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NZtYkBE72nVl2WQIjYop8Sg/Bpc9ifgfcu/Jo3yNXgkAjMvLtSLC17NLpeJn?=
 =?us-ascii?Q?8LKkn5SN5j2EwIyUJo8TbTdm8UJkfW701rnym6EsoHXW7MunEBTAS3d8ouWV?=
 =?us-ascii?Q?aZGgOM/9T3gPOQo4RSpraKm6nK1KNFwMB9GCMdYCIlh7+Qal7g8QqAvv31/M?=
 =?us-ascii?Q?YMML/ljMsX7rmDEuWo/mJGjxhtg+tsKfiMmaYSYYDbdtBhIHhVJpVuKnofok?=
 =?us-ascii?Q?vzVwf9VV4cfgmzlybjMRTZlMOlR4zB9LIZvb2ySEO2eUVFCHUgU/EqcK+ZX/?=
 =?us-ascii?Q?j8ajAI0WKh+C4gt6XdsLjb9DkuvNgVj98g8H4gri17LZHyK+Uqv/LbQxbBsy?=
 =?us-ascii?Q?63z33NeA1JUR/hLDepeDQO3b2iz8AiRUedJpIHS9pDJGS0TW6P8Hfy6fkp56?=
 =?us-ascii?Q?O63UQDGqnN63LXaXRUfQpa68pbnfpm5bH+uEO9+be8N+3X5zDzuc1f1Itk26?=
 =?us-ascii?Q?icgAeO/iewvxf4MF9IWDhPyC1rK80UH/Y+TKZ9PRxeMBhxOhKY+t01qWPmGn?=
 =?us-ascii?Q?Ob/bp5juImm4cq9TfY8KczBSpTVAF1uQ/oZ/UmUYBNiBVrwznzwlOY1Bs32a?=
 =?us-ascii?Q?xkFxCk34My214oCDKVU7+EO/binjVgCNSwuEldme3fXwHVfJfmQKteL0xFTy?=
 =?us-ascii?Q?bCspDnU73YzOeQDHndp1Nruc19BTUK9d4/mOifx13PXrNDGdGVZUC7saEin6?=
 =?us-ascii?Q?/ZnuBYW+yMVEmz3vt8fXnpoPa2sEb/rdBFm4u3Wse2kxVMDWuQ2FeAm0EAoH?=
 =?us-ascii?Q?7VrdyiBbFL5WZGXQQ7sCJTv/c727VSQflapmHcpg1hjSlozLGbI3V+YeRBSf?=
 =?us-ascii?Q?Eu1/zuOKJLHWqytTd2ql0GIEaEAhkYK4SiCkcnbydwxIBXN54mNRCbKG2PRg?=
 =?us-ascii?Q?6OWpdcDQkj9hBEVfChmB+cyStjS+IQ5YedROI1+nbqIqCwzrIONuxa+pgf3c?=
 =?us-ascii?Q?G05jpm6I5oUiNF8G98lu57CoCNtqPOzAwCUy4nejSo0Rb7PTVpTXg6zPIi7v?=
 =?us-ascii?Q?fjVHxwo257YB3CP1qft0OZDeE4vTmaG12+IJO+vlCVi7M0EfGCiK0I8snrPG?=
 =?us-ascii?Q?ZdxaJAXsHU/mIfx44x0R/Zli/UOUYGGz1POoGuF9NxrDvZKJvVw6r7i5S+ou?=
 =?us-ascii?Q?UmCA5NOsi7hPWqG2x2KOurnPqaQdgtd6C/DQNOBnQCqs4MJad86L2zDgbrDj?=
 =?us-ascii?Q?R8FVBpHV6k5wsTW5gWJ12/dfAN4fv2635FQEJjz4CvgJ+F6J65kbVDQicIV5?=
 =?us-ascii?Q?HiHmVrvIKYAmGEfXAwlAPm7BW+7RbP4LbKFV6COMU9QaQSBEHu7zQHg0l87/?=
 =?us-ascii?Q?66S8P1I/Bftz9q+J+KI78BDIhla+3HIJvCjf48C9mgs+CfdM0ZFcZol9A5g7?=
 =?us-ascii?Q?OCbPGodGwaZDk3HwnwRYRZhZ81x/P7jaTzNJ7BwuXfrHzjG//wys4f0nii9i?=
 =?us-ascii?Q?RHMSsQNUKjTiQvP5aeaL477fvfDrBDcqcgAB0kv7t+M3PmipQAxe7mJudKg7?=
 =?us-ascii?Q?HE5GhLKcd8ga+Zc0GxH0sJUSwP4zWnskBO9eezlyGtNAKzao2K4p9cGs5gEm?=
 =?us-ascii?Q?Ei7SZIwss+wMtq3Lb/7dKlNxCc5mpiQwHu8F8/5qWqNpk64vpaeDD/EpWZCp?=
 =?us-ascii?Q?8o1EdXBnJhwx4lJXZ+aQrLyXW9Vx/FWSNKKVfn4soR7p7sf4HiDI7/fDd4om?=
 =?us-ascii?Q?eUUu3Q=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b4d907ec-f343-4fa3-5c8a-08db586be287
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2023 13:20:58.9516
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e5g8m3+P9sU1Npvr8sMVB35903xBGcKkuDc9z1ZWI8p5awbhCp3ISFDXSwPzlvydaXgeFo3ze5Ng64OySrtCFh5mMh8SleWFJFC7KmwWKmQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR13MB5978
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 19, 2023 at 10:21:44AM +0000, Ratheesh Kannoth wrote:
> 
> > -----Original Message-----
> > From: Simon Horman <simon.horman@corigine.com>
> > Sent: Friday, May 19, 2023 3:33 PM
> > To: Ratheesh Kannoth <rkannoth@marvell.com>
> > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri
> > Goutham <sgoutham@marvell.com>; davem@davemloft.net;
> > edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> > linyunsheng@huawei.com; Subbaraya Sundeep Bhatta
> > <sbhatta@marvell.com>; Geethasowjanya Akula <gakula@marvell.com>;
> > Srujana Challa <schalla@marvell.com>; Hariprasad Kelam
> > <hkelam@marvell.com>
> > Subject: [EXT] Re: [PATCH net-next v3] octeontx2-pf: Add support for page
> > pool
> > 
> > External Email
> > 
> > ----------------------------------------------------------------------
> > On Fri, May 19, 2023 at 12:43:52PM +0530, Ratheesh Kannoth wrote:
> > > Page pool for each rx queue enhance rx side performance by reclaiming
> > > buffers back to each queue specific pool. DMA mapping is done only for
> > > first allocation of buffers.
> > > As subsequent buffers allocation avoid DMA mapping, it results in
> > > performance improvement.
> > >
> > > Image        |  Performance
> > > ------------ | ------------
> > > Vannila      |   3Mpps
> > >              |
> > > with this    |   42Mpps
> > > change	     |
> > > ---------------------------
> > >
> > > Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
> > 
> > ...
> > 
> > > @@ -1205,10 +1226,28 @@ void otx2_sq_free_sqbs(struct otx2_nic *pfvf)
> > >  	}
> > >  }
> > >
> > > +void otx2_free_bufs(struct otx2_nic *pfvf, struct otx2_pool *pool,
> > > +		    u64 iova, int size)
> > > +{
> > > +	u64 pa = otx2_iova_to_phys(pfvf->iommu_domain, iova);
> > > +	struct page *page = virt_to_head_page(phys_to_virt(pa));
> > 
> > nit: please arrange local variables in networking code in reverse xmas tree
> >      order - longest line to shortest.
> Variable "pa" is used in second line.  Are you suggesting to defer assignment later; and only declare variables here in reverse xmas tree style ? 

Yes, that is my suggestion.