Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 May 2023 10:37:00 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     "Liang, Kan" <kan.liang@linux.intel.com>
Cc:     James Clark <james.clark@arm.com>, Ian Rogers <irogers@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Thomas Richter <tmricht@linux.ibm.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] perf test attr: Update no event/metric
 expectations
Message-ID: <ZGd7fDmBDEmoiSE7@kernel.org>
References: <20230517225707.2682235-1-irogers@google.com>
 <64f329a9-09a3-aa84-a354-23a919062d09@arm.com>
 <ZGYYJ/biKyeFNJjL@kernel.org>
 <f753beda-2d5e-c391-520a-450b186fd4d4@linux.intel.com>
 <9178149c-45e8-3de4-58db-b8b8d27b3a08@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9178149c-45e8-3de4-58db-b8b8d27b3a08@linux.intel.com>
Precedence: bulk

Em Thu, May 18, 2023 at 01:45:06PM -0400, Liang, Kan escreveu:
> Hi Arnaldo,
> 
> On 2023-05-18 8:55 a.m., Liang, Kan wrote:
> > On 2023-05-18 8:20 a.m., Arnaldo Carvalho de Melo wrote:
> >> Em Thu, May 18, 2023 at 08:50:14AM +0100, James Clark escreveu:
> >>>
> >>> On 17/05/2023 23:57, Ian Rogers wrote:
> >>>> Previously hard coded events/metrics were used, update for the use of
> >>>> the TopdownL1 json metric group.
> >>>>
> >>>> Fixes: 94b1a603fca7 ("perf stat: Add TopdownL1 metric as a default if present")
> >>>> Signed-off-by: Ian Rogers <irogers@google.com>
> >>>> ---
> >>>>  tools/perf/tests/attr/base-stat            |   2 +-
> >>>>  tools/perf/tests/attr/test-stat-default    |  80 ++++++++-----
> >>>>  tools/perf/tests/attr/test-stat-detailed-1 |  95 +++++++++------
> >>>>  tools/perf/tests/attr/test-stat-detailed-2 | 119 +++++++++++--------
> >>>>  tools/perf/tests/attr/test-stat-detailed-3 | 127 ++++++++++++---------
> >>>>  5 files changed, 249 insertions(+), 174 deletions(-)
> >>>>
> >>> Reviewed-by: James Clark <james.clark@arm.com>
> >> Thanks, applied both patches to perf-tools.
> >>
> > Could you please hold patch 1 for a while?
> 
> Sorry for the noise.
> 
> Ian has addressed my concerns. The patch looks good to me now.
> It also fixes a "Failed" on my Cascade Lake machine.
> 
> Tested-by: Kan Liang <kan.liang@linux.intel.com>

Thanks, added it,

- Arnaldo
 
> But for long term, we probably need a better solution to avoid keeping
> adding such non-architectural events in the test case.