Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 May 2023 14:54:32 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Alexandre Ghiti <alexghiti@rivosinc.com>
CC:     Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -fixes] riscv: Fix unused variable warning when
 BUILTIN_DTB is set
Message-ID: <20230519-backhand-overbid-1df4d90f7da8@wendy>
References: <20230519131311.391960-1-alexghiti@rivosinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="aPJ+XWcPL1J5bSvX"
Content-Disposition: inline
In-Reply-To: <20230519131311.391960-1-alexghiti@rivosinc.com>
Precedence: bulk

--aPJ+XWcPL1J5bSvX
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 19, 2023 at 03:13:11PM +0200, Alexandre Ghiti wrote:
> commit ef69d2559fe9 ("riscv: Move early dtb mapping into the fixmap
> region") wrongly moved the #ifndef CONFIG_BUILTIN_DTB surrounding the pa
> variable definition in create_fdt_early_page_table(), so move it back to
> its right place to quiet the following warning:
>=20
> ../arch/riscv/mm/init.c: In function =E2=80=98create_fdt_early_page_table=
=E2=80=99:
> ../arch/riscv/mm/init.c:925:12: warning: unused variable =E2=80=98pa=E2=
=80=99 [-Wunused-variable]
>   925 |  uintptr_t pa =3D dtb_pa & ~(PMD_SIZE - 1);
>=20
> Fixes: ef69d2559fe9 ("riscv: Move early dtb mapping into the fixmap regio=
n")
> Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks Alex.

--aPJ+XWcPL1J5bSvX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZGd/mAAKCRB4tDGHoIJi
0h2IAPwLAxCJ/+0IRNhP4m6vQWaDwze4VcB5EC2wibqTlCYvYwEAyzyVVdDhAhwW
JYlxPuibr/SjwKVsvC8sLseZIFPboAA=
=WuyF
-----END PGP SIGNATURE-----

--aPJ+XWcPL1J5bSvX--