Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 May 2023 10:21:08 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Niklas Schnelle <schnelle@linux.ibm.com>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
        linux-pci@vger.kernel.org, Arnd Bergmann <arnd@kernel.org>,
        linux-iio@vger.kernel.org
Subject: Re: [PATCH v4 05/41] counter: add HAS_IOPORT dependencies
Message-ID: <ZGeF1K0Yxu9lTgN2@fedora>
References: <20230516110038.2413224-1-schnelle@linux.ibm.com>
 <20230516110038.2413224-6-schnelle@linux.ibm.com>
 <ZGbQYzXK8InMqkxu@fedora>
 <6f4d672ba7136f2b01ea9ee69687b16168eddb8d.camel@linux.ibm.com>
 <231dcebc57c2e43ba65d007b60d3d446d9ed71c8.camel@linux.ibm.com>
 <abc02dc2af7563ae26bf0d0ddd927d9b4a21dda3.camel@linux.ibm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="EBH9/xbXifix297d"
Content-Disposition: inline
In-Reply-To: <abc02dc2af7563ae26bf0d0ddd927d9b4a21dda3.camel@linux.ibm.com>
Precedence: bulk


--EBH9/xbXifix297d
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 19, 2023 at 03:39:57PM +0200, Niklas Schnelle wrote:
> On Fri, 2023-05-19 at 15:38 +0200, Niklas Schnelle wrote:
> > On Fri, 2023-05-19 at 15:17 +0200, Niklas Schnelle wrote:
> > > On Thu, 2023-05-18 at 21:26 -0400, William Breathitt Gray wrote:
> > > > On Tue, May 16, 2023 at 01:00:01PM +0200, Niklas Schnelle wrote:
> > > > > In a future patch HAS_IOPORT=3Dn will result in inb()/outb() and =
friends
> > > > > not being declared. We thus need to add HAS_IOPORT as dependency =
for
> > > > > those drivers using them.
> > > > >=20
> > > > > Co-developed-by: Arnd Bergmann <arnd@kernel.org>
> > > > > Signed-off-by: Arnd Bergmann <arnd@kernel.org>
> > > > > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> > > >=20
> > > > Hi Niklas,
> > > >=20
> > > > The change itself is fine, but please update the description to ref=
lect
> > > > that this is adding a depends on HAS_IOPORT_MAP rather than HAS_IOP=
ORT,
> > > > along with the reason why it's needed (i.e. devm_ioport_map() is us=
ed).
> > > >=20
> > > > Thanks,
> > > >=20
> > > > William Breathitt Gray
> > > >=20
> > > >=20
> > >=20
> > > Right, this clearly needs adjustment. I went with the following commit
> > > message for v5:
> > >=20
> > > "counter: add HAS_IOPORT_MAP dependency
> > >=20
> > > The 104_QUAD_8 counter driver uses devm_ioport_map() without depending
> > > on HAS_IOPORT_MAP. This causes compilation to fail on platforms such =
as
> > > s390 which do not support I/O port mapping. Add the missing
> > > HAS_IOPORT_MAP dependency to fix this."
> > >=20
> >=20
> > Just noticed this isn't entirely correct. As devm_ioport_map() has an
> > empty stub for HAS_IOPORT_MAP=3Dn this doesn't lead to a compile error =
it
> > just doesn't work. Will reword to "This causes the driver to not be
> > useable on platforms ..."
>=20
> s/useable/usable/

104_QUAD_8 has an explicit dependency on PC104 and X86, so I don't think
it would ever be used outside of x86 platforms. Does it still make sense
to have the HAS_IOPORT_MAP dependency in this case?

William Breathitt Gray

--EBH9/xbXifix297d
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZGeF1AAKCRC1SFbKvhIj
K453AP9zNn9wgYcEBDa5y15FH8KKUQSfyNCaUMKyjOcLaFoeEQEAiYcdE/TNd4HS
t4Z4xU0Ws5yWOLB4p4wMFw+18EyLmQM=
=BAPi
-----END PGP SIGNATURE-----

--EBH9/xbXifix297d--