Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <76a47786-f1e5-80d8-807d-1ab6fa02ebf3@gmx.de>
Date:   Fri, 19 May 2023 16:33:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] fbdev: i810: include i810_main.h in i810_dvt.c
Content-Language: en-US
To:     Jani Nikula <jani.nikula@linux.intel.com>,
        Arnd Bergmann <arnd@kernel.org>,
        Antonino Daplas <adaplas@gmail.com>
Cc:     linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
References: <20230516202814.561262-1-arnd@kernel.org>
 <87lehngxbr.fsf@intel.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <87lehngxbr.fsf@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:ZtCenKypFwE=;0mS62XZeXZOrgQSTNbQXrL7nRxm
 Ciafs2dOZQTAORGhafcMiyIcR1cTMe5VfWrP8fN4uxpWwtvydip7LLEy2ufOIzZibXDgXIFLD
 F/iJd7HlkMkLhuYIMDLRLQRpPSJ1Vo+QetQBANmiKHzChpjdOwWG8El3TqvbI+7dPhwbtbbYu
 vbWDscGc6v60REC823k0cwLFXnatWxbeIi55icTNoyMUhYCXtmH483xcrJZCofp8rtzTCx6ue
 kz4OHJSlrfkaLhGz44OEpUAxSjLAyEATKk7vavoh+AafuTFpBHdsAmQXWGCx3zXFpjM9jndYK
 g0SFbUEYKnbS02spYIrtY8LGeELPY28FFbzBYUxwZBhx/NPLg1PIUDZ2b1FvpZCxOJWifR6lK
 UBwkjRPe5q8QOjH6VJojh2eT4Pp4CsbmxUJT21TIQJwhhGxdrpVmiN6G2ELttdE5fvu7NsebL
 CdeYdEtK7IkNyrvKPMESH5P0kk84kbkwo4Ogx0cCTWUcpBpFmZQ1CWtdJOr7ythlYtGksIoCg
 Z9KoNN3cAdaULf+hwEdYOlgHnM9wIpyE0p92xNHgkecNfz6sSjDibewfsAHbjil+MzNCsc/ms
 GcT7r9FGwqcLjgPGR3ZB+LElXc+C/e8hhrTpDje1ZQhJg+hGsE4EeDFzlW9Pu1OES+qlZsJVy
 OQOZ0XsuVZvSHDl1eN2w+NtkdtGxLq4QvFl0BD/Fymr1G1DydUOQ7Q6xnIejDBS1dMt2malph
 nJ21Majmp9qFmQ1zVMF1rtGtmqQhyIgMbTUtzC8d6GHSs7JPKacIn81506HRa9b9s+EH1y1KM
 YhU0B5cfv5bCyAlqgPDctDHQn2U8WMnn+eN9QzpUIRMrDJE9AZH0SMWilqSShK/M8S5l1Ozsc
 D3U2O2NfsNmdsJFzuFbEKvICAbMHicRgXrk8geIVzG6NbPYOM0cLwscWtEVGoo6+/jnYJQbZO
 m7jQNWJuBtYTlDIQMz3oXLcUV0s=
Precedence: bulk

On 5/17/23 10:46, Jani Nikula wrote:
> On Tue, 16 May 2023, Arnd Bergmann <arnd@kernel.org> wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Building with W=3D1 shows that a header needs to be included to
>> make the prototypes visible:
>>
>> drivers/video/fbdev/i810/i810_dvt.c:194:6: error: no previous prototype=
 for 'round_off_xres' [-Werror=3Dmissing-prototypes]
>> drivers/video/fbdev/i810/i810_dvt.c:233:6: error: no previous prototype=
 for 'i810fb_encode_registers' [-Werror=3Dmissing-prototypes]
>> drivers/video/fbdev/i810/i810_dvt.c:245:6: error: no previous prototype=
 for 'i810fb_fill_var_timings' [-Werror=3Dmissing-prototypes]
>> drivers/video/fbdev/i810/i810_dvt.c:279:5: error: no previous prototype=
 for 'i810_get_watermark' [-Werror=3Dmissing-prototypes]
>>
>> Adding the header leads to another warning from a mismatched
>> prototype, so fix this as well:
>>
>> drivers/video/fbdev/i810/i810_dvt.c:280:5: error: conflicting types for=
 'i810_get_watermark'; have 'u32(struct fb_var_screeninfo *,
>
> Changes here look fine,
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

applied to fbdev tree.

Thanks!
Helge