Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 May 2023 08:20:44 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Davidlohr Bueso <dave@stgolabs.net>, LiuLele <liu.lele@qq.com>
CC:     <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <alison.schofield@intel.com>, <bhelgaas@google.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <helgaas@kernel.org>, <ira.weiny@intel.com>,
        <linux-acpi@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
        <rostedt@goodmis.org>, <vishal.l.verma@intel.com>
Subject: Re: CXL memory device not created correctly
Message-ID: <646793cc665bf_1231462943c@iweiny-mobl.notmuch>
References: <cec6a8f5-a284-4f46-1ada-4edd625a9a2e@intel.com>
 <tencent_D9D9D358330CA573E23D490C6EE13E0DC105@qq.com>
 <gbsxrcjtnf67jxpqmbn57nqoslpmjtuk2ycatmau3vfsmpvbrd@c2umpofn2hti>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <gbsxrcjtnf67jxpqmbn57nqoslpmjtuk2ycatmau3vfsmpvbrd@c2umpofn2hti>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mpa5/pWvpUdTBECpu/VyeccsXmPue9tdW9sclhY9WcyMEqL4uUGaoTu9vG6L?=
 =?us-ascii?Q?QS4pivYZKK5xToqPIBXsRSByRrcKjLpzVKXgDWeX2G1zVKeGP+KNpuM/MZ2d?=
 =?us-ascii?Q?xXY9imeRzj/gfv8qT1/CC0lqr/Nevpp4yYxfKLyQoCCVZKN2bzPo20MjDJXm?=
 =?us-ascii?Q?NWmHjU3FMheG1B2pSq8ytV+dcOxqbTa1lprTmRrK2FTjfltF0YpaV9iCIHZf?=
 =?us-ascii?Q?yzYmu9dW5GwTx3xniu6zrl3Q2+wRJEODbz8msZOQ/SpUdB5yddBMmAVW/tYX?=
 =?us-ascii?Q?PAmx4YGAQ7WqgjsiQZGdxkdNq0cdBcI3DWW1Ye2LO7mdsU7K7k23nPCyYPNg?=
 =?us-ascii?Q?bHLOiM87M3ZfA93anTeLBU8iVV72jASJa0HxRBPSWR4a9OINPUxnrrP4Nos3?=
 =?us-ascii?Q?ChKfU1d4hSsK5lONTxxkbfjrOVj4YLU9aLqPXA1ycHv3U96xAd5XXb63QEYF?=
 =?us-ascii?Q?iLsGcZ2oWNkvUK9AOf699aFMxvzBnsKP5NtmzXWNIDaLhbjUtuV1pMiQ3nEk?=
 =?us-ascii?Q?VH9YuGVaIbCANxZo4hyqmuSmgj53EzbDwuKtRKmN+RCt1Afun4J723Pec0Tw?=
 =?us-ascii?Q?cnOusEHE5dlPD2I6Pz6YcY7G3sntorN7qhKF96m94zDmxT/2RaPuPtRR0EhO?=
 =?us-ascii?Q?tWUIVzTdjU0eW0mQjVgTTcJOpFFMTo6JV454PtcCoH3gU2Qi37R2Fyh8kCoV?=
 =?us-ascii?Q?MNer+vEJ1o+VQv/vAVjtUduzMGoGEg8bvoSMhwTtb+4jPqNktpXYCLbcFfYM?=
 =?us-ascii?Q?Ko8x7d/0nb6+sF0PUj0Ha7yDgPFvnD6WcitJu8G0D6Nry/oZf0lj2aQYLsOD?=
 =?us-ascii?Q?o2Ko680Hp+Ojh/2+z17LbFoNB3GBfdOy1+NnOgljeGsLHmO5zCqmtAAJPwE+?=
 =?us-ascii?Q?lFOL8HLknjNyg/fTf/E8lTLtAqgUoCd9zQ6OVsgMoPq26vVMkCUmWwqjumqx?=
 =?us-ascii?Q?fht4YkJPB3WMakCuVexcIyaLeXHnBsDHaK6U8Ke/dhdxgGdsTcCdalYVOX2a?=
 =?us-ascii?Q?L00pn7t6+0AISe+bBqJZn7ExQQW8CZGWeVK8yDRqoiQ8Uz1EDRFHBVCyNk+W?=
 =?us-ascii?Q?xEaTeDZnSjMBVaP3q1Eg4ywNs+CO75Qonmij05MgZmUlOM2Bi0BEvg5MgoUk?=
 =?us-ascii?Q?lSwTGeyHk+8xaPRx4wkvUlGi7bJq4UcwHnOdnOzgeXmdivtN/VF+YNB4pRpr?=
 =?us-ascii?Q?45WP/kkwapnCXMBm9vYG4xhFeg0dYgvMuVGip2UgkcWs53glyZSvbtvq51qg?=
 =?us-ascii?Q?ZxBpIpLBEfAYgvd3XywzSxbWAOyNZ8vMQG2GE6Xvvz0rdJfzYwx+K40aiN2V?=
 =?us-ascii?Q?jmT5FmphIUgLlWnfUxk3KOrbRnSXR/AQi1pu83JvmQ+tEpef/v+CiOahuG2b?=
 =?us-ascii?Q?eqR3SLB1Iyi5B5ilvII+iRnL2J15mkZA87VPrRbNd2CFdNX43SeMSU53mmCA?=
 =?us-ascii?Q?/TFexYVLu/nhVv9br7VMNPGKMh8dPDGR3XotpVE00c7/6WuwpTeynRPk1fXk?=
 =?us-ascii?Q?sOrziVAxKbHHTuJQX5ReU8xQatXPg9Jd3as3TjwhgTGBVKykmTmMHY6JuAWC?=
 =?us-ascii?Q?FiLVgNKi2GgelaxWO5QqphGM12ECdobudEmfu8Vc?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ddf5c8e-077e-440e-08ac-08db587ca52d
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2023 15:20:57.7321
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4ILW+HP7kTFWxAw8sVQo8B0KbGBgmy/WE9gkAOIPs3Pgr+rgmMJi4ahzfI08JzauLL4qttdYCIE0s1GmRZZSLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5861
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Davidlohr Bueso wrote:
> On Fri, 19 May 2023, LiuLele wrote:
> 
> >In my testing CXL device /sys/bus/cxl/devices/mem0  not created, and the get error messages :
> >
> >```
> >cxl_pci 0000:0d:00.0: Failed to get interrupt for event Info log
> >```
> >
> >My test environment is a qemu CXL emulator with qemu v8.0.0, Linux kernel v6.3.0.
> >While with kernel 5.9.13,  /sys/bus/cxl/devices/mem0  can be created.
> 
> Yes, this can be annoying and would argue the probe should not error out.

I had to double check.  Events are mandatory on devices.  On checking
again interrupt support is mandatory as well.  So that is why I errored
out here.  With real HW this should not be an issue.

> Regardless, the actual qemu support is in Jonathan's tree:
> 
> https://gitlab.com/jic23/qemu/-/commit/a04e6476df363d1f6bc160577b30dda6564d3f67

That is the commit you need but it is probably best to use one of
Jonathans 'official' branches.  Looks like he just pushed a new one today.

https://gitlab.com/jic23/qemu/-/tree/cxl-2023-05-19

I've not run that one yet.  So if you have issues try his previous one it
is working well for me.

https://gitlab.com/jic23/qemu/-/tree/cxl-2023-04-19

Ira

> 
> Thanks,
> Davidlohr