Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230518035321.1672-1-angus.chen@jaguarmicro.com>
 <20230518130221.81e8e1f474cfbfd6c93712c5@linux-foundation.org>
 <CAKwvOdmtnpETT4P88NZKAtLNvj4kJ7MtotAwNJSdh7WVxa_xJA@mail.gmail.com> <TY2PR06MB3424AB7EAB6AEB779D6EAB1A857C9@TY2PR06MB3424.apcprd06.prod.outlook.com>
In-Reply-To: <TY2PR06MB3424AB7EAB6AEB779D6EAB1A857C9@TY2PR06MB3424.apcprd06.prod.outlook.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Fri, 19 May 2023 08:58:48 -0700
Message-ID: <CAKwvOdkppYFVnnjBetUK=KVw5dg6_NcgX73mnjOSFpA_XtEd5w@mail.gmail.com>
Subject: Re: [PATCH] init: Add bdev fs printk if mount_block_root failed
To:     Angus Chen <angus.chen@jaguarmicro.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        "masahiroy@kernel.org" <masahiroy@kernel.org>,
        "vbabka@suse.cz" <vbabka@suse.cz>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "paulmck@kernel.org" <paulmck@kernel.org>,
        "rppt@kernel.org" <rppt@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Al Viro <viro@zeniv.linux.org.uk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, May 18, 2023 at 11:34=E2=80=AFPM Angus Chen <angus.chen@jaguarmicro=
.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Nick Desaulniers <ndesaulniers@google.com>
> > Sent: Friday, May 19, 2023 4:36 AM
> > To: Andrew Morton <akpm@linux-foundation.org>; Angus Chen
> > <angus.chen@jaguarmicro.com>
> > Cc: masahiroy@kernel.org; vbabka@suse.cz; peterz@infradead.org;
> > paulmck@kernel.org; rppt@kernel.org; linux-kernel@vger.kernel.org; Al V=
iro
> > <viro@zeniv.linux.org.uk>
> > Subject: Re: [PATCH] init: Add bdev fs printk if mount_block_root faile=
d
> >
> > I wish the commit message showed an example of the panic after the
> > patch, to contrast the before vs. after.
> en ,Did a need to send a v2 or just let it go this time?

Nah, it's fine. LGTM

> The information is print:
> [    1.570841] VFS: Cannot open root device "vda" or unknown-block(253,0)=
: error -19
> [    1.571513] Please append a correct "root=3D" boot option; here are th=
e available partitions:
> [    1.572056] fd00          256000 vda
> [    1.572058]  driver: virtio_blk
> [    1.572525] List of all bdev filesystem:
> [    1.572780]  ext2
> [    1.572781]
> [    1.573027] Kernel panic - not syncing: VFS: Unable to mount root fs o=
n unknown-block(253,0)
>
> Or:
> [    1.510467] VFS: Cannot open root device "vda" or unknown-block(253,0)=
: error -19
> [    1.512033] Please append a correct "root=3D" boot option; here are th=
e available partitions:
> [    1.513724] fd00          256000 vda
> [    1.513731]  driver: virtio_blk
> [    1.514280] Can't find any bdev filesystem!
> [    1.514540] Kernel panic - not syncing: VFS: Unable to mount root fs o=
n unknown-block(253,0)

--=20
Thanks,
~Nick Desaulniers