Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e6662717-61a1-3e3d-5804-66629a1691e2@intel.com>
Date:   Fri, 19 May 2023 17:50:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH modules-next v10 00/13] kallsyms: reliable symbol->address
 lookup with /proc/kallmodsyms
Content-Language: en-US
To:     Nick Alcock <nick.alcock@oracle.com>
CC:     Steven Rostedt <rostedt@goodmis.org>, <mcgrof@kernel.org>,
        <masahiroy@kernel.org>, <linux-modules@vger.kernel.org>,
        <linux-trace-kernel@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <arnd@arndb.de>,
        <akpm@linux-foundation.org>, <eugene.loh@oracle.com>,
        <kris.van.hees@oracle.com>, <bpf@vger.kernel.org>,
        Jiri Olsa <jolsa@redhat.com>
References: <20221205163157.269335-1-nick.alcock@oracle.com>
 <20230508180653.4791819e@rorschach.local.home>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230508180653.4791819e@rorschach.local.home>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFlhUEZmNVpTSXZ4VjI0SUttbFJEMUtUbXZxZk93NzVPc1JJdGxxSG05Y1hP?=
 =?utf-8?B?L2FLQTFBaHkweW1JS1lrMFc4eFYxWXJIM1p3TlFFQVAvRnJVMGpKN25hUStF?=
 =?utf-8?B?OTR1bzdZd1J1U2dUTDNzWURjNFVZUGFQNXIvdlV5QkhmVFpodjVGTVN0TWE2?=
 =?utf-8?B?NDVYN1JuUDExaW9INVZ0dFBjSUtqYTJMTDNwa3lrdlM2dGM2WG82NUVwQ1dH?=
 =?utf-8?B?MGFIR080VnhVaWphR2ZPaWhQbWJGOHZoSHkzYWN5SmxBWWdCWGlkV1ZaZmRN?=
 =?utf-8?B?M0xDUm96N0ZVUllLWEtWWnpCY0d3WFoyZDNFVjFkNmJSQ3RNR1JqdGloZ2Z2?=
 =?utf-8?B?dnN0OTdNUnQzbVlQYk9pa0VjcXVBNDRzZW1XdGZHZG95SVFrYUNMWldZcUVL?=
 =?utf-8?B?NERzR3Jnc3BWVm8xSy8wYmw4VC9pKzVoLzl4TStudktkOGRoZGYvTHRRZERQ?=
 =?utf-8?B?SU14SWtwWFZBL1hDZm9UdTQ2OUQzc2Z6a09pMm5tL0hpMTJlR1MyeWRBZ21k?=
 =?utf-8?B?QllKcVEyUWYxZSt6TXNURTBwQmpBT00xNTBxeUtpc3lBTG5hNXRqaVQ4RVIr?=
 =?utf-8?B?WnNRc0RJS0FqYnVXek5TQzFkNUwvWDlzMjJJd2k3WHU3NVhxUHZWWjRmenh4?=
 =?utf-8?B?NHlNMXoxVk50Q2Q4QzJXK2pScGNpb0tEclNndW5Ja1pHY2VZOHlLSFgvWU04?=
 =?utf-8?B?OEVYL3d5bTBEVHB0VXlGcUE1UzdpOTFOWVVia05pN2xENUVzaW1Za295TEhy?=
 =?utf-8?B?ZkdvTU95dDQvNmh5TTMrTGRkcGNZeDZyVU9jZGIzVmJVTjhoRW1TZS9Vdmla?=
 =?utf-8?B?RGNyd3BEQW81cmV6QXFVY0x2S3pKdmprRDIvQ3R2RElKdjRCeW1tUTBCZUZU?=
 =?utf-8?B?ZWxWcFRBdzFiVnJwMm5CcC9DbGlCUU5ZUnU2bHJhK0EzQjRZaWNPQ0ViblJi?=
 =?utf-8?B?b1VVdE1TN2hUbS9BVWxhSCtKY3o4eVNxckNwYTZJclhOSlFBc0dVWGZxVHU1?=
 =?utf-8?B?eEpzUy9KTzhlQlNidkVnTjExMU5lV29JbWZ6WUtnUmJHLytoSUF0TVhleEU2?=
 =?utf-8?B?NEtvRG4zc05MVysyQWdWNmh0Q2RJTWVGSElmT21CakEvRnloZ2ZrSmF2SDdq?=
 =?utf-8?B?Nmk0VHQwa2FIbndhVENKUkU5VDhEQnRxWjZYN2Y2VnV0Z3ZsdGQrREhXS0JX?=
 =?utf-8?B?TnE2ZnlZYmxXK25jb083NFhIT3MvcDY1VDc0TUhVb2Q1Sks0bHJTZkY0WC82?=
 =?utf-8?B?U25hUkJZMUJRTnZHQlkzVEZRdzZVRkhuY2ZmV2duUjhDdjlUSlRCMEx4Uy9S?=
 =?utf-8?B?dWVWckdrSmduNWZ3MERjZHRHK1dndzBKZGM1NWliZit0Y1FVRjdyZGU1M21p?=
 =?utf-8?B?UWc0TFpjN0hkVytESHVTVVZVK2ZibWU2NGF2ZmNoZFRMWVJrdGhzeUZ1YlFr?=
 =?utf-8?B?OEttOW5YUnZmZHFCYjdMSjF2bjkyOFduR0NHeEtyeDBRVFkxOTVBT0pkSHVk?=
 =?utf-8?B?R0g1OGdvY0tBeXIvRWw2Y2krL3RISGpxTDN6U2NPN3Y2N2F2ZmU0WHBPNnZu?=
 =?utf-8?B?YVA4bVpiaGltUWRvWE8rSm1FbXlkVXVyRkVKNHBVOG1YSmxSbVpnV1ZNUHVR?=
 =?utf-8?B?amhFL3VxYlZseDh1c0hyTndKcW9qSkhXK0FOMWtjYkJpdXNRZlU4VG5QRkdC?=
 =?utf-8?B?QWNUZm5URWNDcGROek9YVzdQSExCNmxtNEM2YVU4SFZZdlJLelNMeWE1TGQy?=
 =?utf-8?B?b0FmMWtuS0pqOTdYTmdCWUVWcUhHWkJtOG81NGdxNzU2ZURBQ3lHSDR1aEZl?=
 =?utf-8?B?UnRqUWVsdms0dUlpc25LN3JEMlJnVDJyWVpWN2wvTCsrTkppcHJqVmJ5SE91?=
 =?utf-8?B?T1ZKVzhPei9SZUE4d1NMQXg5ZTdkZldJbmJ5ZGN4R0pxOGEyaHBHRTN4Tml2?=
 =?utf-8?B?dWtHaVRieXNIdnBCSnJTU1dDTEkyOHN0bkFSREF6Rlo0S0M4TlVQakZFR1J2?=
 =?utf-8?B?aGsxc0t5WFh1WFZiblY3emY5TXpWT3pkYno1ek1PNDFkVjNnVEdzREtZTUNl?=
 =?utf-8?B?c05KSHkwQVh4RVlrdkprS0hUQW9acGxLeTJVWEV4enc4MGRBNFdYb1BWd2Yz?=
 =?utf-8?B?QzdqQy9ldHVWT1hkWFdLNzdkOHB6NHVyc2VuZkhBNVV4R2dVaXk5UGFBWDBq?=
 =?utf-8?B?c3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 894b93cf-6e39-408a-d494-08db5880f1bc
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2023 15:51:44.0433
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PIEttWkD/R4y/7DAmJp2LnO9jgFbOgKaGdiBv/aDOLwEPh6MeT4p5A//lCyKevuCSvn869f3jdIX4cUFhK0cYi0d6ysbRBgSpxas6ny6Mws=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6261
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Steven Rostedt <rostedt@goodmis.org>
Date: Mon, 8 May 2023 18:06:53 -0400

> This topic came up at LSFMM, presented by Jiri.
> 
> I'm Cc'ing this email to the BPF mailing list.
> 
> -- Steve
> 
> 
> On Mon,  5 Dec 2022 16:31:44 +0000
> Nick Alcock <nick.alcock@oracle.com> wrote:
> 
>> The kallmodsyms patch series was originally posted in Nov 2019, and the thread
>> (https://lore.kernel.org/linux-kbuild/20191114223036.9359-1-eugene.loh@oracle.com/t/#u)
>> shows review comments, questions, and feedback from interested parties.
>> Most recent posting: <https://lore.kernel.org/linux-modules/20221109134132.9052-1-nick.alcock@oracle.com/T/#t>.
>>
>> All review comments have been satisfied, as far as I know: in particular
>> Yamada's note about translation units that are shared between built-in
>> modules is satisfied with a better representation which is also much, much
>> smaller, and we are no longer using modules_thick.builtin but Luis's new
>> modules.builtin.objs.
>>
>> A kernel tree containing this series alone:
>>    https://github.com/oracle/dtrace-linux-kernel kallmodsyms/6.1-rc4-modules-next
>>
>>
>> The whole point of symbols is that their names are unique: you can look up a
>> symbol and get back a unique address, and vice versa.  Alas, because
>> /proc/kallsyms (rightly) reports all symbols, even hidden ones, it does not
>> really satisfy this requirement.  Large numbers of symbols are duplicated
>> many times (just search for __list_del_entry!), and while usually these are
>> just out-of-lined things defined in header files and thus all have the same
>> implementation, it does make it needlessly hard to figure out which one is
>> which in stack dumps, when tracing, and such things.  Some configuration
>> options make things much worse: my test make allyesconfig runs introduced
>> thousands of text symbols named _sub_I_65535_1, one per compiler-generated
>> object file, and it was fairly easy to make them appear in ftrace output.

FYI for devs: I posted RFC of kallsyms with file paths almost a year
ago[0], but it went unnoticed =\

`file name + function name` is not a unique pair: in one of FG-KASLR
discussions, someone even wrote simple script, which showed around 40
collisions in the kernel. My approach was to include file path starting
at the kernel root folder, i.e. `net/core/dev.o:register_netdev`.
I'm not sure why no comments happened back then tho. Maybe you could
take a look, I'm pretty busy with other projects, but if you find
anything useful there in the RFC, I could join to a little bit.

[0]
https://lore.kernel.org/all/20220818115306.1109642-1-alexandr.lobakin@intel.com

Thanks,
Olek