Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2792395rwd; Fri, 19 May 2023 10:12:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5SfE4CvR6gaGc6UtVqjc6IXCXHXVyuBKzX9mKCcY81mzyiaG2EcBFHA+KdXzNZ9pfRA/gs X-Received: by 2002:a05:6a20:430c:b0:101:5ef3:1a02 with SMTP id h12-20020a056a20430c00b001015ef31a02mr3219833pzk.7.1684516347595; Fri, 19 May 2023 10:12:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684516347; cv=none; d=google.com; s=arc-20160816; b=VVS/gebpL5JgHiPJaDVbmL1WTF4lcVMc27cm39/RYqKpjyKmenk4rsy4zYKPvjN9me 9DURU/Rjvpp5ddiYlX8CRQUD68JgSssUtUpHfYgzk37g4+Gtxjv7vQKsLgAGxEUL2LhP OcsGoqeM5m4UoLZoIMzqaWRSNSpeUGitVe+BFCbdzTe5Si/M4KkNYZgUcxtJ2Ta05yNT 9KDiClsuyRyNFMe+b3cS5xsFoxT+TCoNxFpPuwTTh+NaeZqUY8jZ71yDwrS2hr9+y52c UDh6azgc70SH8420gz0hcDKSQBSeJ3eWsRUyyA7N1YhJexGCDfk0MZZRJmdbcDApP47Y Iu3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ermZRAVuUoVUkWCNUZOtH1iovxjOCeT0E8mJeG1r0+I=; b=BXnKQGKeFk2mQDKDLpeP1ZJ0su8craq7Whgm83WPeaBcCKnCAJ1x7d1MVGOlotiu2h i7ETKELItibRXEV/4Bz4M08VEBiy/vrPf3m/jYYNH/kYizssjzvCRGFfp5bjGGUwT4h6 twJpXHMVCwirFoOLA+TnTQ7YRzzLm/f/shF09LzGAnXkBBm89Y86UGMtV8Wr99IhOM8o 5I4QvNMHy9SrlceaPiepzJ1/busRejYSW8PSBTLvyvZSMOl89WkqhJZKZMAzXY8AWqZg h71jfS8M460qu0JR38R90cOLYq7PBzVOeM/GaAkN8oKo10K/nLC21sgpnNIZneZwmVe4 Cyew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=c8bg5UGk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 138-20020a630190000000b005346ce4f2absi95677pgb.605.2023.05.19.10.11.56; Fri, 19 May 2023 10:12:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=c8bg5UGk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229523AbjESRJa (ORCPT + 99 others); Fri, 19 May 2023 13:09:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231996AbjESRJX (ORCPT ); Fri, 19 May 2023 13:09:23 -0400 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.196]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9306A170B; Fri, 19 May 2023 10:09:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=ermZR AVuUoVUkWCNUZOtH1iovxjOCeT0E8mJeG1r0+I=; b=c8bg5UGkN+QKNMc7GUCVj nbRykxbHGXSq6kDTA0CCIynXgQiwtfU+WEMBP3GV44WqWelTu0N1XuTqmk7NZZLL SB6hTSYVDUWIEJK5Bc1WqJhVi21tUxRQHmFoum6OR3mQWH+bIZgNMzrEfhL4UUoM aniNd2AfBAOBN7fiGizrVk= Received: from lizhe.. (unknown [120.245.132.248]) by zwqz-smtp-mta-g5-3 (Coremail) with SMTP id _____wCnJg_FrGdktqNhAA--.38178S4; Sat, 20 May 2023 01:07:59 +0800 (CST) From: Lizhe To: lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, daniel.machon@microchip.com, UNGLinuxDriver@microchip.com, linus.walleij@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Lizhe Subject: [PATCH] drivers/pinctrl.c : Remove redundant clearing of IRQ_TYPE_SENSE_MASK Date: Sat, 20 May 2023 01:07:16 +0800 Message-Id: <20230519170716.3459-1-sensor1010@163.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: _____wCnJg_FrGdktqNhAA--.38178S4 X-Coremail-Antispam: 1Uf129KBjvdXoW7GFy8uF1xGF4UZF1kWr1rJFb_yoWfGrX_uF W5J39Fq3y8WF1ayrWxKr43ZFZ0yF4UXFnYgasYqan3CrW5Aw4jyrn7uF15Cws3uryUuFyj yryrXr4Fyry7AjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRKpBTDUUUUU== X-Originating-IP: [120.245.132.248] X-CM-SenderInfo: 5vhq20jurqiii6rwjhhfrp/xtbBdBF0q1gi6LwzcwAAsU X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Before executing microchip_sgpio_irq_set_type(), type has already been cleared IRQ_TYPE_SENSE_MASK, see __irq_set_trigger(). Signed-off-by: Lizhe --- drivers/pinctrl/pinctrl-microchip-sgpio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pinctrl-microchip-sgpio.c index 4794602316e7..59f232a68b5a 100644 --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c @@ -719,8 +719,6 @@ static void microchip_sgpio_irq_ack(struct irq_data *data) static int microchip_sgpio_irq_set_type(struct irq_data *data, unsigned int type) { - type &= IRQ_TYPE_SENSE_MASK; - switch (type) { case IRQ_TYPE_EDGE_BOTH: irq_set_handler_locked(data, handle_edge_irq); -- 2.34.1