Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Frank Li <frank.li@nxp.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        "lpieralisi@kernel.org" <lpieralisi@kernel.org>,
        "kw@linux.com" <kw@linux.com>
CC:     "kishon@kernel.org" <kishon@kernel.org>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: RE: [EXT] [PATCH v4 1/7] PCI: endpoint: Pass EPF device ID to the
 probe function
Thread-Topic: [EXT] [PATCH v4 1/7] PCI: endpoint: Pass EPF device ID to the
 probe function
Thread-Index: AQHZimAtHZjexVD+d0eV/y9Kvbge7K9h5aiQ
Date:   Fri, 19 May 2023 18:11:15 +0000
Message-ID: <AM6PR04MB483851273EF610DE449B04FB887C9@AM6PR04MB4838.eurprd04.prod.outlook.com>
References: <20230519144215.25167-1-manivannan.sadhasivam@linaro.org>
 <20230519144215.25167-2-manivannan.sadhasivam@linaro.org>
In-Reply-To: <20230519144215.25167-2-manivannan.sadhasivam@linaro.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZF5LRrZR2sqZz30Mj0wjZIunGfVs4cKZg7kPZ1i32ygnrLVJUFcYQLPxQ133?=
 =?us-ascii?Q?VToI18ZafIzdfRGRWGkYDX7Pxz8fDizX8h+4xg5k+lfVXZRYTjvNRcN9szcQ?=
 =?us-ascii?Q?veTYtK0I5hxX1tSwbmfNmefEWhL5kDE15SN9nVgxnI73jQLcyjD9XhOQ/F8n?=
 =?us-ascii?Q?1BsqhP0ufo+nxMYH3BwbI2+ty4aSSty+ntVkHk67T+ASiY2A0rhtI4CM+Wex?=
 =?us-ascii?Q?f43Cr/eK3J2l8Gtjq6/UVFDy/50SPDMIjePcFARVU4oHYu2xiIKrBE/K0UQD?=
 =?us-ascii?Q?VTJs6h/zidiINvLZVBLf0C6qBvTcCUxeNYuX+L/K0FhPVwPHGMA2oN6ykEYZ?=
 =?us-ascii?Q?i7QRvuOrMOjSMjOGufGMRWfXQIWB6SHlNjU5lnKOzJtd7qnULknAI9PmwjCi?=
 =?us-ascii?Q?SxErk6okRvBQUktSa8RuFypjvkvl8tb4l0lBO8br5Cb7CUpG7PoOVx5JmVQg?=
 =?us-ascii?Q?kxiynd0lx4x5VBnr7SABZS2Di3nYsAIF1Fi6KwaiiAwOElyR/dNhRbzrhe+c?=
 =?us-ascii?Q?Ptq7p1PnqPsaF49s12f9u7C+pw6Ee8SH1hiKITvj55XaAAOoYc16IJ1rpC8q?=
 =?us-ascii?Q?/Aef4LTfpWlr+MuaVAmBkv2nyRmIkNC/J+g4xPfP/18c5LrDRIF6IdmZ8H2B?=
 =?us-ascii?Q?i0DCw4MqFkHftpYtkZYwgPnaQrcz+xLI1mHDZnXWYZdvXIyPVe9ZviPXKkLo?=
 =?us-ascii?Q?RrmfHsPDr+GuG7bnwxN1LL4ILngNkcfjVdwpVUR6KIblZDMXGWXI9vbe7P70?=
 =?us-ascii?Q?EaUsfurHXlKgfiTwCO6DUmNlnAezv8/wKDSJbcuQ3/S+WEVTtDlk6Eeid7sA?=
 =?us-ascii?Q?0Rvk8a1eQ0px7QDRjsvU5LZGjLDwsjp+qkjQehZ4OoZWKkzasM2Q/zaKpaSJ?=
 =?us-ascii?Q?KsMOEXsjfvq/BcopdQFnM0kjPgmXbNHJad3uHvcGWsXuootypZFkqUthkjKj?=
 =?us-ascii?Q?zfBAp/u+x0TUw2vbo/6S8z/P3SgwPGWkMtQqkG5DLfiQmzEd3dxhHVqEc7kC?=
 =?us-ascii?Q?fv0Kcw2To+pJNRbnGWQuXG97oyUcmrRSg6/Ya8OBOHyhz8LXSNLGmZEnFTrp?=
 =?us-ascii?Q?9FhbLlZGXSDuAUPkmoPVleyTtd8NXSCI/x+fw/nEKX8OOUqXduATSoYUzoj5?=
 =?us-ascii?Q?Q0i5otWpdtkUid6ecyX8KnYfsgqNfPA3QJ3+mXx0udGXa9Rt6mnPb8BA3yUa?=
 =?us-ascii?Q?RxcLSyBB9cCWTvDA7UXL30JRidthDuPM2kyKKkhwmSQaGH1l0Yn4+IF9zEro?=
 =?us-ascii?Q?qH9VtbsowmnrYOImzx3ZKNBOlQHPCJ4RIQAYkf1vT5Ha8BLD67nQuAroTpbT?=
 =?us-ascii?Q?+hEZ8JZ0RJsxfv2PLNatEDujYOgduQIJvWZmGNp9qwHF1kRBYowZ35emAbrP?=
 =?us-ascii?Q?wYgPkjJlHjDae2ipBb6r1W+O4LC05/RhjwiTLSQxiREWJqTaHlaLWEktWx1s?=
 =?us-ascii?Q?C+vORxoc91dcuPZAwkWniEV31THOifwLyjRdf1vwhFGTB8+c6B59Hj1xGFV8?=
 =?us-ascii?Q?385owj1yhE5Tg12hkG1wI2Gtz5tDfXbenvJOGKSWofzF3HEVG+bFpVrZaAVH?=
 =?us-ascii?Q?Seh92JeLywBMH7+G3bg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13d09555-ab87-4560-4258-08db58946f6c
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2023 18:11:15.0711
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: S9qO0X23rhprLgY7Hk7gRTW3q0/rOy04TQCqGLGBKd4TrRMzApcaYbK5wzTB/yxZVw7DPWm5Ny3JlLVIEuNVDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8623
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> Currently, the EPF probe function doesn't get the device ID argument
> needed
> to correctly identify the device table ID of the EPF device.
>=20
> When multiple entries are added to the "struct pci_epf_device_id" table,
> the probe function needs to identify the correct one. And the only way to
> do so is by storing the correct device ID in "struct pci_epf" during
> "pci_epf_match_id()" and passing that to probe().
>=20
> Reviewed-by: Kishon Vijay Abraham I <kishon@kernel.org>
> Signed-off-by: Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
>  drivers/pci/endpoint/functions/pci-epf-ntb.c  | 3 ++-
>  drivers/pci/endpoint/functions/pci-epf-test.c | 2 +-
>  drivers/pci/endpoint/functions/pci-epf-vntb.c | 2 +-
>  drivers/pci/endpoint/pci-epf-core.c           | 8 +++++---
>  include/linux/pci-epf.h                       | 4 +++-
>  5 files changed, 12 insertions(+), 7 deletions(-)
>=20