Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <eff05b97-6cf0-7688-15cb-08b5b4d9276f@gmx.de>
Date:   Fri, 19 May 2023 20:40:48 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [syzbot] [fbdev?] [usb?] WARNING in
 dlfb_submit_urb/usb_submit_urb (2)
Content-Language: en-US
To:     Alan Stern <stern@rowland.harvard.edu>
Cc:     linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        syzbot <syzbot+0e22d63dcebb802b9bc8@syzkaller.appspotmail.com>,
        bernie@plugable.com, linux-usb@vger.kernel.org,
        syzkaller-bugs@googlegroups.com
References: <0000000000004a222005fbf00461@google.com>
 <ZGXVANMhn5j/jObU@ls3530>
 <4cd17511-2b60-4c37-baf3-c477cf6d1761@rowland.harvard.edu>
 <be824fbc-cde4-9a2a-8fb4-1ca23f498dca@gmx.de>
 <2905a85f-4a3b-4a4f-b8fb-a4d037d6c591@rowland.harvard.edu>
 <ZGZ3JPLqxCxA2UB6@ls3530>
 <c7b8e69a-cabe-4e17-a511-66179259d1d7@rowland.harvard.edu>
 <6e93305a-2d70-d411-3e36-c536449295dd@gmx.de>
 <c1cf7ff1-c204-4afc-aa9d-890e07d5ec72@rowland.harvard.edu>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <c1cf7ff1-c204-4afc-aa9d-890e07d5ec72@rowland.harvard.edu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:61dTdC5bWHo=;zjMSoS1U0kXpSMcGr82RaoSzznO
 zkG4jMkeN8aPFM7PgBR/hk+wI9KhLRHbV8YUx9/ekIywlmHNk++HbGu0jsvWFsSDqGipt32pT
 b6QrAj29Y6WsDLurgq1udmnbADM+bWp8ad8jcZ1o6mhUAGgw3TUuRPuzgamovQB+n/EX+UsoK
 aAudo94B3OxrJk9feX2NcfIk0bZwbQMY27k0a0ycwLqvplIGXROeo+ayHjFXtA0sXIW8nliXv
 ecR+A/SxjU2906nq0IkMB6XHXTyX6NeCeVEorekGHwdxLflu7h6d8H+gzDROXkM/JNd03BgBM
 eyD+2xQgih2CBo92XGM5AC1oLD4/7Ckk1iFirDBrMErocnDHNYx0F/DPn12Cux3g4n4dojuq1
 JsDL/ZM88cIJA0Dn8x8ETQhGIOajxV4Q4YSNLKI/qEyfnIZVeOSMnBK7Hf/V4qFbfKU1EHUp8
 MrGEezMTRHxqwy4p8v/mLJlpY0L6dFXsEFGbAn+5LNNjgCPUnT5Fhz3wb0E2gKBSnTQYckg/T
 U1Sz9r/4b8Im3q4XlX8Ot2FWdA+fe3I1S1paxvmOGWK0dL48gTfEm9vU2Hqxkgc27XZuBfH4C
 d2DdibSJkVuhJ/CMuBqJlCC7SFHKGEP5F6ogwhTjz7p66tWQcBpQhEcA5bFStsEA6hD/AWojX
 KUXFOY+yhGSJ20ZogQsJqs9ngKRytnEBMMvWypFtiSNNniBCjqwIAd4DgNiADFJ2u8R4p+9vB
 QvO+WCDihnE5g5iivaNYru73VQxzXyxoZdL0BpPa4agv9rKkGZ1kbOqw2e2h7sVcfZ+61pwzn
 /LbXZZMdvSdnLKtlt120Uz76qut7/oA25Q9LVqMXHfmWuVPZ0vBgrJKkdEK/mf8HSOqE31fBx
 L/U+RGakcuPREMsUeqxZpHGEUbaA5InQlTGglZ06BFB1nUQxtdb7drVq48LSi7HMV57Gc9Szd
 CxjcyS1QxUJO+le8HNF2fYZkA14=
Precedence: bulk

On 5/19/23 17:42, Alan Stern wrote:
> On Fri, May 19, 2023 at 12:38:15PM +0200, Helge Deller wrote:
>> Patch looks good and survived the test.
>>
>> Will you send a proper patch to the fbdev mailing list, so that I can
>> include it?
>
> Will do.

Great! Thanks!

> While you're working on this driver,

I'm not working on that driver. Just looked into it because of this
sysbot issue. I even don't have that hardware to test.

> here's a suggestion for another
> improvement you can make.  The temporary buffer allocations and calls to
> usb_control_msg() in dlfb_get_edid() and dlfb_select_std_channel() can
> be replaced with calls to usb_control_msg_recv() and
> usb_control_msg_send() respectively.

Ok, I'll look into it.

Helge