Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230519125409.497439-1-quic_srichara@quicinc.com> <20230519125409.497439-5-quic_srichara@quicinc.com>
In-Reply-To: <20230519125409.497439-5-quic_srichara@quicinc.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 19 May 2023 21:47:43 +0300
Message-ID: <CAHp75VfVx+oGYKcija3h9-eWc6jggMx8p5SAQTEHTBEbjTaJKw@mail.gmail.com>
Subject: Re: [PATCH V7 4/8] pinctrl: qcom: Add IPQ5018 pinctrl driver
To:     Sricharan Ramabadhran <quic_srichara@quicinc.com>
Cc:     agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        mturquette@baylibre.com, sboyd@kernel.org, ulf.hansson@linaro.org,
        linus.walleij@linaro.org, catalin.marinas@arm.com, will@kernel.org,
        p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, robimarko@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, May 19, 2023 at 3:55=E2=80=AFPM Sricharan Ramabadhran
<quic_srichara@quicinc.com> wrote:
>
> Add pinctrl definitions for the TLMM of IPQ5018.

A couple of remarks either for the next version of the series or for
the follow ups.

...

> +config PINCTRL_IPQ5018
> +       tristate "Qualcomm Technologies, Inc. IPQ5018 pin controller driv=
er"

> +       depends on GPIOLIB && OF

I'm wondering why OF.
If it's a functional dependency (I do not see compile-time one) the
compile test can be added, no?

  depends on GPIOLIB
  depends on OF || COMPILE_TEST

> +       select PINCTRL_MSM
> +       help
> +         This is the pinctrl, pinmux, pinconf and gpiolib driver for
> +         the Qualcomm Technologies Inc. TLMM block found on the
> +         Qualcomm Technologies Inc. IPQ5018 platform. Select this for
> +         IPQ5018.

...

> +#include <linux/module.h>

> +#include <linux/of.h>

There is a wrong header (the code doesn't use this one).
You meant mod_devicetable.h

> +#include <linux/platform_device.h>

Besides that kernel.h for ARRAY_SIZE() init.h for arch_initcall() and
others might be missing.

--=20
With Best Regards,
Andy Shevchenko