Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 May 2023 21:07:15 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Conor Dooley <conor.dooley@microchip.com>
Cc:     JeeHeng Sia <jeeheng.sia@starfivetech.com>,
        Song Shuai <suagrfillet@gmail.com>,
        "paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
        "palmer@dabbelt.com" <palmer@dabbelt.com>,
        "aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
        Mason Huo <mason.huo@starfivetech.com>,
        Leyfoon Tan <leyfoon.tan@starfivetech.com>,
        "ajones@ventanamicro.com" <ajones@ventanamicro.com>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Song Shuai <songshuaishuai@tinylab.org>
Subject: Re: [PATCH] riscv: hibernation: Remove duplicate call of
 suspend_restore_csrs
Message-ID: <20230519-roundup-legwarmer-e26b31db3123@spud>
References: <20230519102908.253458-1-suagrfillet@gmail.com>
 <9a274a44b61345e8aba747a44250c4d8@EXMBX066.cuchost.com>
 <20230519-clarinet-collar-ba2c0fa37e11@wendy>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="uSefXicpntsEBwun"
Content-Disposition: inline
In-Reply-To: <20230519-clarinet-collar-ba2c0fa37e11@wendy>
Precedence: bulk


--uSefXicpntsEBwun
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 19, 2023 at 12:28:07PM +0100, Conor Dooley wrote:
> Hey,
>=20
> On Fri, May 19, 2023 at 11:14:27AM +0000, JeeHeng Sia wrote:
>=20
> > > The suspend_restore_csrs is called in both __hibernate_cpu_resume
> > > and the `else` of subsequent swsusp_arch_suspend.
> > >=20
> > > Removing the first call makes both suspend_{save,restore}_csrs
> > > left in swsusp_arch_suspend for clean code.

It took me embarrassingly long to wrap my head around the control flow
here again. I'm not sure that I agree with you that splitting the calls
between asm & c is cleaner, but whatever:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

> > >=20
> > > Signed-off-by: Song Shuai <suagrfillet@gmail.com>
> > > Signed-off-by: Song Shuai <songshuaishuai@tinylab.org>
>=20
> BTW, why the two email addresses? The tinylab one here seems entirely
> redundant - unless it is your employer, in which case should it be the
> only SoB address & also in the author field?

Deja vu with my questioning your email address, but does your
tinylab address actually repeat "shuai"?

> Also, Fixes tag?
>=20
> > > ---
> > >  arch/riscv/kernel/hibernate-asm.S | 1 -
> > >  1 file changed, 1 deletion(-)
> > >=20
> > > diff --git a/arch/riscv/kernel/hibernate-asm.S b/arch/riscv/kernel/hi=
bernate-asm.S
> > > index 5c76671c7e15..d698dd7df637 100644
> > > --- a/arch/riscv/kernel/hibernate-asm.S
> > > +++ b/arch/riscv/kernel/hibernate-asm.S
> > > @@ -28,7 +28,6 @@ ENTRY(__hibernate_cpu_resume)
> > >=20
> > >  	REG_L	a0, hibernate_cpu_context
> > >=20
> > > -	suspend_restore_csrs
> > >  	suspend_restore_regs
>=20
> > Good catch. This function is invoked twice to restore the CSRs.
> > I am good with removing this function from here.
>=20
> If that's a review, then please either give an R-b or A-b tag :)
>=20
> Thanks,
> Conor.


--uSefXicpntsEBwun
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZGfW8gAKCRB4tDGHoIJi
0tw4AQDBfboPqCfJHjV7Ajz/a1GmKu7ftIVfnIVRkMql7569iwD/atGwcUcipdg1
g8k7p+pQvEvpeT4Jk8RmodBPZGOaaAA=
=YRPl
-----END PGP SIGNATURE-----

--uSefXicpntsEBwun--