Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3034102rwd; Fri, 19 May 2023 13:57:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5X+qfdqTpIoLzx24g152KzBr6R+Tdc/5GYDqIZYTwIwin0alyXp7TbCLVgHqUx4HJLnR5g X-Received: by 2002:a17:90a:564a:b0:252:ad82:aeb7 with SMTP id d10-20020a17090a564a00b00252ad82aeb7mr3244304pji.38.1684529838361; Fri, 19 May 2023 13:57:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684529838; cv=none; d=google.com; s=arc-20160816; b=QG1mM7/tAZu/BV0yA2oJj/gm4qy5pTu02IxB5n2ca/eZz0l6ngkALJ9js3/8enKfeV jvPwLEUTRmDVTxXcmlQ95S9jgbJHST6Hk0P4WtXw/KsxmSDjf6LPspei+d4aB+Tv1bFL /3ggu5JXtTeof0AQK1oRjgQjorHc1GfYpNM3FFidVLjrX1ekc2RenIGurn6LlmE+wS9h MjgpZno3c3+9UjYW2qoSYglQmdXEZmsMidto/mka7I1P+UhTpmHtBufOlSu700NgwS6+ 3NclO8aCBoDPNp1oOaZhCeZuIdSdmO2I1uho7NkuqPPBpCuxnATicCMSTxu56JX0tp2X 73Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=xAE6bKGD8uI4B1Ojm7oaDsntRbDY/p/o83Rm9HGs3vU=; b=C8QbDpF70QO6wG7tcFQyZdu+Oh4kmpHbpJfo4r+p3Fh5ZjkeXXWO2KSxAO84bTIEpC KF6FTdaM9idkDocLo+y6RwLjTrdPfBaioRDzuzw/AnL+dsXQCRLvTV/no4YleT+Kp7T7 KfhUzH0YshCVTN2q07IfaotKt7EapmkTa8xwnBXENn2E+p1v1MSPM+l+byrhpv3GUaN+ Vpo3413VVYaD7vjAYaSHj28GMx88zCcPvnypONpKxxp5Lx/Glqaquuubf5L1IFiXsrDc 4NacHwmAzadbJdK05HhOrWFIX3WoHyVF/WsCFEKPAaHrlORiGd26XIF4haP5wPMZHJJb KBTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KhQh40O1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k13-20020a63ab4d000000b005349008e6c1si201591pgp.264.2023.05.19.13.57.03; Fri, 19 May 2023 13:57:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KhQh40O1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229458AbjESU06 (ORCPT + 99 others); Fri, 19 May 2023 16:26:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbjESU04 (ORCPT ); Fri, 19 May 2023 16:26:56 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD941E0 for ; Fri, 19 May 2023 13:26:55 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3078fa679a7so3613882f8f.3 for ; Fri, 19 May 2023 13:26:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684528014; x=1687120014; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xAE6bKGD8uI4B1Ojm7oaDsntRbDY/p/o83Rm9HGs3vU=; b=KhQh40O1foL2uAE4MXyDZfPQ5dBQPWBnpePjc4y7//CUqlwhXfNm71R7dYxmEJwWWG rcaOqd+lIjIKiEE08whNoRF97O97YYF1vTCQS2xZ7QSSLDW5/OKkcyEGapsecuN9/to2 v2BNxDmrF1a3IEzJiwbJ7osQD4vwrNfvAKgQiMfw1I++7sILIG1YSGGVeWdJCEOROapP wfLarCWDjHf6uPYYt0NeZ4pIgzO2tEoUuUMIFC/JxzpARfwOLfcGJz+utC+29Nof1tWj 726P5tfBTvxjVUdwixgi/sKT1pl+HCC3hmOg+yCSbfISpiLD0/Y+qWcyKGM1JmallZq0 dZkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684528014; x=1687120014; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xAE6bKGD8uI4B1Ojm7oaDsntRbDY/p/o83Rm9HGs3vU=; b=Z1/YHn/aNH2kvg+U1UlJ5EclEECg/ZJE8s10n2WtyHl4EZwHEGEqfnL8IXusNeH7+K /olXRW+vxe8lr6BEP7XgRyqnkqrKZdfkzqmM67WbphfwbzViyaOMHRGdyDyB/Q+14Ek4 dJD0csCQd4ETkvSVLY192KlfwxOV6E302ZGijzdhF/m7YpPql2UltjBvDq4x+X7eDuL2 xzaV66rss1I0mEc0sB1glvTfRbOw+z5plExt0HMoBUSW/Dia9YKC7JFlOlR/QQqMGI4x SCK8nOCica+P6hxEmbowM5KzCACXiboC25ygcF72XYOsTBfemUi1BN8U2neH/R4EGyPG JiPw== X-Gm-Message-State: AC+VfDxwLI23KgFV93gkICGzpJKlTePbgyuQ+NLfp11AnYLF7+M0QZ+C nH8dEvZ54eRi0WOm1IWjmbVLsQ== X-Received: by 2002:a5d:5188:0:b0:306:43a4:86b with SMTP id k8-20020a5d5188000000b0030643a4086bmr2636003wrv.4.1684528014184; Fri, 19 May 2023 13:26:54 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id k17-20020a5d5251000000b003079693eff2sm6137050wrc.41.2023.05.19.13.26.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 May 2023 13:26:53 -0700 (PDT) Message-ID: <0d0a1985-a08b-29ed-4bc4-2eea560d7ac0@linaro.org> Date: Fri, 19 May 2023 21:26:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 3/4] clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550 Content-Language: en-US To: Jagadeesh Kona , Andy Gross , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taniya Das , Satya Priya Kakitapalli References: <20230519155602.6642-1-quic_jkona@quicinc.com> <20230519155602.6642-4-quic_jkona@quicinc.com> From: Bryan O'Donoghue In-Reply-To: <20230519155602.6642-4-quic_jkona@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/05/2023 16:56, Jagadeesh Kona wrote: > +MODULE_DESCRIPTION("QTI CAM_CC SM8550 Driver"); This pattern looks odd and inconsistent in our clock drivers. We mostly have CAMCC or VIDEOCC but occasionally have CAM_CC and VIDEO_CC. I'd drop that underscore to, in addition to Konrad's comment on Ucase hex. Other than that, LGTM. Reviewed-by: Bryan O'Donoghue