Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3035043rwd; Fri, 19 May 2023 13:58:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5cZ1qU/d0Z1GWy369YWvAeiX6JFazqBfWqfWm24uuT9kTG8eKVGrraGXd+Zp2FO5tO/I0G X-Received: by 2002:a17:902:bf0a:b0:1a9:b8c3:c2c2 with SMTP id bi10-20020a170902bf0a00b001a9b8c3c2c2mr3456794plb.37.1684529901468; Fri, 19 May 2023 13:58:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684529901; cv=none; d=google.com; s=arc-20160816; b=pWdMFO9O6aJbZvcwjXhUKnHABmlgO5ARLF/NBTXk0b7LfG4v4voiWVi7sFeZ7juH6B 9tXNbULLno5sypRSOSNmHG10F6BBcRTf4SBzYduDcBbjKmFsV6BoQKAcG+mKVHTVKYsY 8f1Rxf/waQ6Pcf36aACPjTDtniq9A/6Rl2zx/1BnrkRrt4vlpHRSuqyzbYiX6rT0+IiR mXl0S6LrDbcFaFUTXzgn3r4+RqUby0INnq04Sv3+w6NeXx6XDye/5cKEWB9R2hUmHw32 y+5NnUlvoR2G/zNEtoE017hTyvsE0w2obI2MWKsahcmcYGgMrNdZnPKYFJ1KwhRIPMgZ Otqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:references:subject:to:from :message-id:date:dkim-signature; bh=nEDErbKnDGyXH+lfOvpQDyyAEEG2NpiC+5fpLiNmj9E=; b=VIUc/eSiFk8XgU8PcmhuCzkPOTLwwiED7mxZc+YtLQkkXTX8Vi6zKPujcJ6Y4KMZ7h L6gr27BXaIWRsxoaGNsdH0zv6Es5XT6NVfmkkn0c6tBZBrmeTvVfja7sMbF5JFCTq+4J XDPiWl3KcvNffpLsY4fP26eCXqdrxE4ne9Jbnrq2ND0EXJHqCNhf66S59Jm9UT6MZLPG RNX2dcCZTfV1vwpFmpoDcDIrrsofi5573D7B5wUWaidKr3Ix+tPUQ5ds6m/Tm/9nDHAV vguBeu362AGa9O9bRH6i9KFNtkE3ifGDjK9YVc1/Di6dCw9Iem8tj0TIQTDnM9gDLcxt Umdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore.com header.s=google header.b=LimJZkMR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=paul-moore.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h13-20020a170902f7cd00b001aadd1e0384si114314plw.192.2023.05.19.13.58.06; Fri, 19 May 2023 13:58:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore.com header.s=google header.b=LimJZkMR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=paul-moore.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231627AbjESUyv (ORCPT + 99 others); Fri, 19 May 2023 16:54:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231245AbjESUyo (ORCPT ); Fri, 19 May 2023 16:54:44 -0400 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48A80E43 for ; Fri, 19 May 2023 13:54:41 -0700 (PDT) Received: by mail-qt1-x830.google.com with SMTP id d75a77b69052e-3f684f20f77so24557501cf.2 for ; Fri, 19 May 2023 13:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1684529680; x=1687121680; h=in-reply-to:references:subject:to:from:message-id:date:from:to:cc :subject:date:message-id:reply-to; bh=nEDErbKnDGyXH+lfOvpQDyyAEEG2NpiC+5fpLiNmj9E=; b=LimJZkMRsJLWfeHb2nO6LTXjKeKZWqRYQueh0ON/UMzR84F6/CgY+SQYOeWL4E0XRE 0HSb473/lL38cXrAKcFH7pmi7EuN5T9u7i4rc2ReTUIliGN8elBDkamdVGWQRdJxmmss +Z3stulSjeCIibUWxtlOEnbqQVEyXqzKEfvHcOm5NQvsEFtYJ8Bom+fnMJKuIzuryxb9 6sJKrUHPGutOWb1Coae16vm/qxy3Q3CZe4koU3DusFoYFGqLmBETUyAV1PfXkBaipvXh yIz9bsEJswMFJ+vX9qdh/aSZQTBR3uNALhI8kCi/gWyLy/4oE3j5hf2DoW6kKACvjOvz J1uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684529680; x=1687121680; h=in-reply-to:references:subject:to:from:message-id:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nEDErbKnDGyXH+lfOvpQDyyAEEG2NpiC+5fpLiNmj9E=; b=AecbgF6AiRL5oM7OT4RM5ms7WxPNxiNveu2324F9aaPLCuhZZBCLZZbj2EODST66ua N/xXXOU8TCzydUGg5PS9hFrfa6pXW6TQCkOCpVyxs/1H6Hx3iKKV/UFh8tWN43RDExpb kWzirpNcmAamgVfXbnVjv0GDS1A+bfRu+VPBueaCXXtFz3Qg0IOx9UfF18ghrm67WFxk mCaqVJ4E5maIcxku6Zm6tl97kjiWVS7V4KxUlMJFKLcUryg5X8F/AVcdl/C7ZZUPddxQ 62VthVBZisarVgKlUNqrgPgENkrdpiB3qUxtbXNj5JCCMtuibcn0VeM+8TI9RkxINiND 3IIg== X-Gm-Message-State: AC+VfDwEJbCmZu4I9j5GVYNUFTx6J4B8h5CbQj3rtnEn7GYcx7QBZbjf q+eGP8TnEdpZZ6w9mhPJ0vSrj/9TqvqXwuy/mw== X-Received: by 2002:ac8:5c54:0:b0:3f6:93fb:dbf3 with SMTP id j20-20020ac85c54000000b003f693fbdbf3mr5637977qtj.52.1684529680106; Fri, 19 May 2023 13:54:40 -0700 (PDT) Received: from localhost (pool-108-26-161-203.bstnma.fios.verizon.net. [108.26.161.203]) by smtp.gmail.com with ESMTPSA id ge22-20020a05622a5c9600b003f521882bc1sm129715qtb.7.2023.05.19.13.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 13:54:39 -0700 (PDT) Date: Fri, 19 May 2023 16:54:39 -0400 Message-ID: <8df851e887b1bc67434a3fae877d7cd8.paul@paul-moore.com> From: Paul Moore To: Eiichi Tsukata , eparis@redhat.com, linux-kernel@vger.kernel.org, audit@vger.kernel.org Subject: Re: [PATCH v2 3/5] audit: convert DECLARE_WAITQUEUE to DEFINE_WAIT References: <20230511052116.19452-4-eiichi.tsukata@nutanix.com> In-Reply-To: <20230511052116.19452-4-eiichi.tsukata@nutanix.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On May 11, 2023 Eiichi Tsukata wrote: > > As there is no need to use DECLARE_WAITQUEUE, use simpler DEFINE_WAIT. > > Signed-off-by: Eiichi Tsukata > --- > kernel/audit.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) This change looks reasonable, but it needs to be reworked to take into consideration the comments in patch 2/5. -- paul-moore.com