Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp3043557rwd; Fri, 19 May 2023 14:05:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4vYMdGoChSgLf7rzOOCV+GPAGjXMJFMQJ6gee/qSTxcq7iQTMWhRlbdz7HDPpFEFgFK1OX X-Received: by 2002:a05:6a20:5481:b0:100:5ddc:c6a1 with SMTP id i1-20020a056a20548100b001005ddcc6a1mr3843127pzk.15.1684530299957; Fri, 19 May 2023 14:04:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684530299; cv=none; d=google.com; s=arc-20160816; b=f+jDXT4gKPwlwPKAY90ivIwjZuLm4SwtK5l3RC8nX917b84MIklOBvgj9AQBotSWoT 0jUvFVUrLMwDRVBr/OKfoWD6PF7suRMEsrBdTA+ZYbLPSdyzPwIYvDt7a1ao9G97yrjN fKnJknByVgI0i7TpEBqwHo9k0XzOgshGBEFY485q82Dgyu9k4arWNKbsGTC/gxBzjDYL CYUxt7LWWvUrz2ljEB7HgIJnJJBnZ0RSuf7VGmDVHwOK6uGCbrdZIHy1IrtJcVpyL5sk 8O2mC6xHdqjcHKKp5LA3XDQMy0gvcKIKKMFoW1T0Cs0ZC58uFduDKidEDyb7XXfYMtXx BTag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date; bh=e9YZdh3wGsbypU2U0ay9Agr9vFqJatMDmJlDIjosqIE=; b=NqhDx2Z7pj/yHEM06LR2QWf2v5Pk6AyVZ8tIQuorbEHIoSgiIxVuYAtYk7FmqW8yK7 Mk+/eOTqRyqj94f/M/RUchfH41vpq5eHwF5CYQkL9qRWJULl99rfVY+L1Gj0LVYLPVNV 0wxhZ6qBI2I9N6x7kETlDft2hqnoZynbtFBrUitySmtgapApsB8aaWTqd0GVCA9Metqz abRpsKagb3hVCsVQblRWyiI10vaOa1azMV/mW6KB4R9tRmvrCbMxGvr1nfwBEn6a0BnP XDss88UgSRbA8ktPmP6/GLxtnkfTqch6lyHi9o8MvqTjqHW0yVyRW6tru4SdqEtMvGEm PuhQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s12-20020a63b40c000000b00535bf852410si211946pgf.313.2023.05.19.14.04.35; Fri, 19 May 2023 14:04:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229839AbjESUaY (ORCPT + 99 others); Fri, 19 May 2023 16:30:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbjESUaX (ORCPT ); Fri, 19 May 2023 16:30:23 -0400 Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 761DEE0; Fri, 19 May 2023 13:30:22 -0700 (PDT) Received: by angie.orcam.me.uk (Postfix, from userid 500) id 9DAEB92009D; Fri, 19 May 2023 22:30:21 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 8FB3392009B; Fri, 19 May 2023 21:30:21 +0100 (BST) Date: Fri, 19 May 2023 21:30:21 +0100 (BST) From: "Maciej W. Rozycki" To: Jiaxun Yang cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Bogendoerfer Subject: Re: [PATCH 2/3] MIPS: Introduce config options for LLSC availability In-Reply-To: <20230519164753.72065-3-jiaxun.yang@flygoat.com> Message-ID: References: <20230519164753.72065-1-jiaxun.yang@flygoat.com> <20230519164753.72065-3-jiaxun.yang@flygoat.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 May 2023, Jiaxun Yang wrote: > --- a/arch/mips/include/asm/cpu-features.h > +++ b/arch/mips/include/asm/cpu-features.h > @@ -185,8 +185,13 @@ > #ifndef cpu_has_ejtag > #define cpu_has_ejtag __opt(MIPS_CPU_EJTAG) > #endif > + > #ifndef cpu_has_llsc > -#define cpu_has_llsc __isa_ge_or_opt(1, MIPS_CPU_LLSC) > +# ifdef CONFIG_CPU_MAY_HAVE_LLSC > +# define cpu_has_llsc (IS_ENABLED(CONFIG_CPU_HAS_LLSC) || __opt(MIPS_CPU_LLSC)) Extraneous space and overlong line here. Maciej