Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp63369rwd; Fri, 19 May 2023 15:28:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4yLDlyGN5wjW3LS0Kb2tgMOQApSi6NCEW1X9M0+QLPtql6uA+tDG1tyBxvlac8TbeKRq9Q X-Received: by 2002:a05:6a21:9008:b0:101:3112:c839 with SMTP id tq8-20020a056a21900800b001013112c839mr2496535pzb.15.1684535284673; Fri, 19 May 2023 15:28:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684535284; cv=none; d=google.com; s=arc-20160816; b=TXH6Th5o0YPm+H+T7V52HD6AY1b3ymikq1DbNl75I+vQIXiS7/v0TFBPeVbWLhdg3f 1Xhm+ygR9RKCx5yryOOrt6KgUwQqIpA3BN1qh82Onb/GyRucQXm3oswcY1MdBeBrhKiI sYrEStxGJihT8J970L35rNOizaURvdl/q/MKAmnXlIothQdOiGhcyE5NrSq5Cg83wMCP 9dnTIpSk2xsyUWMn2ESpP66qAjxL8pA22DgEZ97r+nomCihdKvESahp7H9jnGzqkI5T+ JDgNBDyVdYxbO91y3cpyUcwE0w9KXE50ll1CAkO9OisOp2uPPdSfdk1VyACRvZvOUheB Xlgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=2M8Qy/bGAgxLNT+04Owjjr5jUyJqYgJChjPSDnOvG3U=; b=s2LrFMYxBBul7rH/z/rp6tfsZWlWsmrgDA0Q0ojmOdoUtFTIpD7m/IaUkQBqTiIFn+ zA/pt4ODypPOywOV79In1Os9Ed7e9xrDJZunR0Wpg0nrXqP/mH5P7wBNu++QP4SRvtTe qbGucuqkyohfIXIFa7QxSdUceH+ScqQgOjtijzLTJcC1E5A1jh4VY98I5pbLNrwlKT6H kKI583GAeIxcM96YssOXsU46OKd83827jvUwtNafnZ+HplIrMI+5lRnLgVyYCEBgez2a 7AOQ7A3k09l7xPGt0ykBD1M+sFG3HtL2aqinaYiTNvCCbUYkiOc8k2uFvJkjv0Mf1EwG Dk4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=nq13IB1c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z15-20020aa7948f000000b0063732344e2fsi298471pfk.190.2023.05.19.15.27.49; Fri, 19 May 2023 15:28:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=nq13IB1c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229762AbjESWBa (ORCPT + 99 others); Fri, 19 May 2023 18:01:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbjESWB3 (ORCPT ); Fri, 19 May 2023 18:01:29 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AA92B1; Fri, 19 May 2023 15:01:28 -0700 (PDT) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34JLvbYi032293; Fri, 19 May 2023 22:00:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=2M8Qy/bGAgxLNT+04Owjjr5jUyJqYgJChjPSDnOvG3U=; b=nq13IB1crg9fM9BXi3478aY8LGzKVxkL+XIFOyVUoTphnKIGlWauVLoxHGcDNsRpRAfD MDvgFKB7uFsigADdgVxsDxsnOqYnvwEV7jTjwlIZCXLw8iwUgkj13uwxGisqy83K38tB 5JV2wj8DLlezMGb5LX0lStdV738874vagDRXmy/4prcycXhfxrbyrtpMsc0REJBTUVCx kxtDpOfa8AlwWhRScdTV/txOACcDco0H/bex7V3c6bS2d75Bwri5FG5XDVbs5UwqE8pq 4Y+84uOFYm0b28iKMdOZF+R6DPpm/l1s7pWIrxkHCIopJQBbZiO5OnfKWz8al0VkA9mS mQ== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qpad1h8nw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 May 2023 22:00:53 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 34JM0qlm007656 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 May 2023 22:00:52 GMT Received: from [10.110.96.82] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Fri, 19 May 2023 15:00:51 -0700 Message-ID: <56ac76e8-e5ac-3712-1e07-ad6c5b96c77c@quicinc.com> Date: Fri, 19 May 2023 15:00:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v2] drm/msm/dpu: Set DPU_DATA_HCTL_EN for in INTF_SC7180_MASK Content-Language: en-US To: Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , "Kalyan Thota" , Shubhashree Dhar , Raviteja Tamatam , Krishna Manikandan CC: Rob Clark , , , , "Marijn Suijten" , References: <20230508-topic-hctl_en-v2-1-e7bea9f1f5dd@linaro.org> From: Abhinav Kumar In-Reply-To: <20230508-topic-hctl_en-v2-1-e7bea9f1f5dd@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: dlWzTMD1K9sgige-225FzMntVgVNF14M X-Proofpoint-ORIG-GUID: dlWzTMD1K9sgige-225FzMntVgVNF14M X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-19_16,2023-05-17_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 clxscore=1011 suspectscore=0 spamscore=0 mlxlogscore=736 adultscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305190190 X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/19/2023 11:49 AM, Konrad Dybcio wrote: > DPU5 and newer targets enable this unconditionally. Move it from the > SC7280 mask to the SC7180 one. > You mean DPU 5.0.0 right? > Fixes: 7e6ee55320f0 ("drm/msm/disp/dpu1: enable DATA_HCTL_EN for sc7280 target") > Reviewed-by: Dmitry Baryshkov > Reviewed-by: Marijn Suijten > Signed-off-by: Konrad Dybcio > --- I have cross-checked all the chipsets affected by this and confirmed DATA_HCTL is present and those 3 registers programmed with that feature bit are valid, hence Reviewed-by: Abhinav Kumar