Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <42654300-67cb-254d-22c2-4642a4763ba5@intel.com>
Date:   Fri, 19 May 2023 15:21:41 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v3] x86: fpu: Keep xfd_state always in sync with
 MSR_IA32_XFD
Content-Language: en-US
To:     Adamos Ttofari <attofari@amazon.de>, <tglx@linutronix.de>
CC:     <abusse@amazon.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Kyle Huey <me@kylehuey.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        <linux-kernel@vger.kernel.org>
References: <87y1ltbtkh.ffs@tglx> <20230519112315.30616-1-attofari@amazon.de>
From:   "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <20230519112315.30616-1-attofari@amazon.de>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1VCakNHU1dRZURFUnVhM3lJV1ZqU1RwcU5QMnpFS0M0b1ZNOGgyYTNsVGlT?=
 =?utf-8?B?M2RDTk4xNWN1RHlsSWFwRUdGQStBVmRVOFpJUWNkNkJlaGU0Wmt4aHFLQ0p5?=
 =?utf-8?B?cUU2MGhvQXBiZkJSdWNCTWdQaFhJYkRsNExaQ3Q5aUhaNWhtR2tBRmZ0T3dG?=
 =?utf-8?B?SnRvSEdwcGtHM0JYVGJ2QnphTlhWbFVBTHNSMk1Tdm9KcWNNaWI3YkFvZVJ2?=
 =?utf-8?B?UHNDY25uSGJBbDE5OTRZNWR1YzdmM0tieGlINC90RlRIT2NNZHNrTWFnZ2p5?=
 =?utf-8?B?eUFlM245aDFFK3FtN0c2NHlmakJGdElKVkl0cmhXOXY2MUtWc1BIMmJvZXZ4?=
 =?utf-8?B?aUh1SFpQOFdIbXRlV2Z4a1JGdUplalI2UHdObDFBY21YK3VaQ1FOMS9RZXRC?=
 =?utf-8?B?amZNTmZZQU56UFhOVi9vN2I3dXljZFh5cEI1R1dYOW9UaEpqVE1IWVBndTVW?=
 =?utf-8?B?WCtxK1BNWlJCM3dkZThFS1lJQnRwSzhkMVphUlpwVDFXMXVUNGo5ckxHRis5?=
 =?utf-8?B?NGlLMkhPTnRpQ2RzQXd5bmllUHBhUW90SnR4UTY3UFBDQjZYWlBXWW9ZRmNl?=
 =?utf-8?B?ZC9NVTVRSnNmczE5L1FmZVhmREoxRUpobUVIdkhRK0pKTEhmUzlqMC9XUWFN?=
 =?utf-8?B?QWhCN2R6SEZIWDM4L0FtNVFzRi9SdjdWWmxLU0crWVdPOXJ4azU1YjJSaVZ2?=
 =?utf-8?B?ZTFrU0hXRml5eXdrMWJGbDdIUjYyZGhJZmd6aHRmeVBrOXFoUXZ6QlRJL005?=
 =?utf-8?B?V2xCL2QyNWhONzVGTXFiSjBwVnJMT21ZS29IeTk0NndvemJDZ0FCNjZEVUtG?=
 =?utf-8?B?SmU1ekRGV1dpcTNUbFhqSVA2TzZXM0NIS1lMc2xFdSs4UEJOZVVINlZzcnd2?=
 =?utf-8?B?S2FyTGdKMWFXNExWSHMvV3pzRGw5SjRUME02YmpwUU85MDUrVVVLQitTZ1JX?=
 =?utf-8?B?QitXdXl5Y1hJMFRnSkhFYmlVdXRuUW82RUphWVpwaHJQc2NYb3pjYzd1K29V?=
 =?utf-8?B?WHI0TkNXcnRVOExnZFprTVRSN3NqS0didzByUU1scy9vb2RtaE5VL2tEanVp?=
 =?utf-8?B?Z1EwbjE5RGw4RkNORHJsSmN4SzBOOWgzOVhHckh2T1hhSXZlKzFBcFJjSWVO?=
 =?utf-8?B?dGV0SVJJRmVBNTFKUkNaWmxodTZFUFdPVHJtV0JRUVMzRTJEMjltWkxaRFd3?=
 =?utf-8?B?ZGlsdm9wYUlBeENONDBJK2hUK24yU1JmOFlTOUdsTmxyM05jRTlGanlUcVY3?=
 =?utf-8?B?OGtNejRFcFIzMEdYb3R4YXpua0tJQ1hXMUtDYnU2SWtTSnpXMGhYMXFUb20x?=
 =?utf-8?B?d1JmR1BxZkNjL3FLUUJEcEZOZ2VNQ2Q3QmdKN3p6Y2sxR21QWVRHa3M0Wkla?=
 =?utf-8?B?czNtaVJWRjY0SGtkUEd1UU5YQ3d3Tzk4RWNSMXRyZktPd2FUeEs5ZVFrbGJ3?=
 =?utf-8?B?d2EvUTdEcEt0L3d1Ti9ZYWY2SmhXYlJsS0lnR2c2OUUrNzhFUzBDblI3d2Q3?=
 =?utf-8?B?MFlrL0hOeUo0eEk3c0FSQWhVaVFFazBlS1NjclNTVHZpYWlSR3hQZktxMUVU?=
 =?utf-8?B?ZWRWcllKY2toZVA1ZHdOR1Y3a3Y2b0dUTWRKcytVSUJQMnBhT3hlUmpQQ1Ni?=
 =?utf-8?B?Qks0bTVRVHdRR2xyMVQ0MkJYUnNla0lOTVgxYkVyZGRkSHJidUpUZWFwZndz?=
 =?utf-8?B?M0dlZk1UYlE1czJXc2Y1UWltOGNicExaaFllaG9IdTV5dmdzUkZvSExCWFl0?=
 =?utf-8?B?NUdQTXJ5ZEJpTmZQUFRpWGk5di9JYWhIL3RSSCtwUHUwMlpzdmt0UnhrUjVP?=
 =?utf-8?B?RWV1blBqRzgvdUNDMGNHQ1lDbEhYaE5JOERUSEh3NEVkWE1sQm1remJlY1FW?=
 =?utf-8?B?QVdYZ3dsQjE4ZVNQbTlHM0o0aDZFQ01aTjZaa2pOSERsSng0aHpYYXFEZ0ll?=
 =?utf-8?B?UlhkdWUxdWVIT0lhWmdZWE1COFhaMHpVYXdkem82QzU1aXZPamtsWkwyeVpZ?=
 =?utf-8?B?VEo1eDk5Y2poalUrV01ZRDZkUlg0Vi9OOTlFU2o2clZQUVpjcTczMXZLSmFs?=
 =?utf-8?B?bVVJblV0ck5mT255STJYVytUT0lqWkMwcmpaM3RaeXJiNElzbjdMU28xOGw2?=
 =?utf-8?B?dHNiamczSk1VU0ZWL3NWWTRNTmdneERPZFMvOUl2NXdqdHd5MGNXV0h3S1Fj?=
 =?utf-8?B?a3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f218175a-1fbc-4a17-4e68-08db58b76caa
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4855.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2023 22:21:43.1089
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5d/OH8YCGzduFgR0sErOwKteTxFHYUYcjjN2Jop3CauwDwKiMaVIULsRyKPIWZXOG/jsXhHyMlVUg/LhtqmfMWtF3oYmnvZCSuokd1FG70g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6203
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/19/2023 4:23 AM, Adamos Ttofari wrote:
> Commit 672365477ae8 ("x86/fpu: Update XFD state where required") and
> commit 8bf26758ca96 ("x86/fpu: Add XFD state to fpstate") introduced a
> per CPU variable xfd_state to keep the MSR_IA32_XFD value cached. In
> order to avoid unnecessary writes to the MSR.
> 
> On CPU hotplug MSR_IA32_XFD is reset to the init_fpstate.xfd, which
> wipes out any stale state. But the per CPU cached xfd value is not
> reset, which brings them out of sync.
> 
> As a consequence a subsequent xfd_update_state() might fail to update
> the MSR which in turn can result in XRSTOR raising a #NM in kernel
> space, which crashes the kernel.
> 
> To address the issue mentioned, initialize xfd_state together with
> MSR_IA32_XFD.
> 
> Fixes: 672365477ae8 ("x86/fpu: Update XFD state where required")
> 
> Signed-off-by: Adamos Ttofari <attofari@amazon.de>

Tested-by: Chang S. Bae <chang.seok.bae@intel.com>

With this test -- which I may follow up to be included the AMX selftest:
https://lore.kernel.org/lkml/6ab71997-8533-1828-7c62-717e2821f147@intel.com/

Thanks,
Chang