Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp87411rwd; Fri, 19 May 2023 15:57:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7cAvZq+A9n/h0mXNmDuoC3iZ7yHTrW9JEGhmersb/O1To4C8A2MHDMP4wDShmWJBy4o8uv X-Received: by 2002:a05:6a00:2291:b0:647:4dee:62b7 with SMTP id f17-20020a056a00229100b006474dee62b7mr5593771pfe.29.1684537047742; Fri, 19 May 2023 15:57:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684537047; cv=none; d=google.com; s=arc-20160816; b=p8oNrI8gyOXJpEmwuPGZJF1sDIKxXHpUh3WzAwVaMPi7s2qrR2veV+WgrzKv3rphEK zq8NEgUJ7wQnYbqqMmI+ns7iedtdPckOpoSPPiS2Ingrenl13Vht9/8nasvphxK1RJ5f usexJm31noi22oFGlCjcLk832fpr/FfwuGYmy8sYYlIJUSWZRoqkX1kicx60Ik+uQLGQ 16wzZPbW2jJQa93zJvJTpGQ3zpnXRucgSLtEndYuz6QPPNy4affUAKkyD0CX9TY5qEBg x0M8sjStl88lqhXXnATpOMBwGDG6YKRPtojLeYicIBmLlMedT1FNpW5JRdpjlZkYZuU+ VGcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=U2g9A9eipVjHxvb+cv/4sEXYwktwOF0vhX6rg1vyxK8=; b=iMrOjHMzrlsH5hIHqLFS9/8K/klW2TKJIsdfrTmafnVf0nbOm/RHEXrr8V0qqQHS75 GmCnuIc5VQBq9g/q1i/lmGyd3Jy1AXGp2g2EESEpIXrFfmtSGNn2HEwalWROWdJ4C/dj /wOVXpuMfcTwAg7D/bTXxjNlAL416i6b/+ebybFfYI5Xau35mLwxiiAUea6rZT15ovx1 CzxSTIt5kE/Gb5SIjTRuYDMxLEqaW6WN6NacDv8YZjb7E5+1ios/4aPolJQWJ4pEHivK WL64+5N6nDtD/vKcASFU/3NHwISURRWkqCv4WGqZXSXNvJJ3EGZlEiAZLXgrE4LZC1Ei dERQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fjPLOWfL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b126-20020a621b84000000b0064d33dd541csi353092pfb.108.2023.05.19.15.57.14; Fri, 19 May 2023 15:57:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fjPLOWfL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229933AbjESW2L (ORCPT + 99 others); Fri, 19 May 2023 18:28:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229595AbjESW2K (ORCPT ); Fri, 19 May 2023 18:28:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44B97EE for ; Fri, 19 May 2023 15:28:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D498D616EF for ; Fri, 19 May 2023 22:28:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E23F6C433EF; Fri, 19 May 2023 22:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684535289; bh=kHtJttk0IvKNpeBTTCun9Kaxe9mpk0uKJbFMu4xbEBo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fjPLOWfLnh+YUZso0agkMdGAZir6v6nV/SrtAoiIwmSXhkhEz/FeEuTojZV5BbnPM xCIvyJdayyv8y4OHd1E2WJ46Z4RC9+FGstF2G124fSkQTJhZWetm0hjFjzRXF3V2gt 2BRLX6+LhW1kwD1KTWzkeOxw2fRU1DTSyNRWM7wfV99ZalR8t0B4Cqz+5XOfzOmgfz NEXnwc7TwkiLmnpM5TIxiH0cgPylLpFcsTbogVuDBsPO73ySzLbgao2cnYIA8mzcvj a4+G4l6DjOJ6OwrSJ7RbWzd7XyYfgmqTdZQK2p8lRFod49RbJYyKwKIF2sLYn1Y17c JbJTzMI5Io2bg== Date: Fri, 19 May 2023 15:28:07 -0700 From: Jakub Kicinski To: Min-Hua Chen Cc: Nicolas Ferre , Claudiu Beznea , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: macb: use correct __be32 and __be16 types Message-ID: <20230519152807.57d3f4c8@kernel.org> In-Reply-To: <20230519221942.53942-1-minhuadotchen@gmail.com> References: <20230519221942.53942-1-minhuadotchen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 20 May 2023 06:19:39 +0800 Min-Hua Chen wrote: > This patch fixes the following sparse warnings. No functional changes. > > Use cpu_to_be16() and cpu_to_be32() to convert constants before comparing > them with __be16 type of psrc/pdst and __be32 type of ip4src/ip4dst. > Apply be16_to_cpu() in GEM_BFINS(). same story as with your stmmac patch, the warning is a false positive