Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <72c3d1b1-69de-b91b-09e4-08875a3602d9@acm.org>
Date:   Fri, 19 May 2023 15:53:06 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v5 2/7] ufs: core: Update the ufshcd_clear_cmds()
 functionality
Content-Language: en-US
To:     "Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
        quic_asutoshd@quicinc.com, quic_cang@quicinc.com, mani@kernel.org,
        stanley.chu@mediatek.com, adrian.hunter@intel.com,
        beanhuo@micron.com, avri.altman@wdc.com, martin.petersen@oracle.com
Cc:     linux-scsi@vger.kernel.org, Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        open list <linux-kernel@vger.kernel.org>
References: <cover.1683872601.git.quic_nguyenb@quicinc.com>
 <91bddbc5945a7a651bb1edc35ac5ff54a20bf6c1.1683872601.git.quic_nguyenb@quicinc.com>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <91bddbc5945a7a651bb1edc35ac5ff54a20bf6c1.1683872601.git.quic_nguyenb@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/11/23 23:28, Bao D. Nguyen wrote:
> In the ufshcd_clear_cmds(), the 2nd pamameter would be the
> bit mask of the command to be cleared in the transfer request
> door bell register. This bit mask mechanism does not scale well in
> mcq mode when the queue depth becomes much greater than 64. Change the
> 2nd parameter to the function to be the task_tag number of the
> corresponding bit to be cleared in the door bell register.
> By doing so, mcq mode with a large queue depth can reuse this function.
> 
> Since the behavior of this function is changed from handling
> multiple commands into a single command, rename ufshcd_clear_cmds()
> into ufshcd_clear_cmd().

Reviewed-by: Bart Van Assche <bvanassche@acm.org>