Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 19 May 2023 17:46:35 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ira Weiny" <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        "Dan Williams" <dan.j.williams@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] cxl/port: Fix NULL pointer access in devm_cxl_add_port()
Message-ID: <6468186b29617_682c12948c@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230519215436.3394532-1-rrichter@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230519215436.3394532-1-rrichter@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KM2m6ZQDxNqLqbqNcg868ZWjd0E3VaS/M/5oqONzv5vr4PrXLD/Q81RecYR6?=
 =?us-ascii?Q?sXKHFI8SEYzap9QA7ei2WVbEnRXlqBZ+TIUUuLltMTKKfZz9/MoAB4eM+Gar?=
 =?us-ascii?Q?0/W/sDUcA8POvIDZwgROaNKKL+iib1C4gu4cEHA5XA8+Is8A/LQ5CDmgc1Z1?=
 =?us-ascii?Q?JKVTl4Z7wg62biLAc0x7hR+EgwQOrZM/gfFSFtxZkUIzgWYHB6QOcYUF4LYn?=
 =?us-ascii?Q?FEBePtH62TYNlDO5XYXmriwPbPTfm0SnHsx+8qT9Fz+3XWykHpejayXSmTmp?=
 =?us-ascii?Q?Ni7JgNnhpjOhSmYONpuy4EosdnKJWJ37FSxQ2Mfs5boAy3/PkSENu56I43UU?=
 =?us-ascii?Q?+7Dpu2lIUIc84R2NA7p6XBLYqcKvky2A1IM775RpHRvgWoMGwXMZpZwWPHkL?=
 =?us-ascii?Q?v43iAcgtOsWSXdf2lxPC6gWgxt366VFV1KLiGozV4SkHr0zEW3pvc8kdPXGz?=
 =?us-ascii?Q?XVCk+EU62MZI8VCp0PjOfqIt2NUMyBJc7BAgDXRhehYlNEwqV4eWEdecD/88?=
 =?us-ascii?Q?IT8JyW42fn6KzzxjIxeMNW8RINfOLb8UOJ/6YVu7fyWSDoU0IY6r/7ZBMtPD?=
 =?us-ascii?Q?yzL0KazLvlhHzMd3w7TJEux7bkhfLTV6+Er6n0x22dumHVIuWtuqMHH77mtb?=
 =?us-ascii?Q?ku4KL29x8hdxTFRPxhTQuMejF13N4m3ghPEbNfzLbGox2mmLmIhtyxyTdRTl?=
 =?us-ascii?Q?IAqx7WRJ2CWlrAMb2mDuAR1uyjDMfAO2LGb6wngx8pAQCRBHlpGhtr6LP3gW?=
 =?us-ascii?Q?q+T5Ybg2c91nceQ17EyqxjaAQiGVvNeIn5Tmxj9eFoxNwWxt6lssZDd/9X1g?=
 =?us-ascii?Q?RCpuSxzxxKCpHV8e+8hlaXaqIrv/11poWJ4Jdw8H96X9FOFMqCV91D9Ajer9?=
 =?us-ascii?Q?RMmje+TLzVVadYoFxoqWevkR+2Ven5D5BuHURywOXWiggujuLDUsWZ+Y2jzF?=
 =?us-ascii?Q?zqFOWPTH3tcI3WHXY4cR0WO9xGhz0KybMtnOl3dqrVMWiYLx3e8V+ZIBmjDB?=
 =?us-ascii?Q?DXjijen5yLY2Z7F3V6w0CA9CjFiDAIeqfAW24WET4C8tfHGPjEIoeD9Tj+wX?=
 =?us-ascii?Q?ZoEJgNk9b6vfSdxGkvrppi7dR5JUSD87Twgl1QxiFw7I3Q+RlOW0QcbUxjR/?=
 =?us-ascii?Q?XM7AT1NCAq0xwLfx5YklHPSFoRNUjfDWMk1BLwnKWaRxPOCNk+TqtOsPXYtA?=
 =?us-ascii?Q?OYMacYLm2c/gerawwXJjN/GDiOfN5Nm6iVKKAB2/c43i8TqHgHhjWNwIqP28?=
 =?us-ascii?Q?snZ2dAbGt2Id3mCpRavHfacY6GsnaaI0GpICn/50WVdAMY6ItV11V2H7/6rI?=
 =?us-ascii?Q?rfJUAHEQds1nk7psdxmr27ofoAGXxKXtnoh5CiSudER56pOd+F4xh/G4DbgH?=
 =?us-ascii?Q?DVl+4pvMr0t5zpGkyJpuKIa6chC9wna3R19sqa0bWb0Vovfe9XOQacwc0otB?=
 =?us-ascii?Q?lBC6hZmnFNFkecc0YMkk/rSeNAo/qo3CQMBH+O26GvSHSND53cnjBoRmkd5g?=
 =?us-ascii?Q?211ryZ9C2WpmhKWF/of6Hs2yTudptrT9GmwBWlpDXl7BphXwKo8/Wp7z5rp6?=
 =?us-ascii?Q?yw/zu0sExk4N61E8UONvBnn3h3sJCn3Sm8KA0hQbzV2HSMsw/S27Yaoca+eG?=
 =?us-ascii?Q?/A=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a5ecc31-1080-4986-3181-08db58cbaaf4
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2023 00:46:37.6939
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rflr/FEWGHDoy+BfTsn+r/YS+sfqRlVXQbP592qMjSDSuuSw6PUZAopJkwpnJCW0WIplZmF73QezXi34Zw0Gbh9VLW4cSC5kBalQml6eqtM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8498
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Robert Richter wrote:
> In devm_cxl_add_port() the port creation may fail and its associated
> pointer does not contain a valid address. During error message
> generation this invalid port address is used. Fix that wrong address
> access.
> 
> Fixes: f3cd264c4ec1 ("cxl: Unify debug messages when calling devm_cxl_add_port()")
> Signed-off-by: Robert Richter <rrichter@amd.com>
> ---
>  drivers/cxl/core/port.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> index da2068475fa2..e7c284c890bc 100644
> --- a/drivers/cxl/core/port.c
> +++ b/drivers/cxl/core/port.c
> @@ -750,11 +750,10 @@ struct cxl_port *devm_cxl_add_port(struct device *host, struct device *uport,
>  
>  	parent_port = parent_dport ? parent_dport->port : NULL;
>  	if (IS_ERR(port)) {
> -		dev_dbg(uport, "Failed to add %s%s%s%s: %ld\n",
> -			dev_name(&port->dev),
> -			parent_port ? " to " : "",
> +		dev_dbg(uport, "Failed to add%s%s%s: %ld\n",
> +			parent_port ? " port to " : "",
>  			parent_port ? dev_name(&parent_port->dev) : "",
> -			parent_port ? "" : " (root port)",
> +			parent_port ? "" : " root port",
>  			PTR_ERR(port));

Looks good, applied.