Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp314278rwd; Fri, 19 May 2023 21:13:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5467/ycTaGrteaavPrlegSJeM0WjRleK6a+dOU5ZDuAlgI3TbZUyEpZYVsSSFgH0MGw5cu X-Received: by 2002:a05:6a00:1f05:b0:64d:411b:3a0c with SMTP id be5-20020a056a001f0500b0064d411b3a0cmr2002302pfb.14.1684555999768; Fri, 19 May 2023 21:13:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684555999; cv=none; d=google.com; s=arc-20160816; b=LhMe8B8YY+NVUJ2rcBWimRqXumGRfZfGL0VK1j9hEqxPE4rCQSLJdUuipDtCQJClNz CdrTe2YYVgiE3MCeKbpAz4Hrkw/Jr9FYsJPoCAxG3DoiV+1EAam3nipGfAtpGGXmIRC9 b6iHS5BY8vGgnTKoDBeAskKBoBwCLk0r2fYT5p6CSL78XYGits4n9ECn2EudqxfoE1rr ldd3PuPUDtesflHS6xfHn/0a/FyzU/pzepKHV1rPgqEVKmnuZA8XERZWR5n/eii+juqf kBEJOJTqs9gO8vyEnh3ui8dyEu2UeAyqKrkNEXXTn3v2fF/6/cj/2JLVnL56BNkt65Fl VB/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=bfqk8ug2l/FprVhErVtGXC4A4aWGvcfhCi/tGA9QvMP25EIu01qfdTJZOtDVMXPOJg uFCQOrLXy0gXqTXGE5GuTmhCqmWxmcHJH0JVn6mQt55Emket9ZAYLwRjzZCZLB2952oc 9esa2lu9lHiJS7AVf87NuUSg8DKpYcBlO0fjbQ1rWd5z5SvWMOk+Bk0kvHbC5jstZgD7 IXcby1J00DGeUTiW+rgW/WIXT7HYWWjXz/EFKsCvY10HiM0tQLGmsE3sAfCrZTsqE0O7 bcvWxErVexeYXWwXVWr0Ehai8EKygrBzeVR04lbXh3v7GsN97em6tHVZ/GH2SXYpAl5y ibMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Pt+PQf6v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q23-20020a637517000000b0052ca719265dsi695381pgc.874.2023.05.19.21.13.07; Fri, 19 May 2023 21:13:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Pt+PQf6v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229508AbjETELY (ORCPT + 99 others); Sat, 20 May 2023 00:11:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbjETELW (ORCPT ); Sat, 20 May 2023 00:11:22 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB7FF1BD; Fri, 19 May 2023 21:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=Pt+PQf6v4zSblP55GrOTDhqctX Mp+y8puOTxwgbvkh7yzi1Zxb6L8eqHWgOmYIBki8oDPw15gwj5EZb9c65zH+dlVlCZsH1VD26uc++ 74cwKZW/BY2tuoIklce27ktMnMX5BxQt+a383yYp98C2Czps/vEC9j7q3RypCqBy8KidJp61DwbED M5iG5GV+kwcuUjYl+78htXNTchWV8SOynSeNQNAS2ttnxFtx3rG6PG+IIJXONB8yg+qtLDL/bjgi+ MlIOl0NJdXEkCANBg4WFNPIs32TnoVar+smRiyVs2irvReXw7RqLKpI85m38mf6Mk3FOte47LIBx0 4sSz2vyQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q0Dvz-000dLD-12; Sat, 20 May 2023 04:11:11 +0000 Date: Fri, 19 May 2023 21:11:11 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH v21 07/30] splice: Make splice from an O_DIRECT fd use copy_splice_read() Message-ID: References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-8-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230520000049.2226926-8-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig