Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp316018rwd; Fri, 19 May 2023 21:15:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ42MjxiiyTlwVbPz2W5FEMARdwaKgad6dDmAlBE24nmn715ZaGjTzjGQKPn+UdIKwl5ROpv X-Received: by 2002:a17:90a:8982:b0:254:ce9e:53 with SMTP id v2-20020a17090a898200b00254ce9e0053mr1439332pjn.23.1684556153869; Fri, 19 May 2023 21:15:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684556153; cv=none; d=google.com; s=arc-20160816; b=Ps/9YHzgaj2SKDUi+7saFIh3qfeSXTWiYUDqlTXm/s/hNzzRinhZS6k2S952jGfunI ndxLND8MRTsd/18IwkOimV9lHub35/cbsN8YM3yqTa8DBRdnwF05BmudG4bofpMCXKv6 cbOFvWdqTYhIoVBHrDRNEsDqdAV/7eWqIZnZAQADXPP40gAvnTTOA+at9PDxxcHreYSG Pfbvqwh+EbYXgPlMokFB/94ZHvz/afxTqyz8APseM9GXOZFk8mzt5U6Cm6S8aQKHkHpO VOwbsv0QXMgvw6swur6QOztG6tk6KaL6xflxeSCkRgJXzxFwCCTKwUPsrWBNrjBuymla oD/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Xi4OUwMjj6B5meDIABpjuRK4Kr+q2y1yEM0f2xLNo2w=; b=DXmSbBjbbjH8FqAr90CDZmPsABd3IYlkb142NVKPIeO8dfbbMs+6Hzl3/68l3cLSRx Zs3eXnvRi/GjUkEQWFYaDONIK7VeCCyNLA7I3IZOe+rN1penjdJCaQP0m8TRtTe70hS1 LZNPRtOqwiBMHDwn/x/3aQVU4SV77RMk7h31TFYw/60rQ2+dQux1nf4Zt9noJnGHhjpL HbvcMwTDpu8jbx5SS8RUYdBP+LGtyBD2N39vrqEUBn0A2AWR4Q4ybfI6SKaqUMbl/1NA 4FvQguHLIk0w6V0z+rQonG8tjOVzT28EZUeuF3fQ4NZHlgQmae/YYyU7CWD0a1e0e2Jv DG5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=w3ZGmsdU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h15-20020a17090acf0f00b0024e35ef410fsi678501pju.131.2023.05.19.21.15.41; Fri, 19 May 2023 21:15:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=w3ZGmsdU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230489AbjETENy (ORCPT + 99 others); Sat, 20 May 2023 00:13:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230166AbjETENw (ORCPT ); Sat, 20 May 2023 00:13:52 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C341E46; Fri, 19 May 2023 21:13:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Xi4OUwMjj6B5meDIABpjuRK4Kr+q2y1yEM0f2xLNo2w=; b=w3ZGmsdU8hhe/7c+F8CRKXYNfw HhUo290wLcW0X+8ICvnQxtdMgPwpdGPH94AWRSZbCcEYiunEnXAdq8yIO71PNcxyf2aM2I4h07E/Y n1z9k6gW52OG/wtRTNmIm3iHqjvM10Y4XqmuF93RrnWf2IFKfJUWRj8NCzgAsSCmKEcyQD/AiFsbj K4l07RhpT3hk2C8/G89ne1NO2mAlvTK7bWPHFGMwnLzM8MA00YNd0XVAFOJ/HRb6GHIBjboyNCZJ8 gMrpPzrylB7vG3yRmmKvsL507SXFpiYJy4pmPl/OWzpWgIDmEQhhi3b+j1hoqDmATrLPuWc0Tlaiw lQzoY4rA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q0DyQ-000dg9-0X; Sat, 20 May 2023 04:13:42 +0000 Date: Fri, 19 May 2023 21:13:42 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , "Darrick J . Wong" , linux-xfs@vger.kernel.org Subject: Re: [PATCH v21 24/30] xfs: Provide a splice-read stub Message-ID: References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-25-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230520000049.2226926-25-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Same comment about stub sounding a bit weird as for ext4 and various patches not in my area, but the changes themselves looks good: Reviewed-by: Christoph Hellwig