Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp336209rwd; Fri, 19 May 2023 21:43:47 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4/8TgMzHcF5tRAzsilxZSLC6cEiFrj6tghuWJAwXlZd75N84AIaeASxNiU4xwAv1WOQwx3 X-Received: by 2002:a17:902:ed42:b0:1ae:2b94:7016 with SMTP id y2-20020a170902ed4200b001ae2b947016mr5037006plb.55.1684557827535; Fri, 19 May 2023 21:43:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684557827; cv=none; d=google.com; s=arc-20160816; b=yQGXN7Ua4MsQjI/CWKOKku6nZ1rz6RFvq/CiSMDmcIjCjL3bmpiVIxEEqVFg5V5g0r 1ZJSC28GQEew1N8DEQtUp4raLEjewhc2XBZXgfgnSdzXIDLVHn23X2bb+juEW1QPKyOj Q2ImuYDogCrzOovRcUfKRI/j/mamUMAEcts7OMPr1oGy0vSH9t9CNG25mAxbRzVCXaTN nEc7O8G6b4Tbk1NBJtRJLby88INWkyEU/LHNOBXixAn/j81bOszBYZwCBYd+sZXCdnYr s0e/8Ikele4UoXsCxFTB0PHtiwJR1CpQTcDeDGAnm4ImXs4s3LaRfhPhNeJ7SMsm0Oah XDww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yZFhIbzIAbDjOjqaC2gJ41t0fKFRC84t5Mh0oNaInpA=; b=rgK9gziGH0A6nrrO49JHP9pEZfanSg3gpyonClnCTpiNOfoPxaqrALeYZ2cw0hh5PQ LYvMxeG7d7HDaQlM/wAKXVgw6+NzG57sdiJnGNAHGn9Tphgvau2PQwNFfBHY6+N8AE4i QzG8gNl/S6cELJDp5H5R04y/CtX9n82iKAytkxu0apQewZ54VVPX0M+wKfw4aHe4/SgC P6LW9cu4E/AEB1JrxfOd0IS96uISn27VOY3y98E6TmkOf6ztcL+Shcv1dngqp2KpmmlW 5oVFkP2R9fzRKa6uilefLgrs9U1lAJg9avUkw5iP+qLUdtQikPsFfzuwHurVxO/oE1a8 dY7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=e77ULArP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l8-20020a170903120800b001aaff9c8dd1si739717plh.427.2023.05.19.21.43.35; Fri, 19 May 2023 21:43:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=e77ULArP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230017AbjETEJE (ORCPT + 99 others); Sat, 20 May 2023 00:09:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbjETEJC (ORCPT ); Sat, 20 May 2023 00:09:02 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71B961BD; Fri, 19 May 2023 21:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yZFhIbzIAbDjOjqaC2gJ41t0fKFRC84t5Mh0oNaInpA=; b=e77ULArPyamKj4X1q2fKH4IGp5 pa6kfWTPi4lk6IAfUa6PsdL/5Re8RhOUZk2CYGko/0Yp581+AC8tQ3wrPatKpNvBA8mQojnq183V0 zLcqArXwF5YPc/A7iK/U9M6I+Me9xXwUz7tROq8AMOcwckuARm3kuIiyMMYDP/8u9C7uU4zx8y7Cn +8SbMmz8hoWiF3/II5+VKBk1cs6+3i5hGsBJ/dVShUhpxNsXiFTcG+wFaSTXQhb19SC0ybOpUK+qV VrPMepu3ZEqYvCfsBwAO0QvJo8xc3RU3GQlA8cc3lBKRIx4bLp1F4c/tZ95M114zjVxWuRqYN7fP5 0vmnNY0w==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q0Dtf-000cqF-0G; Sat, 20 May 2023 04:08:47 +0000 Date: Fri, 19 May 2023 21:08:47 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Steve French , John Hubbard Subject: Re: [PATCH v21 01/30] splice: Fix filemap of a blockdev Message-ID: References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-2-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230520000049.2226926-2-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Just noticed this now, but filemap of a blockdev sounds weird. Maybe something like: splice: use the correct inode in filemap_splice_read might be better.