Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp397778rwd; Fri, 19 May 2023 23:08:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ79aTbVQsP6krMjV0yUv4uOMGsJ5bFkkK7kW7aFbvNQffGunyMtKYmwdQx6K9hTLxzxTGas X-Received: by 2002:a17:902:e9d5:b0:1ac:8cd4:a82d with SMTP id 21-20020a170902e9d500b001ac8cd4a82dmr4238143plk.27.1684562897581; Fri, 19 May 2023 23:08:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684562897; cv=none; d=google.com; s=arc-20160816; b=b9f+mrcWwtk4ReJORHO0Wf8Qyqa4mqbglaPRvQzKc/GpXwX6AS6RmdGL1XctzolJZ8 wyPTxxFDJiQYVo7sOhW6lX9cfsWutUrt4LLkRRKe8fZK3FkyXOp/pVawSdAmh9JpZ4NA IenGy1+/Iwf4vdzaPbII5OK7XtK6ln4ldkDG/nwQxBWJx8gc6olwAD2Xk78KQbffyK0i 9hSqYLd4LA7N57qgGmJb8MgqBtkKEisODe7on9km0QUpDM63uT1QGmd24vJvMPR2nTG6 b4OfpCe0cSSou1zs96SLagJTVKwkucQgfLURNG+dRBEfotHjTXx75/EcHiIBJVcEKwPs CsAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=gfOMCDO+EpRcce+Y4fCgA+EpfItFwpyan/mWDxkdEYM=; b=UrOTopkQMA1NThDyi+3zFOvOH7f99Gotn9knM+LrR8UmKwVUpzIbnbLuSk+vttqPUT zUJVpSjbpaZuXpart88cpBlPm9ArFdqo0bXPMhP9Mr4DyUxeL4pIi3MgYgTUwevhx5Qz x8/uLrjjGc4+mwr+hQuAThiBVRlUPMOihTL3avZuZF5IZtwPO5Usotu8DHKVcXocc0rp D9nBYUfRkPkc7dKdnQFj4r2YMtSFL5hA1bHBXR9B9WUyfJ8WIzfenUG4GICxM5coEDKo fYjAzpNrlaWDkWRqjFDUs/gOFbDUDeSmOpfu9HDxLL40ZWdPsqZE3qAuHcQH4IYH1ZrR NaYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=DUhavany; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id az2-20020a170902a58200b001ac38646f0csi851476plb.27.2023.05.19.23.08.00; Fri, 19 May 2023 23:08:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=DUhavany; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229626AbjETFxD (ORCPT + 99 others); Sat, 20 May 2023 01:53:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjETFxA (ORCPT ); Sat, 20 May 2023 01:53:00 -0400 Received: from out-25.mta0.migadu.com (out-25.mta0.migadu.com [IPv6:2001:41d0:1004:224b::19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0BFC1B7 for ; Fri, 19 May 2023 22:52:58 -0700 (PDT) Date: Sat, 20 May 2023 01:52:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1684561975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gfOMCDO+EpRcce+Y4fCgA+EpfItFwpyan/mWDxkdEYM=; b=DUhavanyxeEQh7S9NTewgrT1L3zfybzlnHNbBSEOS/ABVyFaKwC1oOAF/twoAVoC+F0NCp ysKIs8YCQ2e00ythSeGADQjy9yl5qShN8KW5uS3tuX3hMMu0TPXaSeeoTNl16xOW2lliSd sl7iTb7QuUAiRxL3URwO7jI8rl0SHZE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Christoph Hellwig Cc: David Howells , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v20 29/32] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic Message-ID: References: <20230519074047.1739879-1-dhowells@redhat.com> <20230519074047.1739879-30-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 19, 2023 at 09:17:43PM -0700, Christoph Hellwig wrote: > On Sat, May 20, 2023 at 12:13:49AM -0400, Kent Overstreet wrote: > > I suppose this way setting it can be done in bio_iov_iter_get_pages() - > > ok yeah, that makes sense. > > > > But it seems like it should be set in bio_iov_iter_get_pages() though, > > and I'm not seeing that? > > It is set in bio_iov_iter_get_pages in this patch. The later gets > replaced with the pinned flag when we bio_iov_iter_get_pages is > changed to pin pages instead. Whoops, missed it. Reviewed-by: Kent Overstreet