Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp562617rwd; Sat, 20 May 2023 02:44:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4FXooPwPqM1OzeWnZWs4ExsmVCKc4qQcbq9SGfVFn8aZudSc8iqDjdScenkCtzF8DK9rmf X-Received: by 2002:a05:6a20:729e:b0:ec:6039:f76f with SMTP id o30-20020a056a20729e00b000ec6039f76fmr5953764pzk.11.1684575847618; Sat, 20 May 2023 02:44:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684575847; cv=none; d=google.com; s=arc-20160816; b=Kd+BX3vVfyqK/PIRYRhuzCIYI2gT4PhZO4oLuODGrnAgh+kyyflvrDDQqCKuFtR4Mk wnccP/UVCkuxwodiC+rSgDMx6ANBJVW4h6jTO/K3J09i6bJ0iN8ET9hO08hhu5zN+FVN GSpM+dWe1f3jybmBZD3y5GSLl0+Vqn0yp4NbEqQZ4nxkTlhgqK9Idu1Sep25KnmNqtJL ps+GDDoA/XUPllVzMDt7WoThh/ZKd10boSVdlOD6sHj8Z96u8SGcNmedqW5a+XU3NUw4 re781SrQBZ3p1+JIXJdQStdaSc7XKdGNLTKRBg9xuWesGJ74qxPUSmz4okoL9NKhn8+v 6YFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jEzzfW/+BW6X8f400olwT9od11h0LGb+qETCrXX9Ifk=; b=XCC/LjhhALBr4hO9T8bFivjp8ER7ZeO8kWGFqI5kY1Qnl4+pU69HNo8qIufGIIpErA SIhc3c/K/xvpYSQ7Ux5NJKgs2vzxh5gfMf1Ro5cJQSswv8yQB+5959WFH65dar+7goX6 awDgQS4T0dmNZgdk/a1ZSTEXZZx5wnyhKVcVQ1zJgxjYhjqRlqhoBZViGVqgasbPBGdA bheUerZbWTIUsxfpQTU99Xm8QywdG6l6VTvDGas//p+3DSU0q0xu2tXSJxLbhf8zTKkN v0WHf0IMvaxJFv/79UZPgfdHpii71c2sjkTyiAy6gGTLtgQJZCteAhTKCN7xmVDun2i6 Jehw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="RAPmH/yM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j9-20020a633c09000000b0052c9d173ef6si1230269pga.852.2023.05.20.02.43.54; Sat, 20 May 2023 02:44:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="RAPmH/yM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230501AbjETJYE (ORCPT + 99 others); Sat, 20 May 2023 05:24:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbjETJYC (ORCPT ); Sat, 20 May 2023 05:24:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65650DD; Sat, 20 May 2023 02:24:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DA917612CC; Sat, 20 May 2023 09:24:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD5C9C433EF; Sat, 20 May 2023 09:23:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684574640; bh=FFPbZ3z2xMFOvvvYRV1x17BLaHWEDR97+KmJW37OskI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RAPmH/yMHP25Gv2fr3UImPupSiMpL5tbGmUZ6VmgCogyV/6Y0dqZ5EQo0tpuW+Z6B Jol/bp4CLE5jweReox9fiHxD4+AT4ioE4L61izXq8+abqZbXgwVaL9bHxoQ+PA+WNB /hxZnHzVN+BJkJpPYJoYWaizdrisaLF/k/ZhmMO8Nuu6Wn63pnfPrdyTIO6eynkWlv x/ci5te4g0yBYIQ9WcNKKUP1krUgho7pND81ci9dH8ygmp4O6+HhHyohuWgfpdX5re R25lkOEDb/kfLWuhhs3GIRF1ld0ZptvnfrEUygTekzGa30pBP8q4v248/V0Xu6ouAx HtPxtNyfM0Qgw== Date: Sat, 20 May 2023 11:23:52 +0200 From: Christian Brauner To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Steve French , linux-cifs@vger.kernel.org Subject: Re: [PATCH v21 03/30] splice: Rename direct_splice_read() to copy_splice_read() Message-ID: <20230520-sekunde-vorteil-f2d588e40b68@brauner> References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-4-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230520000049.2226926-4-dhowells@redhat.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 20, 2023 at 01:00:22AM +0100, David Howells wrote: > Rename direct_splice_read() to copy_splice_read() to better reflect as to > what it does. > > Suggested-by: Christoph Hellwig > Signed-off-by: David Howells > cc: Christoph Hellwig > cc: Steve French > cc: Jens Axboe > cc: Al Viro > cc: linux-cifs@vger.kernel.org > cc: linux-mm@kvack.org > cc: linux-block@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > --- For the future it'd be nice if exported functions would always get proper kernel doc, Reviewed-by: Christian Brauner