Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp566545rwd; Sat, 20 May 2023 02:49:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5qnSf4udpvwkAoincnzpr6Brn98iCUbaZyDlWgDukaTsNI5xRNJSzxUWqm8uNrzOE/e6hA X-Received: by 2002:a17:902:ecc4:b0:1ab:528:5f85 with SMTP id a4-20020a170902ecc400b001ab05285f85mr6561344plh.59.1684576157781; Sat, 20 May 2023 02:49:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684576157; cv=none; d=google.com; s=arc-20160816; b=yoXMLE3zLxUlO8OBgvNAl2qbzSPuesg72e9JTaNTwm1B15HCI8gesGKQkiw+ZpmQUt 4igcpc/LM0HKIZx3l6xtOgvJb/ZppY80O2+kKs2Hq2Etj8Y8uO375Fqs6Fx5jT/+nvDF VndgYOlzykYPJQfBr4j1ijwiU3IMieYsKKwKZYgSSVyMVpFU/JucAsV5ibUNDay4y9Iz cbhxwIwsYYRYwF8gRSQVgUP0fX1e9nIWOykxtGLnBUcyd4dka+Gvde5ig2rZjaqtHXOc Y4SzylyQwGXII8Tw6WmjqCknkNehYglLMlYwfkRni/Fcfm6cH+o+4ziAWkFFsnddaIBp RQBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ufv8ZDbnqCL6C1QNtE0DARESlHUjZDcH8OZ6wUZMBII=; b=AG8yZjDOaFRYvTa6Bs/Bn95+7anfpqymPK6oKMGAYfu/Sl5WqzF9huWhf8C+gSE7dh gQF+fBBAf/z2FTZ3viQGdAf5GYCmkBqXGGRqZJgOHaf1H9rHF3O0/FMRV6xm0yl8OaaG jeSrabOHrqXByFtIwCAZ0Xt0X8AIACNaNHQuwLgq0MTLi72qNBAX03EG3NGMwJ4akBU3 Uay6t1ot27uHwzvNesmDcvX/I6FA2921YBWeVxhW48XS1xqz0BByQmc92T7WtH17kGkI fOX9orNUKQVqzj0Xv2ePmc3j/tiwOghs9R48ZF1gLJYo2UJBSLpJymmaPV0lqldxPy7J 5DRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=C5yabXkE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z5-20020a170902834500b001ac78ac2c9csi1106273pln.573.2023.05.20.02.49.05; Sat, 20 May 2023 02:49:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=C5yabXkE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231348AbjETJjh (ORCPT + 99 others); Sat, 20 May 2023 05:39:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbjETJjf (ORCPT ); Sat, 20 May 2023 05:39:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE2B51BD; Sat, 20 May 2023 02:39:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 77A0860A6C; Sat, 20 May 2023 09:39:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E075C433D2; Sat, 20 May 2023 09:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684575573; bh=u+XokJXJqqWsxP3R/qKZwNbpDIsXwkbgPE+7cCEi5+E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C5yabXkEj7EhC8yxQ6eikd9gU/GWKBSoj3yVXwPE1+J05/0n9c4I6o9AbLMfSm7gR StV/f5oSbkM3NwtWKHs0m5OIPj66YN1Cb2n2oT/k6ZOweNyp2Dqil3WY7TJeQ9fCxR RqY0YpXNOz8AmGF26SQZvTmoWT3YgxaJ9UkETKjQH33BpCHmagWzpbPMCbY76M8RNd I4oXSpz+kG8vAdoBC8oARR1nMu3c4q2zVFj4iMV+9VEZfvbJPfbDTIwG61Oc71Rg/v pzdPTE4ikoxokxMYS81mUEsCJ5BCGOy83EpomcJ7jtZGQhNc8jlP4sJ+fV+kjYXoXE 7jCzJRFUNurBQ== Date: Sat, 20 May 2023 11:39:27 +0200 From: Christian Brauner To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH v21 07/30] splice: Make splice from an O_DIRECT fd use copy_splice_read() Message-ID: <20230520-ethisch-wahlabend-1b7d9cf4dd13@brauner> References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-8-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230520000049.2226926-8-dhowells@redhat.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 20, 2023 at 01:00:26AM +0100, David Howells wrote: > Make a read splice from a file descriptor that's open O_DIRECT use > copy_splice_read() to do the reading as filemap_splice_read() is unlikely > to find any pagecache to splice. > > Signed-off-by: David Howells > cc: Christoph Hellwig > cc: Al Viro > cc: Jens Axboe > cc: linux-fsdevel@vger.kernel.org > cc: linux-block@vger.kernel.org > cc: linux-mm@kvack.org > --- Reviewed-by: Christian Brauner