Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp569257rwd; Sat, 20 May 2023 02:53:04 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7t2u85nG6vdy50JqJU2zU+FH4YGgGmOk6fgHjlgglqH/K4jyjaPWlg4jk5fXFWTdrAPqyU X-Received: by 2002:a17:90a:1116:b0:250:69de:7157 with SMTP id d22-20020a17090a111600b0025069de7157mr9392216pja.2.1684576384626; Sat, 20 May 2023 02:53:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684576384; cv=none; d=google.com; s=arc-20160816; b=IxdX7MvATAmA2wZCyguOO4b9czcHBFqpXjGszJYQKMf2ysjXuSpMbxhW3W8KhH6koU B+Ya2w4BNuOx0K5ceelOpJTbY9uq8J4rZTq9ByuPYdK/ypfD3UaNWhR3ZYllPMvc6KS2 RZhT2gwuM1/WO/2GHj5Gw7ACBGY6BKkhGWzh9wqw4HOFZ3HwnDS5+0aOhhdck7CUO6Hk /GbOdJkO5AoCIkiRw/Rcx6hVn3UyqgQvwcMT8xpY4FkylNRtVqIgJaEE1PquTi2PijeX dj0N7qRT15BDvVjOJtfVdgw59FdXSmlAGjtXOp4gRN3lwSo0h89cf66FXNIfSue37B5Z dCcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gl1P24fcznldntc9vM4UoeVfROMY63nXN9xG77RP260=; b=EmEB38Du9ztNOjVBERdZUjIFUDAvnCvI64SIFrkB57ybTrLJudSrkEOrEa10bYfhQC LZkyDh12hzAu0n6H3hwmUTmjCf8d4wCX/ocSexqD0E4iL7scXdRFZ5OjyktFkeWv6S+m X24Ck2VNFk1c7oWuNLn/kpc1ZzgIra9vXLPNX634sr369oG6iKoqfrA1cZQb8JpR9awB p3fYQwjRWAPTfA1KIKoTDP6Lqy+2Bo4n6RN9DRTsFPVhwMdAXtDLgu8onjv/6SVU34gg u259Osk3ytJ42uyxfITjzUOgOChK4Ofg3R2I3il4W7KxOqOxjaQXFguiIFkgjydhK+ND 33eQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=foeDhXxI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t24-20020a639558000000b00528d90d40cfsi1305873pgn.228.2023.05.20.02.52.51; Sat, 20 May 2023 02:53:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=foeDhXxI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231253AbjETJem (ORCPT + 99 others); Sat, 20 May 2023 05:34:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbjETJel (ORCPT ); Sat, 20 May 2023 05:34:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A78B1B4; Sat, 20 May 2023 02:34:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E8A9360A54; Sat, 20 May 2023 09:34:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 151FEC433D2; Sat, 20 May 2023 09:34:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684575279; bh=nrrEdtmBB6Wb7o+hUn1Dip5xrGG4Byrj3iJNIPMqUEo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=foeDhXxI2PuHz7Q+qNEc/7IWEGb8BDWyk+PS3YX2CJWnBvwk6OXTf0aTprW0aj98l ZuZFHoe3kJWxosV1xt85J1vVEtNWMC4OJVyU0CpJd7LS2xSlgjprs0TJ5RLPNlkbDc EF8M3BomBWTqIxtocWFzE8ZDobcOmoh2J2SIYCz8oMmOd2Eg2KLTI04lVQPFOGcY60 MT/qFNwGdxD20aXv3GXEKSq5qQCq+45ZkDb6bGZ54PQLMjLTPN6N5gpdjpKOj/cJdi +8B3+rfWWiSlo8Igzx9FMHAFpRBIAGG9y/tlvFEn3HwMSMqNI8PrOJEu54GWcRMQbj zEsed/EcHyeMQ== Date: Sat, 20 May 2023 11:34:31 +0200 From: Christian Brauner To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v21 04/30] splice: Clean up copy_splice_read() a bit Message-ID: <20230520-geantwortet-pflanzen-5623c1881792@brauner> References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-5-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230520000049.2226926-5-dhowells@redhat.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 20, 2023 at 01:00:23AM +0100, David Howells wrote: > Do a couple of cleanups to copy_splice_read(): > > (1) Cast to struct page **, not void *. > > (2) Simplify the calculation of the number of pages to keep/reclaim in > copy_splice_read(). > > Suggested-by: Christoph Hellwig > Signed-off-by: David Howells > Reviewed-by: Christoph Hellwig > cc: Jens Axboe > cc: Al Viro > cc: David Hildenbrand > cc: John Hubbard > cc: linux-mm@kvack.org > cc: linux-block@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > --- Reviewed-by: Christian Brauner