Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 20 May 2023 17:35:36 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Andreas Klinger <ak@it-klinger.de>
Cc:     linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Angel Iglesias <ang.iglesiasg@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] iio: pressure: Honeywell mprls0025pa pressure
 sensor
Message-ID: <20230520173536.6597aa21@jic23-huawei>
In-Reply-To: <ZGNawohZTDhPazil@arbad>
References: <ZFUCf059+PSR+3Wb@arbad>
        <ZFUC/3zBFQRBsYUk@arbad>
        <20230506170420.71bead77@jic23-huawei>
        <ZGNawohZTDhPazil@arbad>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 16 May 2023 12:28:18 +0200
Andreas Klinger <ak@it-klinger.de> wrote:

> Hi Jonathan,
> 
> thanks for your review. I have one comment.
> 
> Jonathan Cameron <jic23@kernel.org> schrieb am Sa, 06. Mai 17:04:
> > > +	int                     scale;          /* int part of scale */
> > > +	int                     scale2;         /* nano part of scale */
> > > +	int                     offset;         /* int part of offset */
> > > +	int                     offset2;        /* nano part of offset */
> > > +	struct gpio_desc	*gpiod_reset;	/* reset */
> > > +	int			irq;		/* end of conversion irq */  
> > 
> > Only needed in probe, no need for a copy in here.  
> 
> It's also used in mpr_read_pressure() to distinguish the two possible operation
> modes:
> - waiting for an interrupt
> - reading in a loop until status indicates data ready
> 
Oops.  Thanks for pointing that out!

> Andreas