Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Juergen Gross <jgross@suse.com>
Cc:     "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
        "James E.J. Bottomley" <jejb@linux.ibm.com>, stable@vger.kernel.org
Subject: Re: [PATCH] scsi: Let scsi_execute_cmd() mark args->sshdr as invalid
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq11qjaqzq8.fsf@ca-mkp.ca.oracle.com>
References: <20230511123432.5793-1-jgross@suse.com>
        <yq1ttwbsoii.fsf@ca-mkp.ca.oracle.com>
        <6614f626-d174-03d0-0993-79e6f6169b71@suse.com>
Date:   Sat, 20 May 2023 20:46:27 -0400
In-Reply-To: <6614f626-d174-03d0-0993-79e6f6169b71@suse.com> (Juergen Gross's
        message of "Wed, 17 May 2023 06:54:38 +0200")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RN7bSkPGRG7vc7Cc717ag3C6o0ilsieoyJFRA732Qdde1dO2WT/+06iGXIgc?=
 =?us-ascii?Q?M3r6nzd3kR/esUsBQ1Ts7yVirQQrpnXG6g7e7jq1/pu5Rf3FPYhK4IV3Zx4L?=
 =?us-ascii?Q?ySUg5Zhfu9AgMHMGXIZcyJbucQOXLl+XAvAFX1461434qyYFNc4X3wxuh4W5?=
 =?us-ascii?Q?8cTZD1VtjvZW/NwbqSZgc/bMVhEodZKyLoLW3OpNB8Cv2VlYx0Y2o4LIbYfM?=
 =?us-ascii?Q?P7nAP+wSAbOFMah9dItpVDnqioa9ywwduUIQSxw+GrKZBAbH7g97SKxzR/vH?=
 =?us-ascii?Q?AELBSUvvD9Fbh9IMoIYoO640XV3wJtceKXcNNofN7c6D5gAfyLlj4W0aJeG0?=
 =?us-ascii?Q?U1DpHAXuXCQbtgLzYgp85Fhfvq2M1Ait6uDDDk2e4aYUKq7uGRKlI6wCn0WB?=
 =?us-ascii?Q?dP2jiexhsqXGHN+SKP9UDkq401lzkLTXXqBrHdN5sMqdFP9ssMGgLWaYmvwM?=
 =?us-ascii?Q?86aodvR3i5I5725uicZJmau8i2a/xIFFB936yaaz4XWx05ZaOzoAVblIONQk?=
 =?us-ascii?Q?moW5lmga/G5ff4ooJcm9l1M7UNz0xeu3W07al1dboGlzTtcBRxySbbJbxJc9?=
 =?us-ascii?Q?8Ts6kXpEJwsrmk0phpXNZ8xPglAubHxhn/2IdU1MExlB55T7Ms/q5q1L2mHO?=
 =?us-ascii?Q?wH3RUFcJbzUBBfSN0vlSHe8X9uE7jeZeTroBpdQACNKO818uxlWd7Vtzvodq?=
 =?us-ascii?Q?afdeFqvxRz7nLcz0T0VGOrTl0nWn3a2v8HmZmp9cTJdxQ86KqS/Ese0Ip+Vh?=
 =?us-ascii?Q?qiAJ8MP67kDH4GBzJAO8ahKMzr4E4VIEkKoo7+Aa1UK+FqljSUfg3loHwkx2?=
 =?us-ascii?Q?4re9LnnV7lNs6rxwn1nZXy6FKEusbKvWaOKur//Vf+Bkzslcl6u6e0LWyqcU?=
 =?us-ascii?Q?HHoGNBiiGJXHgMwZ75rjQQUcbMt84OPj/BWqvlu0Bt4MVngIQ0BGwiEPTfmV?=
 =?us-ascii?Q?QNTLpJnsxXqSKwsWHGrLQhqZDS6BJEw/LmR0MFetoIo7N5nFKbNJJMLsUcwh?=
 =?us-ascii?Q?kYd4jRoHsk9o+jA3D8CfNgRBi5Vi/oI+m64NSotLen7dM4AvrjIjLd6S4XK6?=
 =?us-ascii?Q?MaXeHpkjpIyL8bHXJwybavJsClV7fHqmthk4it3IwxyT+Sa0lHH+xnGXimzG?=
 =?us-ascii?Q?+bb8zYEqQebAdSG2t4IjypRyouHlpQorU6WogByuAE2q4OWTJNTDJD28yNUD?=
 =?us-ascii?Q?A/UFDt9Gqk1xvsikW4BdK2fZsPR7gZ0F2q/d5nsMlgMtmyy32tTC2akX27ce?=
 =?us-ascii?Q?nN/1hf6K/pAIYW2/rqp7igBquIQ59ugeEXdXVDQo1y/tRTI/kb3ND/CrrJqO?=
 =?us-ascii?Q?8glMN64WPjkasff29dMLLU5Tj1GAV8ckDl9D20uCjnIw+qaMOMprZd7W1Jvq?=
 =?us-ascii?Q?wGUvabqhJ4/dNE4dVOhoqsNYcf2RUD5bKe+6FAwR9wcM9roq68VlDz1Dpa/6?=
 =?us-ascii?Q?NEOJy7TxNo4qjBbJCIATt3zmIRNcmFTCB6lzwJ0URNuf/CzcWiFBpgRi4Lcc?=
 =?us-ascii?Q?VbrDPBJ27QFvAP/oWOmO39N9CvhHtkd2XKTVc9wJMt64LCgcKf8JETHdkEzz?=
 =?us-ascii?Q?8N6PYqHvHrvjnwsZ7EpHvqcdcS4jOxkKuT+L8/zLLZ7t/63bTpO1CrmM72rQ?=
 =?us-ascii?Q?6g=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: +ZFh1jv7/2uD6cwNlBmL0wA4XQcxsjukpgpWsXX4LGMm0UFCCvQNMdlnToAuxu2j/EWjbr5PznhIb43LevRczxg8z9QmOT4KaxrTaH851mRXOlVeY+N9ND3EC/ZA+0h6IoJFSz30NXToXqINurYp5FCT3ugZISnRj/aYGAuZCCD0v4QDOC7JkH1oxWcRDJTzemNR6KTPzptVpT2QAXuzGyAqzhfqV2Ihs17NflH4gLY9Z0vrRLrlTytZiHj3AAixR9GDN1bzaGPw5V2AcgjI21NZxrhHUofD8wVqfsNNZ/tCWADHmuyi65VemdellOuLRuSq/ZFvILbSopoYk+hP4E+exE0Bm0QiI1SiG8nuEesxK0Vwr23NXI5+iVe5kl2hQric48J+nn8/a2PMJvn80phSxbQrxR880AkkqmCszmTGb0cS7G56Rhyzo/2Xo2eYuxn4/eBOBoxgoVBGd/i5PcXXWm+GJNS2kSIGSwfZ+lg7VQd5sK8Csu7ItGIy+eDWqg+9Fihqznw1sl2eK/+P5O5rEGgBPucJFYGiRr5GksTcaTogCKUUMsC1OfnjH4mYrERDrrXcLgNso/lIcXICUyHWR9DPhbedQAXWRHRNDWggW7oe+8y5QE1KGMD7wRh1J1cFy8skIv2mroCLbo5uY8v57j3xkm3fBD/3TzFYXzRWSr635nI3OURgNnmRgomwu5Udex/bSzPA7KyfijCRlhiKnUp9nBLbrdpxj8lgLuJXKyjSi/JJ+xdX/qrqXmBtWPJkodol76/7dN1zY3ALZQ0X821dvPGCWLhEfMuBF1CmRQYqOw8VVEirkdLr8xlY8hVd9VW7zicsVV/saRbu3w==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5babeace-4bb0-4605-edf0-08db5994d2f1
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2023 00:46:33.4344
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zAPIKb4HkaErfbi1jfdWXanpbnXHLGl+kbxCLNh9K68DLE/qTfSLAGsO1OY09kz2ZCJU68nwLEl3dn4XCTxJZBPgaigfXUxwvxgTnRtT4qA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6638
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-20_16,2023-05-17_02,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0
 mlxlogscore=574 mlxscore=0 malwarescore=0 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2305210005
X-Proofpoint-GUID: 9x8K2YyzDUfbwfe9pKSIAeZ9mSxw8hGR
X-Proofpoint-ORIG-GUID: 9x8K2YyzDUfbwfe9pKSIAeZ9mSxw8hGR
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Juergen,

>> Which callers? sd_spinup_disk() appears to do the right thing...
>> 
>
> Not really. It is calling media_not_present() directly after the call of
> scsi_execute_cmd() without checking the result.

My bad. I was looking at sd_check_events(), not sd_spinup_disk().

-- 
Martin K. Petersen	Oracle Linux Engineering