Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 21 May 2023 08:22:56 +0200
Message-ID: <877ct2yzi7.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Adam Stylinski <kungfujesus06@gmail.com>
Cc:     Takashi Iwai <tiwai@suse.de>, perex@perex.cz,
        linux-kernel@vger.kernel.org
Subject: Re: ca0132 patches
In-Reply-To: <CAJwHY9VXeGEvvR8qL+DEB6anfR6ePW864UKftVStH0Wj_Das1g@mail.gmail.com>
References: <CAJwHY9WVvV1aN-Wa5OnUrr_yvcD+RK+ykDgqpffKaOPvzXLiTg@mail.gmail.com>
        <a2feaf97-b9e4-4318-86e7-e7a654794f78@xianwang.io>
        <87a5xzz3lf.wl-tiwai@suse.de>
        <CAJwHY9WGRCdbb=vrbY1UwdiJ3mb28tk2S69i89CiPMJyHQa0=Q@mail.gmail.com>
        <CAJwHY9WgpL8KajHAS3Xb1=A=J5_Accm76p4W89j+K+wRjN7zQQ@mail.gmail.com>
        <CAJwHY9VXeGEvvR8qL+DEB6anfR6ePW864UKftVStH0Wj_Das1g@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sun, 21 May 2023 04:29:45 +0200,
Adam Stylinski wrote:
> 
> Sorry, mutt's being insane uncooperative.  Here's the format-patch attached.
> 
> On Sat, May 20, 2023 at 11:21 AM Adam Stylinski <kungfujesus06@gmail.com> wrote:
> >
> > Mutt + SMTP + Gmail are acting up and I had to head out. I'll get this sent out tonight, though. Did you want me to cc the mailing list too?
> >
> > On Sat, May 20, 2023, 10:27 AM Adam Stylinski <kungfujesus06@gmail.com> wrote:
> >>
> >> Correct.  A format-patch output is coming soon, I'm just waiting for a
> >> proper clone to finish.
> >>
> >> On Sat, May 20, 2023 at 6:42 AM Takashi Iwai <tiwai@suse.de> wrote:
> >> >
> >> > On Fri, 19 May 2023 05:53:09 +0200,
> >> > Xian Wang wrote:
> >> > >
> >> > > On 18/05/2023 20:02, Adam Stylinski wrote:
> >> > > > Hello,
> >> > > >
> >> > > > I noticed you patched in a quirk in basically the same place I am for
> >> > > > a different EVGA board.  This quirk is needed for me as well but it
> >> > > > would seem the bugzilla and mailing lists are ignored.  I was hoping
> >> > > > maybe I could draw your attention to this?
> >> > > >
> >> > > > https://bugzilla.kernel.org/show_bug.cgi?id=67071
> >> > > >
> >> > > > I suffer a similar issue (namely surround is disabled without enabling
> >> > > > this quirk).  I still have some temperamental behavior with the quirk
> >> > > > in place (the port mapping doesn't always seem consistent boot to
> >> > > > boot, often needing several reboots before all channels are working).
> >> > > > I'm not certain if this is a quirk of loading the firmware or what.
> >> > > > At the very least, not having to patch this locally every kernel
> >> > > > update would be nice.  I'm CC'ing the maintainer who signed off on the
> >> > > > patch as well, really hoping to get some attention on this.
> >> > >
> >> > > Hi Adam,
> >> > >
> >> > > Unfortunately I haven't experienced the flakiness of surround sound
> >> > > mentioned in the bug. The channel mapping seems correct and is
> >> > > consistent from boot to boot.
> >> > >
> >> > > For not patching locally every time there is a new kernel, are you
> >> > > open to submit that one-line patch up?
> >> >
> >> > So you need only the addition of
> >> >   SND_PCI_QUIRK(0x3842, 0x104b, "EVGA X299 Dark", QUIRK_R3DI)
> >> > ?
> >> >
> >> > If so, I can submit a oneliner from my side, too.  But it's still
> >> > better to be submitted from the person who actually tested the patch,
> >> > of course.
> >> >
> >> >
> >> > Takashi
> From fd1ff1aff3a70716b4d6d99a89934aea5d718cad Mon Sep 17 00:00:00 2001
> From: Adam Stylinski <kungfujesus06@gmail.com>
> Date: Sat, 20 May 2023 10:31:54 -0400
> Subject: [PATCH] ALSA: hda/ca0132: add quirk for EVGA X299 DARK
> 
> This quirk is necessary for surround and other DSP effects to work
> with the onboard ca0132 based audio chipset for the EVGA X299 dark
> mainboard.
> 
> Signed-off-by: Adam Stylinski <kungfujesus06@gmail.com>

Could you rather submit to alsa-devel ML (plus Cc to LKML)?


thanks,

Takashi

> 
> ---
>  sound/pci/hda/patch_ca0132.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
> index 099722ebaed8..748a3c40966e 100644
> --- a/sound/pci/hda/patch_ca0132.c
> +++ b/sound/pci/hda/patch_ca0132.c
> @@ -1306,6 +1306,7 @@ static const struct snd_pci_quirk ca0132_quirks[] = {
>  	SND_PCI_QUIRK(0x1458, 0xA026, "Gigabyte G1.Sniper Z97", QUIRK_R3DI),
>  	SND_PCI_QUIRK(0x1458, 0xA036, "Gigabyte GA-Z170X-Gaming 7", QUIRK_R3DI),
>  	SND_PCI_QUIRK(0x3842, 0x1038, "EVGA X99 Classified", QUIRK_R3DI),
> +	SND_PCI_QUIRK(0x3842, 0x104b, "EVGA X299 Dark", QUIRK_R3DI),
>  	SND_PCI_QUIRK(0x3842, 0x1055, "EVGA Z390 DARK", QUIRK_R3DI),
>  	SND_PCI_QUIRK(0x1102, 0x0013, "Recon3D", QUIRK_R3D),
>  	SND_PCI_QUIRK(0x1102, 0x0018, "Recon3D", QUIRK_R3D),
> -- 
> 2.40.1
>