Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1621548rwd; Sun, 21 May 2023 02:37:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ70fqqMIl2R0XRfmbAKRTaVU0ucBp1Xtiix/UUhlA+0ASwYhUPVIq4ioA7J3P59f05b+d/1 X-Received: by 2002:a05:6a20:5b07:b0:107:35ed:2868 with SMTP id kl7-20020a056a205b0700b0010735ed2868mr6466430pzb.14.1684661874870; Sun, 21 May 2023 02:37:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684661874; cv=none; d=google.com; s=arc-20160816; b=uhvueQJF0AUw8deDfJqdKkDIm9XZLicPQl3fQr3vM1+34owZYgOjWP4/tsFJ/MEajA /2NPQqcOkGbNTZAV9bki2BR8NJL8okUcy66cA5OvvoKTRouFNdZ+pOl3bhtNpFmh7zXJ bGkMOx7Y9G0Gfm/aqEhLaGJM5ZJSAGP9vW6Jlua98+b+H16E+2k2tBVBH2qa0jQffBlq UAc6TwW8uqw0pU3yI05qeO+d0+1xRNkwypnpkIMqCA4eL25FYy3qQOo45IJugpLhY17C bxudnrpl1vuNmOJRMRWybqJVHD2xCyOapwbxreXWIu7Gb64BJYo8q+HqFE6T35t2pCH5 RUgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=lLvUagcTc+78YHkeWPUtcjx3oWP3Lf3BfrTi3qWSTCg=; b=p+D8tSx72Lr6rJ3M7NSpL7iYoieGWkrJErmZZLDpK+vg7wvii9UBQLYkL3rRRR2O2c 8Eme3BRGpmRqXDxswvYCv7kEnu58flEHp3pQ4m3TD7FI7BokpUMneoflcbpKacYcNsc2 dIndV8rZ/wINN/G3QSR4pcNNf72/BgEe929qL81DnaW1AaOZIwmRn2JbnY3I3iffrTYK blwbx3nq411sEnBBaIVgL6AFKF346NMgrVXCSfNW3iihFN8seJOXmmJ1KWXWY+qmOyxm pUhC/qLAee9JXNPgwWaqi98DmpO0RsnoC0SSlEZf1EOw/y31B1Cmed56/m3WCMVU6oRv TpCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l188-20020a633ec5000000b004ff6eee7176si2902462pga.261.2023.05.21.02.37.31; Sun, 21 May 2023 02:37:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229656AbjEUJUP convert rfc822-to-8bit (ORCPT + 99 others); Sun, 21 May 2023 05:20:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229511AbjEUJUO (ORCPT ); Sun, 21 May 2023 05:20:14 -0400 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B352493; Sun, 21 May 2023 02:20:13 -0700 (PDT) Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-528dd896165so3372953a12.2; Sun, 21 May 2023 02:20:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684660813; x=1687252813; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8HwM6KmZId1WNbACaRjkfOnAGeuoeekyl1zBNcHd9TA=; b=XryRZG9kjgR04Bo7y5DJ1NWf9L1YacHwnzTTjdMy6+HRQxSLhryJA2mwGII3zz4uHf ZXFo68HzIhcQfxvylfF9alveHChOjBEwKQCFSm5fugwpEwaDvScEd6S6CPs2iwj6uZdG 2FglrwCM1ZXbqReWy0LC9/5fiet6G2k2OEcpPL3emVJ+OQq5KgeD18i0yP3VNGbB1oW+ 8i7Ilei2iPMa4mAaSB4YRKswINobG23Be6ot5vYOkzlWRqbloU+H6O94Aqr7b11LkFoE /pzCE2TMoq+92poT6Yp6pJKyEs7rvrsrb7zBntWzm6Ls2FmkiZS67RqSeCJKC4vrP1ZU bNgw== X-Gm-Message-State: AC+VfDw9cdKdoBQOuy+PYdJ/FObCY6UhgDGhvE8Xc/oW9qVVOajWK5hS Ffm1gGwIWtsCLVC8cVQLTALl+zGqxJbiohJt+mI= X-Received: by 2002:a17:90a:e2d3:b0:246:5f9e:e4cf with SMTP id fr19-20020a17090ae2d300b002465f9ee4cfmr7011890pjb.43.1684660813127; Sun, 21 May 2023 02:20:13 -0700 (PDT) MIME-Version: 1.0 References: <20230519195600.420644-1-frank.jungclaus@esd.eu> In-Reply-To: <20230519195600.420644-1-frank.jungclaus@esd.eu> From: Vincent MAILHOL Date: Sun, 21 May 2023 18:20:02 +0900 Message-ID: Subject: Re: [PATCH v2 0/6] can: esd_usb: More preparation before supporting esd CAN-USB/3 To: Frank Jungclaus Cc: linux-can@vger.kernel.org, Marc Kleine-Budde , Wolfgang Grandegger , =?UTF-8?Q?Stefan_M=C3=A4tje?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Frank, On Sat. 20 mai 2023 à 04:57, Frank Jungclaus wrote: > Apply another small batch of patches as preparation for adding support > of the newly available esd CAN-USB/3 to esd_usb.c. > --- I sent two nitpicks but aside from that the series looks good. Thank you for taking time to clean-up the existing code before introducing the new changes. I do not think I will need to review the v3, so in advance: Reviewed-by: Vincent Mailhol