Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 22 May 2023 06:48:45 +0900 (JST)
Message-Id: <20230522.064845.1518051418018369671.yamato@redhat.com>
To:     bruce.dubbs@gmail.com
Cc:     kzak@redhat.com, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, util-linux@vger.kernel.org,
        renodr2002@gmail.com
Subject: Re: [ANNOUNCE] util-linux v2.39
From:   Masatake YAMATO <yamato@redhat.com>
In-Reply-To: <ced4d4e1-8358-d718-58ee-9effe39cff6e@gmail.com>
References: <20230520.074311.642413213582621319.yamato@redhat.com>
        <2fc8421e-634a-aa7d-b023-c8d5e5fa1741@gmail.com>
        <ced4d4e1-8358-d718-58ee-9effe39cff6e@gmail.com>
Organization: Red Hat Japan, K.K.
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

From: Bruce Dubbs <bruce.dubbs@gmail.com>
Subject: Re: [ANNOUNCE] util-linux v2.39
Date: Sat, 20 May 2023 18:16:07 -0500

> On 5/19/23 17:56, Bruce Dubbs wrote:
>> On 5/19/23 17:43, Masatake YAMATO wrote:
>>> Bruce,
>>>
>>>> On 5/17/23 06:22, Karel Zak wrote:
>>>>> The util-linux release v2.39 is available at
>>>>>                                        http://www.kernel.org/pub/=
linux/utils/util-linux/v2.39
>>>>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 Feedback and bug reports, as
>>>>> always, are welcomed.
>>>>
>>>> Karel, I have installed util-linux v2.39 in LFS and have run into =
a
>>>> problem with one test, test_mkfds.=A0 Actually the test passes, bu=
t does
>>>> not clean up after itself. What is left over is:
>>>>
>>>> tester 32245 1 0 15:43 ?=A0 00:00:00 /sources/util-linux-2.39/test=
_mkfds
>>>> -q udp 3 4 server-port=3D34567 client-port=3D23456 server-do-bind=3D=
1
>>>> client-do-bind=3D1 client-do-connect=3D1
>>>> tester 32247 1 0 15:43 ?=A0 00:00:00 /sources/util-linux-2.39/test=
_mkfds
>>>> -q udp6 3 4 lite=3D1 server-port=3D34567 client-port=3D23456
>>>> server-do-bind=3D1 client-do-bind=3D1 client-do-connect=3D1
>>>>
>>>> It's possible it may be due to something we are doing inside our
>>>> chroot environment, but we've not had this type of problem with
>>>> earlier versions of util-linux.
>>>>
>>>> In all I do have:
>>>>
>>>> =A0=A0 All 261 tests PASSED
>>>>
>>>> but the left over processes interfere later when we try to remove =
the
>>>> non-root user, tester, that runs the tests.=A0 I can work around t=
he
>>>> problem by disabling test_mkfds, but thought you would like to kno=
w.
>>>
>>> Thank you for reporting.
>>> Reproduced on my PC. I found two processes were not killed properly=
.=

>>>
>>> Could you try the following change?
>>>
>>> diff --git a/tests/ts/lsfd/option-inet b/tests/ts/lsfd/option-inet
>>> index 21e66f700..70cc3798d 100755
>>> --- a/tests/ts/lsfd/option-inet
>>> +++ b/tests/ts/lsfd/option-inet
>>> @@ -84,14 +84,10 @@ ts_cd "$TS_OUTDIR"
>>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 -o ASSOC,=
TYPE,NAME \
>>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 -Q "(PID =
=3D=3D $PID0) or (PID =3D=3D $PID1) or (PID =3D=3D
>>> $PID2) or (PID =3D=3D $PID3) or (PID =3D=3D $PID4)"
>>> -=A0=A0=A0 kill -CONT "${PID0}"
>>> -=A0=A0=A0 wait "${PID0}"
>>> -
>>> -=A0=A0=A0 kill -CONT "${PID1}"
>>> -=A0=A0=A0 wait "${PID1}"
>>> -
>>> -=A0=A0=A0 kill -CONT "${PID2}"
>>> -=A0=A0=A0 wait "${PID2}"
>>> +=A0=A0=A0 for pid in "${PID0}" "${PID1}" "${PID2}" "${PID3}" "${PI=
D4}"; do
>>> +=A0=A0=A0=A0=A0=A0 kill -CONT "${pid}"
>>> +=A0=A0=A0=A0=A0=A0 wait "${pid}"
>>> +=A0=A0=A0 done
>>> =A0 } > "$TS_OUTPUT" 2>&1
>>> =A0 ts_finalize
>> I will do that, but will not be able to get to it until late tomorro=
w,
>> but will report back asap.
> =

> I used the above patch and it fixed the problem.  Thank you.
> =

>   -- Bruce
> =

> =


Thank you for testing.
I made a pull request based on this change:

  https://github.com/util-linux/util-linux/pull/2246

Masatake YAMATO