Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authenticated-By: 
From:   Ping-Ke Shih <pkshih@realtek.com>
To:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
CC:     "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "kvalo@kernel.org" <kvalo@kernel.org>,
        "tony0620emma@gmail.com" <tony0620emma@gmail.com>,
        "Peter Robinson" <pbrobinson@gmail.com>,
        "jernej.skrabec@gmail.com" <jernej.skrabec@gmail.com>
Subject: RE: [PATCH wireless-next v1 3/4] mmc: sdio: Add/rename SDIO ID of the RTL8723DS SDIO wifi cards
Thread-Topic: [PATCH wireless-next v1 3/4] mmc: sdio: Add/rename SDIO ID of
 the RTL8723DS SDIO wifi cards
Thread-Index: AQHZiaRU2yqqdyKoHUKqEdo0JlyLb69litiw
Date:   Mon, 22 May 2023 01:46:14 +0000
Message-ID: <2ffdaf9f38fa4886ab5d2a5b8323d584@realtek.com>
References: <20230518161749.1311949-1-martin.blumenstingl@googlemail.com>
 <20230518161749.1311949-4-martin.blumenstingl@googlemail.com>
In-Reply-To: <20230518161749.1311949-4-martin.blumenstingl@googlemail.com>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk


> -----Original Message-----
> From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Sent: Friday, May 19, 2023 12:18 AM
> To: linux-wireless@vger.kernel.org
> Cc: linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org; ulf.hansson@linaro.org; kvalo@kernel.org;
> tony0620emma@gmail.com; Peter Robinson <pbrobinson@gmail.com>; Ping-Ke Shih <pkshih@realtek.com>;
> jernej.skrabec@gmail.com; Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Subject: [PATCH wireless-next v1 3/4] mmc: sdio: Add/rename SDIO ID of the RTL8723DS SDIO wifi cards
> 
> RTL8723DS comes in two variant and each of them has their own SDIO ID:
> - 0xd723 can connect two antennas. The WiFi part is still 1x1 so the
>   second antenna can be dedicated to Bluetooth
> - 0xd724 can only connect one antenna so it's shared between WiFi and
>   Bluetooth
> 
> Add a new entry for the single antenna RTL8723DS (0xd724) which can be
> found on the MangoPi MQ-Quad. Also rename the existing RTL8723DS entry
> (0xd723) so it's name reflects that it's the variant with support for
> two antennas.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
>  include/linux/mmc/sdio_ids.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
> index c653accdc7fd..7fada7a714fe 100644
> --- a/include/linux/mmc/sdio_ids.h
> +++ b/include/linux/mmc/sdio_ids.h
> @@ -121,7 +121,8 @@
>  #define SDIO_DEVICE_ID_REALTEK_RTW8822BS       0xb822
>  #define SDIO_DEVICE_ID_REALTEK_RTW8821CS       0xc821
>  #define SDIO_DEVICE_ID_REALTEK_RTW8822CS       0xc822
> -#define SDIO_DEVICE_ID_REALTEK_RTW8723DS       0xd723
> +#define SDIO_DEVICE_ID_REALTEK_RTW8723DS_2ANT  0xd723
> +#define SDIO_DEVICE_ID_REALTEK_RTW8723DS_1ANT  0xd724
>  #define SDIO_DEVICE_ID_REALTEK_RTW8821DS       0xd821
> 
>  #define SDIO_VENDOR_ID_SIANO                   0x039a
> --
> 2.40.1