Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754511AbXJICPX (ORCPT ); Mon, 8 Oct 2007 22:15:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752630AbXJICPL (ORCPT ); Mon, 8 Oct 2007 22:15:11 -0400 Received: from rgminet01.oracle.com ([148.87.113.118]:15722 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752567AbXJICPK (ORCPT ); Mon, 8 Oct 2007 22:15:10 -0400 Date: Mon, 8 Oct 2007 19:12:54 -0700 From: Mark Fasheh To: Nick Piggin Cc: David Chinner , Peter Zijlstra , linux-kernel , Linus Torvalds , Andrew Morton , Christoph Hellwig , David Howells , Trond Myklebust , hugh , stable Subject: Re: [PATCH] mm: set_page_dirty_balance() vs ->page_mkwrite() Message-ID: <20071009021253.GC30360@ca-server1.us.oracle.com> Reply-To: Mark Fasheh References: <1191862477.20745.22.camel@twins> <200710081637.01122.nickpiggin@yahoo.com.au> <20071008233637.GF995458@sgi.com> <200710081747.52627.nickpiggin@yahoo.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710081747.52627.nickpiggin@yahoo.com.au> Organization: Oracle Corporation User-Agent: Mutt/1.5.16 (2007-06-11) X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1026 Lines: 26 On Mon, Oct 08, 2007 at 05:47:52PM +1000, Nick Piggin wrote: > > block_page_mkwrite() is just using generic interfaces to do this, > > same as pretty much any write() system call. The idea was to make it > > as similar to the write() call path as possible... > > > > However, unlike generic_file_buffered_write(), we are not calling > > balance_dirty_pages_ratelimited(mapping) between > > ->prepare/commit_write call pairs. Perhaps this should be added to > > block_page_mkwrite() after the page is unlocked.... > > That sounds pretty sane, in terms of matching with > generic_file_buffered_write. I agree. We could also insert a call to balance_dirty_pages_ratelimited() in __ocfs2_page_mkwrite. --Mark -- Mark Fasheh Senior Software Developer, Oracle mark.fasheh@oracle.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/