Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sherry Sun <sherry.sun@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org,
        shenwei.wang@nxp.com, ilpo.jarvinen@linux.intel.com
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: [PATCH] tty: serial: fsl_lpuart: Check the return value of dmaengine_tx_status
Date:   Mon, 22 May 2023 10:51:11 +0800
Message-Id: <20230522025111.3747-1-sherry.sun@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dQ2tN6MhOqvcode1R/Zn1Xp+08Qc0SWJAo/nsTS5FFOZPYzJOSynamM3G0dj?=
 =?us-ascii?Q?z0Utg+AOZO9YKqBtd8NdnyywyDEyQOqKLO9VBeLZlYPq7N1hOXjvAoVetAwz?=
 =?us-ascii?Q?ycawU9PlCase5yA/x53i1pO926oEV/Tl31zKLWVkAqZOxTphwVOH5uQQi83z?=
 =?us-ascii?Q?SCPDCS+E6fAJslC46TKcy32A+9zcQ43qVx/Wj9CsLeUEHopmyiuWU7IPi75v?=
 =?us-ascii?Q?VHMPOXljDJFUVVNXn3zauc4pJ7CEpTgbgGRgNd1mHncuuWyWz6uQQqBl0sx8?=
 =?us-ascii?Q?jv2WS5d/ADTyelb+0cWpNW5bc9NBBXrjUXldGanPPNChabSy4o6QGqZSNqM+?=
 =?us-ascii?Q?wB1NcCns9cvPiDBKI13sJestRmIEQmV5Yrq55ftpwD4hMFESgNBuP4ntwX4h?=
 =?us-ascii?Q?RTHP5+R6rT7KsLm8QwmcDzKv6EIZaT+L7adUh1McVaPc62ZIvPONtRzuBmyD?=
 =?us-ascii?Q?yHtcos9J4u7c2DEganHOQkTYEBrxr3Me93JaPe+Th7SFeDU4GBdUOQ6s+5K5?=
 =?us-ascii?Q?ZpE5kxmvgJTZpxgeoUx6ukNAJbPAOUeJ9Pv/sDrw59KYaQ79rHpIXwUUzOTb?=
 =?us-ascii?Q?vGaec/DVX346MidJcnNL1r/fvCuxcsqWq7YVLWdNL1tAoYBvFHEOBb1EK7V5?=
 =?us-ascii?Q?EvYUlUESm0awstZ+bW2tZRBxM0AnJ3Z/4e6mi9NEfQLbIVQCRQqSL643Ixpl?=
 =?us-ascii?Q?s299M8IeyvlneqPyD+VYqmwCV3gR+okRFDXZuD8p7xAsJRI70zKBLOtSCin6?=
 =?us-ascii?Q?radZH8Dg3BcyiMazwgAJHysn74Kt5pXGQR19EGbKFgKSQqPf/KKas3pBd/QT?=
 =?us-ascii?Q?IMbCVBjKLXBU4rq5g2RE6lvWSAAGFCxdcpQE0fmwvac9NHYKaPxHKwd9TnBA?=
 =?us-ascii?Q?BAVTkCnQjjAOvuF4MQdyEy7yuR6Otui3N+tMRXxyUewWi4ySGf2tMO/7PBI6?=
 =?us-ascii?Q?MXOER/plgrWLK3vd2R3ZaTfckhxX/DlDrsQejVdQPDV1rWof8YcwXeLgzzZF?=
 =?us-ascii?Q?Y1SfxZqRifyF7T0c/hBLb1WF/JiUFBvJlescgsyAS9mW3XEIuVa5F5X5GokA?=
 =?us-ascii?Q?IlLUsbCFuWEOlflSqfu+nrLDDyoOfOg0kBkydhQPtaLzxw/jhfJyLc+9Eqk3?=
 =?us-ascii?Q?MzEO+kgPYn0wIz0GQzAJ93xN2ePCCj3cxnVnZWVTSOES4Y+rmoncTuzOh6pc?=
 =?us-ascii?Q?onimpIfBi3RqYm5UXvtiu+NW59gdRWaIfVdbJPLpy8Ui3qQhnZqRjN6U7kee?=
 =?us-ascii?Q?jVTICaKdKfXyyOEC47DbePK+Iz4pFvSiZgoTa1fAnkGiDqla4zwDeuAVMHji?=
 =?us-ascii?Q?Jd4R0vfOYgIjaUIV5owJw8KrOmhswEjOEB4/fSNfEM7SDW0zWb1g6hfjwItN?=
 =?us-ascii?Q?57eaE/0RgD0pbGqhVHXVJrmZpkpJQGk0zEWjcZ8tZlCpY+8C+aTrsprZirl3?=
 =?us-ascii?Q?0kv3Yxxn+d6fxPEbRq5usS2vDrXkNmrWbd9ocp0xbiVSuED/8JcYAd4qBpgQ?=
 =?us-ascii?Q?qO6qmMnLT6sLE5kkLYDuPl2qvMpLb3oYdEQDKv3GPlD2VrY062RXRXUnWqdu?=
 =?us-ascii?Q?dTqb0gIBL6e2L7BLA0ccpd1abmCc6Bu7r2vEXulk?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2634d9c7-a7c1-4742-e535-08db5a700b07
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 02:55:47.3198
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UZUDF44cPUZZUeCFzu7CaZFsJlPLA1C4sWUYVB3m12EadLquL8IqzYalfU1r32xb9846p5aPmSclP6R7E7afzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9461
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Coverity reports the Unchecked return value (CHECKED_RETURN) warning:
Calling dmaengine_tx_status without checking return value.

So here add the return value check for dmaengine_tx_status() function to
make coverity happy.

Fixes: cf9aa72d2f91 ("tty: serial: fsl_lpuart: optimize the timer based EOP logic")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 drivers/tty/serial/fsl_lpuart.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 92a3bd0f4158..f2a47a8c5b85 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -1286,13 +1286,19 @@ static void lpuart_dma_rx_complete(void *arg)
 static void lpuart_timer_func(struct timer_list *t)
 {
 	struct lpuart_port *sport = from_timer(sport, t, lpuart_timer);
+	enum dma_status dmastat;
 	struct dma_chan *chan = sport->dma_rx_chan;
 	struct circ_buf *ring = &sport->rx_ring;
 	struct dma_tx_state state;
 	unsigned long flags;
 	int count;
 
-	dmaengine_tx_status(chan, sport->dma_rx_cookie, &state);
+	dmastat = dmaengine_tx_status(chan, sport->dma_rx_cookie, &state);
+	if (dmastat == DMA_ERROR) {
+		dev_err(sport->port.dev, "Rx DMA transfer failed!\n");
+		return;
+	}
+
 	ring->head = sport->rx_sgl.length - state.residue;
 	count = CIRC_CNT(ring->head, ring->tail, sport->rx_sgl.length);
 
-- 
2.17.1