Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230420104622.12504-1-ljrcore@126.com>
In-Reply-To: <20230420104622.12504-1-ljrcore@126.com>
From:   Jinrong Liang <ljr.kernel@gmail.com>
Date:   Mon, 22 May 2023 11:33:51 +0800
Message-ID: <CAFg_LQVfECWsmcSXJWnnyJK5mZAbjdCTX-RXP3aoDAECTspqkA@mail.gmail.com>
Subject: Re: [PATCH v2 0/7] KVM: selftests: Add tests for pmu event filter
To:     Sean Christopherson <seanjc@google.com>
Cc:     Like Xu <like.xu.linux@gmail.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Shuah Khan <shuah@kernel.org>,
        Aaron Lewis <aaronlewis@google.com>,
        David Matlack <dmatlack@google.com>,
        Vishal Annapurve <vannapurve@google.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        Jinrong Liang <cloudliang@tencent.com>,
        linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Jinrong Liang <ljr.kernel@gmail.com> =E4=BA=8E2023=E5=B9=B44=E6=9C=8820=E6=
=97=A5=E5=91=A8=E5=9B=9B 18:46=E5=86=99=E9=81=93=EF=BC=9A
>
> From: Jinrong Liang <cloudliang@tencent.com>
>
> From: Jinrong Liang <cloudliang@tencent.com>
>
> Hi,
>
> This patch set adds some tests to ensure consistent PMU performance event
> filter behavior. Specifically, the patches aim to improve KVM's PMU event
> filter by strengthening the test coverage, adding documentation, and maki=
ng
> other small changes.
>
> The first patch replaces int with uint32_t for nevents to ensure consiste=
ncy
> and readability in the code. The second patch adds fixed_counter_bitmap t=
o
> create_pmu_event_filter() to support the use of the same creator to contr=
ol
> the use of guest fixed counters. The third patch adds test cases for
> unsupported input values in PMU filter, including unsupported "action"
> values, unsupported "flags" values, and unsupported "nevents" values. Als=
o,
> it tests setting non-existent fixed counters in the fixed bitmap doesn't
> fail.
>
> The fourth patch updates the documentation for KVM_SET_PMU_EVENT_FILTER i=
octl
> to include a detailed description of how fixed performance events are han=
dled
> in the pmu filter. The fifth patch adds tests to cover that pmu_event_fil=
ter
> works as expected when applied to fixed performance counters, even if the=
re
> is no fixed counter exists. The sixth patch adds a test to ensure that se=
tting
> both generic and fixed performance event filters does not affect the cons=
istency
> of the fixed performance filter behavior in KVM. The seventh patch adds a=
 test
> to verify the behavior of the pmu event filter when an incomplete
> kvm_pmu_event_filter structure is used.
>
> These changes help to ensure that KVM's PMU event filter functions as exp=
ected
> in all supported use cases. These patches have been tested and verified t=
o
> function properly.
>
> Thanks for your review and feedback.
>
> Sincerely,
> Jinrong Liang
>
> Previous:
> https://lore.kernel.org/kvm/20230414110056.19665-1-cloudliang@tencent.com
>
> v2:
> - Wrap the code from the documentation in a block of code; (Bagas Sanjaya=
)
>
> Jinrong Liang (7):
>   KVM: selftests: Replace int with uint32_t for nevents
>   KVM: selftests: Apply create_pmu_event_filter() to fixed ctrs
>   KVM: selftests: Test unavailable event filters are rejected
>   KVM: x86/pmu: Add documentation for fixed ctr on PMU filter
>   KVM: selftests: Check if pmu_event_filter meets expectations on fixed
>     ctrs
>   KVM: selftests: Check gp event filters without affecting fixed event
>     filters
>   KVM: selftests: Test pmu event filter with incompatible
>     kvm_pmu_event_filter
>
>  Documentation/virt/kvm/api.rst                |  21 ++
>  .../kvm/x86_64/pmu_event_filter_test.c        | 239 ++++++++++++++++--
>  2 files changed, 243 insertions(+), 17 deletions(-)
>
>
> base-commit: a25497a280bbd7bbcc08c87ddb2b3909affc8402
> --
> 2.31.1
>

Polite ping.

Should I post version 3 to fix the problem of two "From: Jinrong Liang
<cloudliang@tencent.com>"?

Thanks