Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bf3a8c88-5b6c-6a8f-e5ba-6482655ecad0@wanadoo.fr>
Date:   Mon, 22 May 2023 06:16:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] sched/headers: remove duplicate included header
To:     "Yan Yan(cailing)" <yanyan.yan@antgroup.com>,
        linux-kernel@vger.kernel.org, mingo@redhat.com
Cc:     =?UTF-8?B?6LCI6Ym06ZSL?= <henry.tjf@antgroup.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>
References: <20230506153924.7641-1-yanyan.yan@antgroup.com>
 <f6a4ae36-9976-6727-f462-259517c8d0cb@antgroup.com>
 <512cf22a-1196-1191-cdbb-bda3a815999d@antgroup.com>
Content-Language: fr
From:   Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <512cf22a-1196-1191-cdbb-bda3a815999d@antgroup.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Le 22/05/2023 à 04:26, Yan Yan(cailing) a écrit :
> Ping, any comments?
> 
> thanks,
> 
> -Yan Yan
> 
> 在 2023/5/16 00:00, Yan Yan 写道:
>> Ping.
>>
>> It seems that removing the two same included lines is ok. Because the 
>> following "sched.h" also includes psi.h.
>>
>> Any comments?

FWIW, yes, looks good.


If you want to ga that way, their are some other potential removal 
candidates in build_utility.c:

	linux/sched/mm.h

	linux/cpufreq.h
	linux/ctype.h
	linux/proc_fs.h
	linux/spinlock_api.h
	linux/wait_api.h
	linux/workqueue_api.h

CJ

>>
>> Thanks,
>>
>> -Yan Yan
>>
>> 在 2023/5/6 23:39, 晏艳(采苓) 写道:
>>> linux/psi.h is included more than once.
>>>
>>> Signed-off-by: Yan Yan <yanyan.yan@antgroup.com>
>>> ---
>>>   kernel/sched/build_utility.c | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git a/kernel/sched/build_utility.c b/kernel/sched/build_utility.c
>>> index 99bdd96f454f..80a3df49ab47 100644
>>> --- a/kernel/sched/build_utility.c
>>> +++ b/kernel/sched/build_utility.c
>>> @@ -34,7 +34,6 @@
>>>   #include <linux/nospec.h>
>>>   #include <linux/proc_fs.h>
>>>   #include <linux/psi.h>
>>> -#include <linux/psi.h>
>>>   #include <linux/ptrace_api.h>
>>>   #include <linux/sched_clock.h>
>>>   #include <linux/security.h>
>