Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Eiichi Tsukata <eiichi.tsukata@nutanix.com>
To:     Paul Moore <paul@paul-moore.com>
CC:     "eparis@redhat.com" <eparis@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "audit@vger.kernel.org" <audit@vger.kernel.org>
Subject: Re: [PATCH v2 1/5] audit: refactor queue full checks
Thread-Topic: [PATCH v2 1/5] audit: refactor queue full checks
Thread-Index: AQHZg8hx4GQx7Y4VTUKTyKrSfQfRZa9iIKwAgAOg4gA=
Date:   Mon, 22 May 2023 04:19:23 +0000
Message-ID: <416541D8-EF38-4586-99A0-A7372E4FAEDD@nutanix.com>
References: <20230511052116.19452-2-eiichi.tsukata@nutanix.com>
 <1be99c1ede70b5c385acc16b59347d02.paul@paul-moore.com>
In-Reply-To: <1be99c1ede70b5c385acc16b59347d02.paul@paul-moore.com>
Accept-Language: ja-JP, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SeBJo0holHbjWvfFhx6no0/sTBsy8brwiHrbKlSqkyhZqsNKWWWLr8NBgWkD?=
 =?us-ascii?Q?enT/p6FY3KWm2ttMYuNHvzClua2HtLEoEDD/n4O/FGRm6+5ZloQkQrNmbvbd?=
 =?us-ascii?Q?kdGI3gmadQ9CH8Yc49G50cX1klKGo/N7ySDFMNj0rdK0ST+6hTVKt9yrlKW4?=
 =?us-ascii?Q?WLuXxLTI5bkbpMx77WepAqu3BB68Is8eYt+P9eDO9NjaehOB7tIQBCCpaZuw?=
 =?us-ascii?Q?08NM+EeDrBk2ZZ6xmNWK3XUjYqQnwfEJqY+beeM5tCZGiwqjo5YvHbP8N9KM?=
 =?us-ascii?Q?1iXcHikXJvBz74CO3IeIyxUKAMMVvxy+bQuFwskRbmtRp8SUbrlxLx5S1WMN?=
 =?us-ascii?Q?qhsliQ5ul8xE83F2rioMOinj1SZ0uYcF9w14/GC1LaLPupErSOLdqElflVHz?=
 =?us-ascii?Q?m+Ulevj7c2WOq5vdZiZ6MGJ9siOF122FwamvR+jN86TRZeC3keaXR4vwg4U3?=
 =?us-ascii?Q?q9aQrEqQ6NCnEHtTo1M/b6ts8BmsongIQlggo+WAM3MU0OIgf1+r6RsJfnM5?=
 =?us-ascii?Q?tTYLkunG2CaajrZXmZZGDu4vrfCaT40DtlKyTyGyr9WyUkM6gdmx6qE3m9YZ?=
 =?us-ascii?Q?IghV3NbBau17cbobMrNU0NSXmLPo7SFUeG3GSLAky7dWICYOP6Jmi2WgVjR6?=
 =?us-ascii?Q?tQ6hF8suEaDE5uwKS0vBCvTpfFxgVI11SDNcCZRB35tIVWicD+3oYzE4nXj0?=
 =?us-ascii?Q?laBeUwqPg0ZUEI0zk2j9YyV56BKJTVimStXlfRNVAWCybGqZTaSpbxuBKqU7?=
 =?us-ascii?Q?FxTkGCQyxsBIsI7NS5w6HbYx+aePTZ8utNDfFQy8EwVZskeZttdJuDIp24/t?=
 =?us-ascii?Q?PY2N5/zvo+GTOfCYng144yFhNJkwXn9Wi0Ifs7R8Di2fAw2xrZtWV7bCO/TI?=
 =?us-ascii?Q?KjvClDvmuAgqbvZ6Fd2d5h8t9R/Moxk7VfAgLkAVhKoky5YcZYdoZiwkvIF/?=
 =?us-ascii?Q?hxI6EhFuM6nQohsJoAckoZ8W53J20E3kh8NUAvohD9UkiRDT8c09a3cbW+qt?=
 =?us-ascii?Q?tqVcJw0BHji7u4IT04vpZF+F9ltUzs/unGx7S7Mdb8u9wSub2NcgO6z70wCC?=
 =?us-ascii?Q?DKGPJIBfVLZEk8L1ZftwUY9CU6vW0D6jRmRDMsq564FOdtmX4N+2Gke7eo9P?=
 =?us-ascii?Q?qxlXqMbh7Xc7ZzGA0g8abH3jamlVzMTqBHKS6cOW5dVB445DOH1bngVu15nN?=
 =?us-ascii?Q?hSH5lpraTqoqj0gMk2lzrB6J6tqgZkt6JzGT4gYttih8ETO7Tnneoab3nSoE?=
 =?us-ascii?Q?8AcsYuiy/UHwQ5kU7D8OMgYAU0KPPNopdq7Xmj2nQJf2FdVD8phSNWSVXc+R?=
 =?us-ascii?Q?7Yj7XNbq01L17RZV3d68rLsYStxyBQXt4+pTfxd71A6WnvfO08oeD5D352Gr?=
 =?us-ascii?Q?+W76DMtAmu4NPGjRivo5+72M9LcFAQ7ITzO02021nSHX3EhSFCk2sQy/KRq/?=
 =?us-ascii?Q?ueaNyJEzDrC7ceMwq7mKIH5qozOzHQhq6Z5POX5uIRLiiGGoMH2U0rz8Bp2a?=
 =?us-ascii?Q?xDiXVZI8PcNHT9uLQIK7xv2lgKqBaU+4+xhP8Hp/58h+7hJcE33S9NNp5MsB?=
 =?us-ascii?Q?TyNnl3buYrwt35DlJ1OFxqoIdjrQH4B7yZb+YOAjKuGGmftOyiHpNvYUJaSJ?=
 =?us-ascii?Q?pw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D8F5CED41E3DFD47A81E38B751AE84A8@namprd02.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nutanix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR02MB8041.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36d1f4ac-a53d-4edd-cdc4-08db5a7bb908
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2023 04:19:23.4879
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bb047546-786f-4de1-bd75-24e5b6f79043
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6ZwWuFOLxbT7cQTtUQMkL7qeOuD5G9NdlM6vBjpA/KyfyfGEjH+Bv546rTg+33pThiO9JWO4ZnEqWE3y/OXIV1Cb39KB3pJJBu0O16gp0Lo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR02MB7434
X-Proofpoint-GUID: oafxGzveo1y2LqShCteMR75oL2Dsvv1Q
X-Proofpoint-ORIG-GUID: oafxGzveo1y2LqShCteMR75oL2Dsvv1Q
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-22_02,2023-05-17_02,2023-02-09_01
X-Proofpoint-Spam-Reason: safe
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On May 20, 2023, at 5:54, Paul Moore <paul@paul-moore.com> wrote:
>=20
> On May 11, 2023 Eiichi Tsukata <eiichi.tsukata@nutanix.com> wrote:
>>=20
>> Currently audit queue full checks are done in multiple places.
>> Consolidate them into one audit_queue_full().
>>=20
>> Signed-off-by: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
>> ---
>> kernel/audit.c | 21 +++++++++++----------
>> 1 file changed, 11 insertions(+), 10 deletions(-)
>>=20
>> diff --git a/kernel/audit.c b/kernel/audit.c
>> index 9bc0b0301198..c15694e1a76b 100644
>> --- a/kernel/audit.c
>> +++ b/kernel/audit.c
>> @@ -341,6 +341,12 @@ static inline int audit_rate_check(void)
>> return retval;
>> }
>>=20
>> +static inline int audit_queue_full(const struct sk_buff_head *queue)
>> +{
>> + return audit_backlog_limit &&
>> +        (skb_queue_len(queue) > audit_backlog_limit);
>> +}
>=20
> Regardless of the other patches in this series, this seems like a
> good candidate to merge, but could you make it return a 'bool'
> instead of an 'int'?
>=20

Sure, will fix it in v3.

Eiichi