Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2528148rwd; Sun, 21 May 2023 23:34:52 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5SBie9eGRpn8UR9XByGCcGcwDNA4HqK9id+VxTDIg+0xhLg1T0oSTHFt1zy3953prwoxU7 X-Received: by 2002:a17:90a:9483:b0:233:fb7d:845a with SMTP id s3-20020a17090a948300b00233fb7d845amr9643017pjo.4.1684737292023; Sun, 21 May 2023 23:34:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684737292; cv=none; d=google.com; s=arc-20160816; b=chk4elrTeY0fLyMEEHuh6WJxoBM9Qz73/NtaQ+U1SMLumaZNzRFYHXnAR92CY8Gp95 64NwGpkpOAuiSh4OkqXvgQe5IOtZNBDvghTx5hbF/fS+CEB9VH4KHCoURX4JAD42kZh6 inOMFaL1pTvrqZXQdNR/w4YcdyyL9ewjkNiXdZAuS5u1WF8gkkUT6kBLquvfIHM7PNP5 jqrXhQZDsKccrqjuJnb6S9ikSNKeWnA3Cyom270fwc9IAwbVZ+gkJ7pKmKf2dWRehNMH wFBR17hVjwLR3LEs8WVBClCo2weyoyT+pPRNC9P2xzpYJ5LssAsvQcjydwPBKC0e30Xx C4AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=53XIR8Q3XsiGYdYxtSDcQeqgsEPCAGvDlbxQeA1BQ6M=; b=wbeAullcdPZRQfoA0BsAy47O2JBWxd5O8XFhSfOWqfN/3iIc+XjMJ3J6Z5SRfcEH0q rX8R5W+FabrheO6I2srG/z3iTbvvLlJlYM3G5UWka0O8KauvwE/e+BYizu8u6pOVtw+n SjFa108oT/zoK/J57XP5Osau1UF1nQOZGeZ6XBZQMd69ILeM7/THsJkdY1D8680sAvTa eIPvCsZYJEaY4QvmggI9MHTxPR4d0GNh+oBZy5TmU7+4NmoVMQJI1WWXwfStLyb8jurX 4VhnheDFTU2E6Qr6nX2yg8nGHG65FgRmqaPjzbjn6QBdn8LSOdF34xv4qw1l6THaD/qU gUGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EXFwzqEZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b24-20020a17090ae39800b0025363368425si4044045pjz.189.2023.05.21.23.34.36; Sun, 21 May 2023 23:34:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EXFwzqEZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230352AbjEVGZa (ORCPT + 99 others); Mon, 22 May 2023 02:25:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbjEVGZ3 (ORCPT ); Mon, 22 May 2023 02:25:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46A5CCF; Sun, 21 May 2023 23:25:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D090761BE2; Mon, 22 May 2023 06:25:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 365BDC433EF; Mon, 22 May 2023 06:25:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684736727; bh=53XIR8Q3XsiGYdYxtSDcQeqgsEPCAGvDlbxQeA1BQ6M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=EXFwzqEZ783ALOQeXFqvos+aAnLF8ZaOAss40WKXaWW2NjL3dSu7Wpvo3ogu2YdX7 ZThkI7s+P971hRJFcXBmKnFfTdfIXodbzvrT0T2ZkH1IBZy6lXH1wCUL8nsO2Yeb12 e9eNvliG6k8O8UFXGmde54Z2ftm8yreK4CSXOugC+84W1XYO3vtl1X5dh6LsjXT0Vz wQwpHUcAhBQ3wGNgEtXv2ebOsk9jiQvdeTuT0CKBrvSN7Nr4LlRHvA/PC/ZT7pbNeS F6sr/RSIcermTs0VCbMqP7vd7Hyx1L7kBsQn3EMgpXzwoAc2iyW5TDrmpliuZcadBU PoY2WANWnNjLg== Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2af316b4515so16897811fa.1; Sun, 21 May 2023 23:25:27 -0700 (PDT) X-Gm-Message-State: AC+VfDxQistE49233xgoriPVpkPzM93YydOtSyI6uonSPXpRFrRAWLY8 wIKAxj2U6niJIY4q25TmCDoXtj6sI93NtUJALr0= X-Received: by 2002:a2e:8695:0:b0:298:ad8e:e65 with SMTP id l21-20020a2e8695000000b00298ad8e0e65mr3326550lji.21.1684736725266; Sun, 21 May 2023 23:25:25 -0700 (PDT) MIME-Version: 1.0 References: <20230512015610.821290-1-yukuai1@huaweicloud.com> <20230512015610.821290-2-yukuai1@huaweicloud.com> In-Reply-To: From: Song Liu Date: Sun, 21 May 2023 23:25:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH -next 1/5] md/raid5: don't allow replacement while reshape is not done To: Yu Kuai Cc: logang@deltatee.com, reddunur@online.de, jovetoo@gmail.com, dgilmour76@gmail.com, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com, "yukuai (C)" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 21, 2023 at 8:46=E2=80=AFPM Yu Kuai w= rote: > > Hi, > > =E5=9C=A8 2023/05/20 7:33, Song Liu =E5=86=99=E9=81=93: > > On Thu, May 11, 2023 at 6:59=E2=80=AFPM Yu Kuai wrote: > >> > >> From: Yu Kuai > >> > >> Set rdev replacement has but not only two conditions: > >> > >> 1) MD_RECOVERY_RUNNING is not set; > >> 2) rdev nr_pending is 0; > > > > The above is confusing. I updated it and applied the set to md-next. > > By the way, I'm willing to add regression test for these problems, and I > already send two other tests and there are no response yet. Should the > test wait for fixed patch to be applied to make progress? Jes just had a baby, so there will be long delays with mdadm patches. I am already using the new tests, so please keep sending them. Thanks, Song