Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2534525rwd; Sun, 21 May 2023 23:43:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6rbcCqqRNdi9q4AojcC7LpeAaMNqmM6tVrjyU0881FbY90C4FB2waGjWUeXZwINUcYr7AU X-Received: by 2002:a17:903:2444:b0:1ab:1a6:34bc with SMTP id l4-20020a170903244400b001ab01a634bcmr12762109pls.9.1684737817455; Sun, 21 May 2023 23:43:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684737817; cv=none; d=google.com; s=arc-20160816; b=qGaI3hTvZ54x7LsASzh6FWVHqrhrepivsokWuoW8ov5Unfq9E2bSyz6+OXdUqvmnaD 8A6OIH67xKov23j9mm5lg1JCPg9bowsICn/sUHMBtXQOpHKkVAOJK99D72cTQL2bGgsE 3V5P6/Z2hZ+dUqd/l76OjB7Co4IFxBiNWonwhMq6OxkDa95UonzT5bk5Yp2j4MehHlb9 cyORF6mbwgxrlzGKk8YMGdT2Rjm4c8lYul4NHRJJ9mIgirc2ORFbcNmsyl8hPcue2fC0 Vb6yCZbOOmt0xeMRv4oMvPu01KwJCDrJfrYkRy28Uwu09vwsDcuBYPj67/S+bSuiiwRX M/HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=L51D923F/Qnr60svKwlOplic/YuXek4iXgzeRvfwk/0=; b=UtUTfr276Cxi1HXqgtwmYvuN4TZrbkBcRqZTA1UIaJOWf4rIPpTce2e224WY3SaREN vkZ1ga1jtOsWMqZD3rgvBxxqJ5rYvS624CUrsi1FnoPwiYp8N++XuMiAJWSMSuqWo+4c QR9T7HU/ZFGzVORKuecYPiPIG45DgHSdcc3riHIxBfrCuPHuP3dXCuvdn1OgwpQt8RmE +LD4xXlI264bg8LZRzsfzIqg0AY79TFhzfM6C1VktdU/mdi3EmXW0hjt4q1ktjC8ok2M o2KlyGqAFxEtR9/GRk4PV9d0IBUFHbABpCcmZO3jkkwk+r4UgCDCROZ54Pazj3aIQhFm RoXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b3TEzDau; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l6-20020a170902ec0600b001a21fd27407si3616529pld.469.2023.05.21.23.43.23; Sun, 21 May 2023 23:43:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b3TEzDau; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231622AbjEVG32 (ORCPT + 99 others); Mon, 22 May 2023 02:29:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231593AbjEVG31 (ORCPT ); Mon, 22 May 2023 02:29:27 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66090A9 for ; Sun, 21 May 2023 23:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684736925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L51D923F/Qnr60svKwlOplic/YuXek4iXgzeRvfwk/0=; b=b3TEzDauC4NXZUHMGNwYgn+fhD9njDkYOhG1UNT14cOfZmefBkCWKmU1g7WPVPJfmAg98Z riTIxdwU2gsSF3gYMYYXZPQRXvQHBU3jCFH1tKLKJADDSJkMhFH1PNwbHWtgfpDBq9uC6h 5SZR6wKhvXqiBU0C70BCgmDyUjaPgxs= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-197-_JqmLVPHOXevZRe0HvSLeg-1; Mon, 22 May 2023 02:28:41 -0400 X-MC-Unique: _JqmLVPHOXevZRe0HvSLeg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1F1933C025A2; Mon, 22 May 2023 06:28:40 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.39.192.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id EC7E8C54184; Mon, 22 May 2023 06:28:36 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <376ab23b-52d0-d7fd-2dd9-414cbb474e01@linux.alibaba.com> References: <376ab23b-52d0-d7fd-2dd9-414cbb474e01@linux.alibaba.com> <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-23-dhowells@redhat.com> To: Joseph Qi Cc: dhowells@redhat.com, Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Mark Fasheh , Joel Becker , ocfs2-devel@oss.oracle.com Subject: Re: [PATCH v21 22/30] ocfs2: Provide a splice-read stub MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2362050.1684736916.1@warthog.procyon.org.uk> Date: Mon, 22 May 2023 07:28:36 +0100 Message-ID: <2362051.1684736916@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joseph Qi wrote: > Don't see direct IO logic now. Am I missing something? See that patch description ;-) Provide a splice_read stub for ocfs2. This emits trace lines and does an atime lock/update before calling filemap_splice_read(). Splicing from direct I/O is handled by the caller. David