Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20230522063725.284686-1-apopple@nvidia.com>
 <620eef7f-ee01-673c-b097-243d6fe25b09@linux.dev>
User-agent: mu4e 1.8.10; emacs 28.2
From:   Alistair Popple <apopple@nvidia.com>
To:     Qi Zheng <qi.zheng@linux.dev>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        robin.murphy@arm.com, will@kernel.org, nicolinc@nvidia.com,
        linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
        jgg@nvidia.com, John Hubbard <jhubbard@nvidia.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mmu_notifiers: Notify on pte permission upgrades
Date:   Mon, 22 May 2023 17:45:59 +1000
In-reply-to: <620eef7f-ee01-673c-b097-243d6fe25b09@linux.dev>
Message-ID: <87a5xwajn4.fsf@nvidia.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2mBowBchH60lIXF65ytaSCc2rOKlgJzlBemp/jVppZ/FdzuHiLggsISM+T++?=
 =?us-ascii?Q?vM2cQAaURJCz9JlL/OVCpJ0Zi6IF8GhvrNeZKrEbzEKFU5O4v623CNCYmllj?=
 =?us-ascii?Q?TiGNkVkSivxrxNYgcIK3aM8hjN+Y+n1yyL+KvyYpdV5GNMBnk/8zDR20A7K7?=
 =?us-ascii?Q?0IK/Cb6xuoNFg/LGto2Pe1qJ9pER1dQX+wzrFLZ4wVzscFbGH3XkwuM2oooW?=
 =?us-ascii?Q?xyJJQNnM1k41M8vkLngramnWHIlkNmJGTaZA/yTYQI5OrteiIhND7p5U4km4?=
 =?us-ascii?Q?KKscq5IN/EortODjD8S9tlhu/QqC/r14XLh/rXmK/GigsW6FUbwr6t1TJAye?=
 =?us-ascii?Q?8xJEbBU8xvI/d63WOP8E5ylydpyN0brBXJ03oRoUNRER1tOjWMDdFAHxSVW8?=
 =?us-ascii?Q?VOTj4T+ul1gnaPwnWJM+tM/tzk2aJFK09hYbm32knPk5LjtWH0CRKhjk9+0R?=
 =?us-ascii?Q?xRwou7OvhEIRQtKr3rggtH39yeR4FyB+p7UHLoMn/ES3coi3oc9El0jG8KH0?=
 =?us-ascii?Q?jkRczAL7n2x37c++7vnhPv9gciCT6v+aXZhN+TAKvltyVUEiq4krHh0VKn73?=
 =?us-ascii?Q?7k5cXYU/FcFwrAQzhJgnHDcIBflJ74ipwuSumokwNmD76ataErH6htQrDNp7?=
 =?us-ascii?Q?rKHvf8RnaL0qCs/E/Gufyd8Jmit5ntBRF3AjLAlrg1BCvFWTv357gne/dgGk?=
 =?us-ascii?Q?F5LSUjeiRpS1Wa3BuBd95eB78avHI3zNSCXB3UZCMvM883GUTc43cX4WGOtE?=
 =?us-ascii?Q?+NiJ0vV39jAayfjJe6KaZY8Ye/yr/7mvu0b2LQM5/xCcgbOXysBXkvlMsJCr?=
 =?us-ascii?Q?6rNccFPg9CoUrkKR4zQfFCnnspZ1d/beU8ousNgtnfKmqMy8M9+HRnX+9Wxv?=
 =?us-ascii?Q?7l4GHqeD8DbFVv3ruSdRnYfw2s6haiWAVl4I1rFlttNmlkra97M6vxCGGQlg?=
 =?us-ascii?Q?/+vDiw8uAfZY/kgclpsGKLJqOoWJavvUQWzF8HGUDoRr5WbHDzJ6XSY/yDs5?=
 =?us-ascii?Q?cRuryy7FpBKNi2yl7QimAksY7zWP3qaUhEvRXgMcQOY5JYWHRKpLyEKg6VJL?=
 =?us-ascii?Q?hTBrrQqNj1iDkUwPI+gsx6pKSZqqGI+ZfayooYYbue8KH6IKOOvbfk4lsHs6?=
 =?us-ascii?Q?9HrzdoSrWeF9IXXLxMAcVoc47/WzVA6kmpylsBuMV1a5DBVs9y8tOISEFWzU?=
 =?us-ascii?Q?dX2kJmVoDC/WtNtJ8WrarU4XXopotBtMFlrf5pE4HcnZDj7eQA43cB1rP13A?=
 =?us-ascii?Q?tbVydoM/PinfWnWulb6KAQTpBmk8HVUlIwNRmq98oucbIq75k56z3G/QGUnp?=
 =?us-ascii?Q?DNTjLji/cyscoMlPJf3PwmIycv0S8z3rglAMyfaQhudGxSgMnqFyLDhrGX+w?=
 =?us-ascii?Q?cvw8YJhMGnbRkr4YSXcDkHk9nF6IleZDo1tI5Lhma+qpkd7c4KWCecA9n7Nq?=
 =?us-ascii?Q?VRuZgRV77N9T9bdrSBEdN2ma05N4dQo683mA4RM7paLMd+gkFn3ycoKCGMwc?=
 =?us-ascii?Q?jcMo7sTsjB0mfAWIGwDUpxxW5yInMrevIFANgz8vYrRgj7bKvrosukt8xxsE?=
 =?us-ascii?Q?sSNoc/J9aviDUVUsWXZKPf077V/JbP2vq8A0owgP?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f60ebe1a-e1f7-4445-22e8-08db5a9966c0
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 07:51:50.5021
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4Sf3HzQPiADa5sN9oXkIqbIVHbsUErEjmb19V1uK3B4IDXQ092UVTi/XGH7LxCWSYut3z8NAkzbA3GR73133iw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6778
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Qi Zheng <qi.zheng@linux.dev> writes:

> Hi Alistair,
>
> On 2023/5/22 14:37, Alistair Popple wrote:

[...]

>> +	if (changed) {
>> +		struct mmu_notifier_range range;
>> +
>> +		mmu_notifier_range_init(&range, MMU_NOTIFY_PROTECTION_UPGRADE,
>> +					0, vmf->vma, vmf->vma->vm_mm,
>> +					vmf->address & PAGE_MASK,
>> +					(vmf->address & PAGE_MASK) + PAGE_SIZE);
>> +		mmu_notifier_invalidate_range_start(&range);
>> +		mmu_notifier_invalidate_range_end(&range);
>> +	}
>
> There are four similar patterns, can we introduce a helper function to
> deduplicate them?

For sure. How about something like this?

void mmu_notifier_range_start_end(enum mmu_notifier_event event,
                                  struct vm_area_struct *vma,
                                  struct mm_struct *mm,
                                  unsigned long start,
                                  unsigned long end)

As an aside I didn't just use mmu_notifier_invalidate_range() as that
doesn't allow an event type to be set for interval notifiers which may
want to filter this.

>> +
>>   	return 0;
>>   }
>>