Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230512194302.1662230-1-nicholasbishop@google.com>
In-Reply-To: <20230512194302.1662230-1-nicholasbishop@google.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Mon, 22 May 2023 10:11:36 +0200
Message-ID: <CAMj1kXERDgT1cM-2P4M=DBGU0Wzbc-zewGsJjLQoQHpC3ds-4g@mail.gmail.com>
Subject: Re: [PATCH] efi/esrt: Allow ESRT access without CAP_SYS_ADMIN
To:     Nicholas Bishop <nicholasbishop@google.com>,
        Peter Jones <pjones@redhat.com>
Cc:     linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 12 May 2023 at 21:43, Nicholas Bishop <nicholasbishop@google.com> wrote:
>
> Access to the files in /sys/firmware/efi/esrt has been restricted to
> CAP_SYS_ADMIN since support for ESRT was added, but this seems overly
> restrictive given that the files are read-only and just provide
> information about UEFI firmware updates.
>
> Remove the CAP_SYS_ADMIN restriction so that a non-root process can read
> the files, provided a suitably-privileged process changes the file
> ownership first. The files are still read-only and still owned by root by
> default.
>
> Signed-off-by: Nicholas Bishop <nicholasbishop@google.com>

Seems reasonable to me. Peter?

> ---
>  drivers/firmware/efi/esrt.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
> index d5915272141f..aab96ab64a1a 100644
> --- a/drivers/firmware/efi/esrt.c
> +++ b/drivers/firmware/efi/esrt.c
> @@ -95,10 +95,6 @@ static ssize_t esre_attr_show(struct kobject *kobj,
>         struct esre_entry *entry = to_entry(kobj);
>         struct esre_attribute *attr = to_attr(_attr);
>
> -       /* Don't tell normal users what firmware versions we've got... */
> -       if (!capable(CAP_SYS_ADMIN))
> -               return -EACCES;
> -
>         return attr->show(entry, buf);
>  }
>
> --
> 2.40.1.606.ga4b1b128d6-goog
>